Ethernet offload options are not populated in new installs
Open, NormalPublicBUG
Actions

Assigned To

Authored By

	stepler
	Sep 12 2021, 2:20 PM

Description

Upgrade from 1.2.8 to 1.3-beta-202109120646:

vyos@vyos:~$ show configuration commands
set interfaces ethernet eth0 duplex 'auto'
set interfaces ethernet eth0 hw-id '52:54:00:06:c2:f9'
set interfaces ethernet eth0 offload gro
set interfaces ethernet eth0 offload gso
set interfaces ethernet eth0 offload sg
set interfaces ethernet eth0 offload tso
set interfaces ethernet eth0 speed 'auto'
set interfaces loopback lo
set system config-management commit-revisions '100'
set system conntrack modules ftp
set system conntrack modules h323
set system conntrack modules nfs
set system conntrack modules pptp
set system conntrack modules sip
set system conntrack modules sqlnet
set system conntrack modules tftp
set system console device ttyS0 speed '9600'
set system host-name 'vyos'
set system login user vyos authentication encrypted-password '$6$rCnbsfI70qU$L40hgx9iKjnUxuBc4POhPeFuvGtjeL3BaY5MvZazVObNoHf8bNUQ6Ly7ZyC2Z9D1Rx0K9J/pCwKB2jA4fz7PD0'
set system login user vyos authentication plaintext-password ''
set system name-server 'eth0'
set system ntp server 0.pool.ntp.org
set system ntp server 1.pool.ntp.org
set system ntp server 2.pool.ntp.org
set system syslog global facility all level 'info'
set system syslog global facility protocols level 'debug'
set system time-zone 'UTC'

New install of 1.3-beta-202109120646:

vyos@vyos:~$ show configuration commands
set interfaces ethernet eth0 hw-id '52:54:00:9f:53:e1'
set interfaces loopback lo
set system config-management commit-revisions '100'
set system conntrack modules ftp
set system conntrack modules h323
set system conntrack modules nfs
set system conntrack modules pptp
set system conntrack modules sip
set system conntrack modules sqlnet
set system conntrack modules tftp
set system console device ttyS0 speed '115200'
set system host-name 'vyos'
set system login user vyos authentication encrypted-password '$6$SsBOrOo.gbL9t$/55ibpLQ/s3tSqSPmwEd5oa0AQ4S3Bdg0OVKi0HGi1ssQgXoWqARC18VuMEMUP7Fo03nhwNaNbrTDOb03FlXh1'
set system login user vyos authentication plaintext-password ''
set system ntp server time1.vyos.net
set system ntp server time2.vyos.net
set system ntp server time3.vyos.net
set system syslog global facility all level 'info'
set system syslog global facility protocols level 'debug'

On upgrade, this is handled by migration script interfaces/20-to-21.

Details

Difficulty level: Unknown (require assessment)
Version: 1.3-beta-202109120646
Why the issue appeared?: Will be filled on close
Is it a breaking change?: Unspecified (possibly destroys the router)
Issue type: Bug (incorrect behavior)

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open	BUG	dmbaturin	T3824 Ethernet offload options are not populated in new installs
		Open	FEATURE REQUEST	jestabro	T6006 Configure system-specific capabilities independently of migration scripts

Event Timeline

stepler created this task.Sep 12 2021, 2:20 PM

This is because of T3821

Migration scripts are meant for adjusting old configs for a new configuration syntax version. I feel that using that mechanism for fresh installs is wrong and we should move that logic to a different place, ideally to the script that inserts MAC addresses in the config—I forgot which script it is.

1.3-beta-202109120646 doesn't have any commits from T3821:

vyos@vyos:~$ cat /opt/vyatta/etc/config.boot.default 
system {
    host-name vyos
    login {
        user vyos {
            authentication {
                encrypted-password $6$QxPS.uk6mfo$9QBSo8u1FkH16gMyAVhus6fU3LOzvLR9Z9.82m3tiHFAxTtIkhaZSWssSgzt4v4dGAL8rhVQxTg0oAG9/q11h/
                plaintext-password ""
            }
        }
    }
    syslog {
        global {
            facility all {
                level info
            }
            facility protocols {
                level debug
            }
        }
    }
    ntp {
        server "time1.vyos.net"
        server "time2.vyos.net"
        server "time3.vyos.net"
    }
    console {
        device ttyS0 {
            speed 115200
        }
    }
    config-management {
        commit-revisions 100
    }
}

interfaces {
    loopback lo {
    }
}

pasik added a subscriber: pasik.Sep 13 2021, 3:57 PM

c-po moved this task from Need Triage to Backlog on the VyOS 1.4 Sagitta board.Sep 19 2021, 7:28 PM

syncer assigned this task to dmbaturin.Oct 17 2021, 1:40 PM

syncer triaged this task as Normal priority.

syncer edited projects, added VyOS 1.3 Equuleus (1.3.0-epa3); removed VyOS 1.3 Equuleus.

syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus (1.3.0-epa3).Nov 1 2021, 10:11 PM

syncer edited projects, added VyOS 1.3 Equuleus (1.3.3); removed VyOS 1.3 Equuleus (1.3.0).Aug 29 2022, 7:04 AM

syncer edited projects, added VyOS 1.3 Equuleus (1.3.4); removed VyOS 1.3 Equuleus (1.3.3).Jul 12 2023, 9:39 PM

syncer edited projects, added VyOS 1.3 Equuleus (1.3.5); removed VyOS 1.3 Equuleus (1.3.4).Aug 25 2023, 9:29 PM

syncer edited projects, added VyOS 1.3 Equuleus (1.3.6); removed VyOS 1.3 Equuleus (1.3.5).Dec 17 2023, 11:37 PM

syncer edited projects, added VyOS 1.3 Equuleus (1.3.7); removed VyOS 1.3 Equuleus (1.3.6).Feb 10 2024, 9:17 AM

dmbaturin added a project: Restricted Project.Feb 15 2024, 12:49 PM