Page MenuHomeVyOS Platform

MGRE Tunnel commit crash If sit tunnel available
Closed, ResolvedPublicBUG

Description

The tunnel: T2920: Add checks tun with the same source addr and keys bring in new bug "if a sit tunnel available, the commit will crash".

Reason:

If a sit tunnel is in the system, the ikey is not available. Follow sit dict.

Fix:

Easy fix to change this line to
exist_key = tunnel_cfg['linkinfo']['info_data'].get('ikey', "")

or

change function get_interface_config to put ikey with a default value.

{
    'ifindex': 9,
    'link': 'none',
    'ifname': 'tun99',
    'flags': ['POINTOPOINT', 'NOARP', 'UP', 'LOWER_UP'],
    'mtu': 1476,
    'qdisc': 'noqueue',
    'operstate': 'UNKNOWN',
    'linkmode': 'DEFAULT',
    'group': 'default',
    'txqlen': 1000,
    'link_type': 'sit',
    'address': '50.9x',
    'link_pointtopoint': True,
    'broadcast': '216.21x8',
    'promiscuity': 0,
    'min_mtu': 1280,
    'max_mtu': 65555,
    'linkinfo': {'info_kind': 'sit', 'info_data': {
        'proto': 'ip6ip',
        'remote': '216.21x',
        'local': '50.9x',
        'ttl': 64,
        'tos': '0x1',
        'pmtudisc': True,
        'prefix': '2002::',
        'prefixlen': 16,
        }},
    'inet6_addr_gen_mode': 'none',
    'num_tx_queues': 1,
    'num_rx_queues': 1,
    'gso_max_size': 65536,
    'gso_max_segs': 65535,
    'ifalias': 'HE IPV6 TUN',
    }

Details

Difficulty level
Unknown (require assessment)
Version
1.3- epa1
Why the issue appeared?
Implementation mistake
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Event Timeline

c-po changed the task status from Open to Confirmed.Thu, Oct 7, 8:40 PM
c-po claimed this task.
c-po triaged this task as Normal priority.
c-po changed Why the issue appeared? from Will be filled on close to Implementation mistake.
c-po changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.
c-po moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.
c-po moved this task from Need Triage to 1.3.0-epa2 on the VyOS 1.3 Equuleus board.
c-po edited projects, added VyOS 1.3 Equuleus (1.3.0-epa2); removed VyOS 1.3 Equuleus.
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0-epa2) board.