Page MenuHomeVyOS Platform
Create Task
Maniphest T4021

Long commit time on bridge interface with 1-4094 allowed VLAN tags
Closed, ResolvedPublicBUG
Actions

Description

Commits normally take around a second or so except when there is a change on a bridge interface with allowed-vlan tag 1-4094 - then the commit time is 1 minute 15 seconds.

To reproduce:

set interfaces bridge br0 enable-vlan
commit (~1sec)
set interfaces bridge br0 member interface eth0 allowed-vlan 1-4094
commit (~75 seconds)
del interfaces bridge br0 member interface eth0 allowed-vlan 1-4094
commit (~75 seconds)
set interfaces bridge br0 member interface eth0 allowed-vlan 1-2000
commit (~35 seconds)

...commit-time seems proportional to number of allowed vlan-tags.

Also. Additional (non VLAN related) changes on the same interface (e.g. changing description) also yields a long commit time if the allowed vlan-tags are 1-4094. Changes not related to that interface have normal (very fast) commit times.

Details

Difficulty level
Unknown (require assessment)
Version
VyOS 1.4-rolling-202111240711
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Event Timeline

Boman created this task.Nov 27 2021, 4:33 PM
Viacheslav added a subscriber: Viacheslav.Dec 21 2021, 5:22 PM

@Boman I don't see such issue:

vyos@r11-roll# set interfaces bridge br0 enable-vlan 
[edit]
vyos@r11-roll# set interfaces bridge br0 member interface eth2 allowed-vlan 1-4094
[edit]
vyos@r11-roll# 
[edit]
vyos@r11-roll# time commit

real	0m9.989s
user	0m2.783s
sys	0m7.478s
[edit]
vyos@r11-roll# run show ver

Version:          VyOS 1.4-rolling-202112210318
Release train:    sagitta

Built by:         [email protected]
Built on:         Tue 21 Dec 2021 03:18 UTC

Check resources on your hypervisor.

Viacheslav changed the task status from Open to Needs testing.Dec 21 2021, 5:22 PM
pasik added a subscriber: pasik.Dec 21 2021, 7:23 PM
n.fort added a subscriber: n.fort.Jan 23 2022, 2:00 PM

On VyOS 1.4-rolling-202201230317.
Commands:

vyos@vyos# set interfaces bridge br0 enable-vlan
[edit]                                                                         '
[edit]yos# set interfaces bridge br0 member interface eth1 allowed-vlan '1-4094'
[edit]yos# set interfaces bridge br0 member interface eth2 allowed-vlan '1-4094'
[edit]yos# set interfaces bridge br0 member interface eth3 allowed-vlan '1-4094' 
vyos@vyos# time commit

real	0m33.160s
user	0m0.251s
sys	0m0.201s

Resources while that commit occurs shows increase of cpu, as shown in image

image.png (169×1 px, 45 KB)

While next commands, took 1/3 of time that took on first test, and cpu also got increase to 40%

vyos@vyos# set interfaces bridge br0 enable-vlan
[edit]                                                                         '
[edit]yos# set interfaces bridge br0 member interface eth1 allowed-vlan '1-4094' 
vyos@vyos# time commit

real	0m11.107s
user	0m0.211s
sys	0m0.189s

So

...commit-time seems proportional to number of allowed vlan-tags.

That seems to be true.

a.hajiyev added a subscriber: a.hajiyev.Nov 22 2023, 7:41 AM

Tested on VyOS 1.4-rolling-202311100309:

vyos@vyos# set interfaces bridge br0 enable-vlan
[edit]
vyos@vyos# set interfaces bridge br0 member interface eth2 allowed-vlan 1-4094
[edit]
vyos@vyos# time commit

real    0m9.233s
user    0m0.375s
sys     0m0.544s
[edit]

Did not observe any long commit time

a.hajiyev closed this task as Resolved.Nov 22 2023, 7:42 AM