Page MenuHomeVyOS Platform
Create Task
Maniphest T4052

Validator return traceback on VRRP configuration with the script path not in config dir
Closed, ResolvedPublicBUG
Actions

Description

vyos@vyos# set high-availability vrrp group GR1 health-check script '/vrrp-check.sh'

  Traceback (most recent call last):
    File "/usr/libexec/vyos/validators/script", line 40, in <module>
      f'Warning: file {path} is outside the / config directory
'
  NameError: name 'path' is not defined
  
  
  
  Invalid value
  Value validation failed
  Set failed

The reason is that python script does not know what is {path}, need replace to {script}
https://github.com/vyos/vyos-1x/blob/equuleus/src/validators/script#L40

Details

Difficulty level
Easy (less than an hour)
Version
1.3-beta-202112060443
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Related Objects

Event Timeline

Unknown Object (User) created this task.Dec 6 2021, 7:39 AM
Viacheslav claimed this task.Dec 6 2021, 7:55 AM
Unknown Object (User) added a project: VyOS 1.4 Sagitta.Dec 6 2021, 7:56 AM
Viacheslav added a comment.Dec 6 2021, 9:13 AM

PR https://github.com/vyos/vyos-1x/pull/1097

Viacheslav changed the task status from Open to In progress.Dec 6 2021, 9:17 AM
pasik added a subscriber: pasik.Dec 6 2021, 11:03 AM
Viacheslav changed the task status from In progress to Needs testing.Dec 6 2021, 5:00 PM
c-po moved this task from Need Triage to 1.3.0 on the VyOS 1.3 Equuleus board.Dec 6 2021, 5:45 PM
c-po edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.
c-po moved this task from 1.3.0 to Finished on the VyOS 1.3 Equuleus board.
c-po edited projects, added VyOS 1.3 Equuleus; removed VyOS 1.3 Equuleus (1.3.0).
c-po moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.
c-po edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.
Viacheslav closed this task as Resolved.Jan 3 2022, 5:17 PM
jestabro mentioned this in T3980: vrrp transition-script validator makes warning fatal and also causes a python NameError exception.Jan 8 2024, 7:59 PM