Page MenuHomeVyOS Platform

Incorrect firewall protocol completion help uppercase and duplicates
Closed, ResolvedPublicBUG

Description

Some protocols are in uppercase, some in lowercase and duplicate.
Completion script parses error.

vyos@r11-roll# set firewall name LOCAL-IN rule 10 protocol 
Possible completions:
   all          All IP protocols
   tcp_udp      Both TCP and UDP
   <0-255>      IP protocol number
   !<protocol>  IP protocol number
   0            
   1            
   103          
   108          
   112          
   115          
   12           
   124          
   132          
   133          
   135          
   136          
   137          
   138          
   139          
   140          
   141          
   142          
   17           
   2            
   20           
   22           
   27           
   29           
   3            
   33           
   36           
   37           
   38           
   4            
   41           
   43           
   44           
   45           
   46           
   47           
   5            
   50           
   51           
   57           
   58           
   59           
   6            
   60           
   73           
   8            
   81           
   88           
   89           
   9            
   93           
   94           
   97           
   98           
   AX.25        
   CPHB         
   DCCP         
   DDP          
   EGP          
   EIGRP        
   ENCAP        
   ETHERIP      
   FC           
   GGP          
   GRE          
   HIP          
   HMP          
   HOPOPT       
   ICMP         
   IDPR-CMTP    
   IDRP         
   IGMP         
   IGP          
   IP           
   IP-ENCAP     
   IPCOMP       
   IPIP         
   IPSEC-AH     
   IPSEC-ESP    
   IPv6         
   IPv6-Frag    
   IPv6-ICMP    
   IPv6-NoNxt   
   IPv6-Opts    
   IPv6-Route   
   ISIS         
   ISO-TP4      
   L2TP         
   MPLS-in-IP   
   Mobility-Header
                
   OSPFIGP      
   PIM          
   PUP          
   RDP          
   ROHC         
   RSPF         
   RSVP         
   SCTP         
   SKIP         
   ST           
   Shim6        
   TCP          
   UDP          
   UDPLite      
   VMTP         
   VRRP         
   WESP         
   XNS-IDP      
   XTP          
   ah           
   ax.25        
   dccp         
   ddp          
   egp          
   eigrp        
   encap        
   esp          
   etherip      
   fc           
   ggp          
   gre          
   hip          
   hmp          
   hopopt       
   icmp         
   idpr-cmtp    
   idrp         
   igmp         
   igp          
   ip           
   ipcomp       
   ipencap      
   ipip         
   ipv6         
   ipv6-frag    
   ipv6-icmp    
   ipv6-nonxt   
   ipv6-opts    
   ipv6-route   
   isis         
   iso-tp4      
   l2tp         
   manet        
   mobility-header
                
   mpls-in-ip   
   ospf         
   pim          
   pup          
   rdp          
   rohc         
   rspf         
   rsvp         
   sctp         
   shim6        
   skip         
   st           
   tcp          
   udp          
   udplite      
   vmtp         
   vrrp         
   wesp         
   xns-idp      
   xtp

Details

Difficulty level
Unknown (require assessment)
Version
VyOS 1.4-rolling-202201020317
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Cosmetic issue (typos etc.)

Event Timeline

Viacheslav changed the task status from Open to In progress.Jan 4 2022, 12:26 PM
Viacheslav claimed this task.
Viacheslav renamed this task from Some firewall protocol completion help in uppercase to Incorrect firewall protocol completion help uppercase and duplicates.Jan 4 2022, 1:21 PM
Viacheslav updated the task description. (Show Details)
Viacheslav moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.