Page MenuHomeVyOS Platform

Show vrrp if vrrp not configured bug
Closed, ResolvedPublicBUG

Description

If vrrp is not configured, but high-availability is configured, show vrrp hangs-up
and finally

[email protected]:~$ show vrrp
VRRP data is not available (wait time exceeded)
[email protected]:~$

Or with ctrl C:

[email protected]:~$ show vrrp 
:...skipping...
Traceback (most recent call last):
  File "/usr/libexec/vyos/op_mode/vrrp.py", line 45, in <module>
    print(VRRP.format(VRRP.collect('json')))
  File "/usr/lib/python3/dist-packages/vyos/ifconfig/vrrp.py", line 95, in collect
    util.wait_for_file_write_complete(fname,
  File "/usr/lib/python3/dist-packages/vyos/util.py", line 579, in wait_for_file_write_complete
    wait_for_inotify(file_path,
  File "/usr/lib/python3/dist-packages/vyos/util.py", line 562, in wait_for_inotify
    for event in i.event_gen(yield_nones=True):
  File "/usr/lib/python3/dist-packages/inotify/adapters.py", line 210, in event_gen
    events = self.__epoll.poll(block_duration_s)
KeyboardInterrupt

For example, virtual-server also uses keepalived:

set high-availability virtual-server 203.0.113.112 real-server 192.0.2.12 port '22'

Process keepalived running https://github.com/vyos/vyos-1x/blob/b34c9664ba69cd4876a0c7c552b466035583e505/src/op_mode/vrrp.py#L39
But there are no any information related vrrp

It requires to check if high-availability vrrp exists in the configuration and then keepalived pid itself

Details

Difficulty level
Easy (less than an hour)
Version
VyOS 1.4-rolling-202201120317
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)