Page MenuHomePhabricator

Disabling the in-memory table plugin has no effect
Closed, ResolvedPublicBUG

Description

When adding the "set system flow-accounting disable-imt" statement to the flow accounting configuration, the IMT plugin is still configured. It appears that the 'disable-imt' portion of the configuration tree is not getting defined. To check this, I added "print $config->returnValue('disable-imt');" below line 289 of the /opt/vyatta/sbin/vyatta-netflow.pl script and the removed and readded my flow accounting configuration. I received an error on the cli saying "Use of uninitialized value in print at /opt/vyatta/sbin/vyatta-netflow.pl line 290."

Details

Difficulty level
Normal (likely a few hours)
Version
1.1.8
Why the issue appeared?
Will be filled on close
cohn created this task.Nov 14 2017, 5:24 PM
syncer triaged this task as Low priority.Dec 21 2017, 9:17 PM
syncer edited projects, added VyOS 1.1.x (1.1.9), VyOS 1.2.x; removed VyOS 1.1.x (1.1.8).
syncer added a subscriber: syncer.

please retest on latest rolling

cohn added a comment.Oct 27 2018, 11:57 PM

Tested on the latest 1.2.0-rc4 and it appears that the memory plugin is still enabled.

I'm using the following configuration:

set system flow-accounting disable-imt
set system flow-accounting interface 'eth0'
set system flow-accounting netflow sampling-rate '1'
set system flow-accounting netflow server x.x.x.x port '2556'
set system flow-accounting netflow version '9'
set system flow-accounting syslog-facility 'daemon'

I see the following in my process list:

root@vyos:~# ps auxwww | grep uacct
root      8783  0.0  2.8 115508 29528 ?        Ss   23:38   0:00 uacctd: Core Process [default]
root      8785  0.0  1.4 109820 15000 ?        S    23:38   0:00 uacctd: IMT Plugin [default_memory]
root      8786  0.0  0.5 100572  6100 ?        S    23:38   0:00 uacctd: Netflow Probe Plugin [default_nfprobe]

And the following plugins are enabled in my uacctd configuration:

root@vyos:~# grep plugins /etc/pmacct/uacctd.conf
plugins: memory,nfprobe
syncer assigned this task to hagbard.Oct 28 2018, 8:46 AM
hagbard changed the task status from Open to In progress.Thu, Nov 15, 5:24 PM

bug confirmed in 1.2.0-rolling+201811150337.

c-po added a subscriber: c-po.Thu, Nov 15, 6:38 PM

Your commit enables memory plugin when disable is configured?

Ahh crap. I'll fix that right away.