Page MenuHomeVyOS Platform
Create Task
Maniphest T4647

Add Google Virtual NIC (gVNIC) support
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

This NIC type is now one of the native types for Google Cloud and can be enabled with a simple kernel config:

CONFIG_NET_VENDOR_GOOGLE=y
CONFIG_GVE=m

Details

Difficulty level
Easy (less than an hour)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Improvement (missing useful functionality)

Related Objects

Event Timeline

zsdc created this task.Aug 25 2022, 2:12 PM
zsdc updated the task description. (Show Details)
zsdc assigned this task to c-po.Aug 25 2022, 2:30 PM
c-po added a comment.Aug 25 2022, 5:14 PM

PR for 1.3 https://github.com/vyos/vyos-build/pull/258

c-po changed the task status from Open to In progress.Aug 25 2022, 5:14 PM
c-po triaged this task as High priority.
c-po moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.
c-po edited projects, added VyOS 1.3 Equuleus (1.3.2); removed VyOS 1.3 Equuleus.
c-po changed Difficulty level from Unknown (require assessment) to Easy (less than an hour).
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.2) board.
c-po closed this task as Resolved.Aug 27 2022, 5:49 PM
dmbaturin mentioned this in 1.3.2.Sep 5 2022, 3:14 PM
dmbaturin reopened this task as Open.Sep 7 2022, 1:32 PM
dmbaturin added a subscriber: dmbaturin.

As @zsdc says, it's not enough to just have the driver, the problem is that it doesn't work with MTUs over 1460, and VyOS now tries to force it to 1500 if it's not specified. We need to adjust that logic so that MTU setting error doesn't cause a commit error.

Whether we should add a special case or try to "adaptively" set the MTU is up to debate.

pasik added a subscriber: pasik.Sep 7 2022, 4:36 PM
zsdc added a comment.Sep 9 2022, 11:35 AM

I am suggesting marking this task as "Resolved" because the driver works by himself and NIC can be used with a proper configuration.

The MTU problem is far more complex and should be reviewed independently. I already tried to raise it once in https://phabricator.vyos.net/T4572. We should create a specific task for it again.

c-po closed this task as Resolved.Sep 12 2022, 6:57 AM