Page MenuHomeVyOS Platform
Create Task
Maniphest T4727

Add RADIUS rate limit support to PPTP server
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

Right now we have support for RADIUS rate-limit in all accel-ppp services except PPTP, even though there seems to be no reason to omit it. Since those options are now in a reusable XML, all we need to do is to include it in the PPTP interface definitions and extend the Jinja2 template.

Details

Difficulty level
Unknown (require assessment)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Improvement (missing useful functionality)

Related Objects

Mentioned In
1.3.3

Event Timeline

dmbaturin created this task.Oct 3 2022, 4:26 PM
pasik added a subscriber: pasik.Oct 3 2022, 5:58 PM
Viacheslav added a subscriber: Viacheslav.Apr 11 2023, 6:09 PM

For 1.4 rate-limit in the wrong place

set vpn pptp remote-access authentication rate-limit

Expected in the radius section:

set vpn pptp remote-access authentication radius rate-limit
Viacheslav changed the subtype of this task from "Task" to "Feature Request".Apr 11 2023, 7:31 PM
Viacheslav added a comment.EditedApr 11 2023, 7:33 PM

PR for 1.3 https://github.com/vyos/vyos-1x/pull/1952
PR for 1.4 fix https://github.com/vyos/vyos-1x/pull/1953

Viacheslav closed this task as Resolved.Apr 13 2023, 11:23 AM
Viacheslav moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.3) board.
Viacheslav moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.
dmbaturin mentioned this in 1.3.3.May 19 2023, 1:04 PM