Page MenuHomeVyOS Platform

NVME storage is not detected properly during installation
Closed, ResolvedPublicBUG

Description

Installation script detects NVME partitions as drives, which allows selecting wrong/impossible install target. For example:

I found the following drives on your system:
 nvme0n1	4294MB
 nvme0n1p1	4292MB

Also, NVME partition names are not generated properly later. This adds more errors to the installation process:

Looking for pre-existing RAID groups...none found.
cannot mount /dev/nvme0n11
cannot mount /dev/nvme0n12
cannot mount /dev/nvme0n13

We should fix the installation script to avoid these mistakes.

Parser error located here: https://github.com/vyos/vyatta-cfg-system/blob/c196da35164f87268522ab1ba97d507f446e4ed6/scripts/install/install-functions#L177-L180
Partition names generation here: https://github.com/vyos/vyatta-cfg-system/blob/c196da35164f87268522ab1ba97d507f446e4ed6/scripts/install/install-get-partition#L574-L576

Details

Difficulty level
Normal (likely a few hours)
Version
1.4-rolling-202210180800, 1.3.2
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Related Objects

Mentioned In
1.3.5

Event Timeline

zsdc changed the task status from Open to In progress.Oct 27 2022, 10:50 AM
zsdc claimed this task.
zsdc changed the task status from In progress to Needs testing.Nov 2 2022, 4:10 PM

Sure, it is fully compatible with 1.3. If no problems are found after the changes in 1.4 it must be backported.

TLDR; confirmed fixed for 1.3, please backport.

I encountered this problem as well on 1.3 on a Deciso DEC740 with NVME storage. I applied the patch by @zsdc, rebuilt a .deb for vyatta-cfg-system, baked it into the ISO and I was then able to install VyOS to the NVME storage without problems.

@marc_s thanks for testing !

And yep, this definitely should be backported to 1.3 branch, as nvme storage is very common these days..

@marc_s Would you be able to open a PR against 1.3 ?