Page MenuHomeVyOS Platform

PPPoE server incorrect unconfigured check
Closed, ResolvedPublicBUG

Description

To reproduce:

set service pppoe-server interface eth1
commit

commit:

[email protected]# commit
[ service pppoe-server ]
VyOS had an issue completing a command.


Report time:      2022-11-07 18:25:11
Image version:    VyOS 1.4-rolling-202211010829
Release train:    current

Built by:         [email protected]
Built on:         Tue 01 Nov 2022 08:29 UTC
Build UUID:       15370146-6844-4479-b4a6-b0d265eea441
Build commit ID:  64e77f12f66ce4

Architecture:     x86_64
Boot via:         installed image
System type:      KVM guest

Hardware vendor:  QEMU
Hardware model:   Standard PC (Q35 + ICH9, 2009)
Hardware S/N:     
Hardware UUID:    4d6f4d29-1ae8-446f-8d2b-3decd9da64c7

Traceback (most recent call last):
  File "/usr/libexec/vyos/conf_mode/service_pppoe-server.py", line 103, in <module>
    verify(c)
  File "/usr/libexec/vyos/conf_mode/service_pppoe-server.py", line 52, in verify
    verify_accel_ppp_base_service(pppoe)
  File "/usr/lib/python3/dist-packages/vyos/configverify.py", line 394, in verify_accel_ppp_base_service
    for user in dict_search('authentication.local_users.username', config):
TypeError: 'NoneType' object is not iterable



[[service pppoe-server]] failed
Commit failed
[edit]
[email protected]#

Details

Difficulty level
Easy (less than an hour)
Version
VyOS 1.4-rolling-202211010829
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)