Page MenuHomeVyOS Platform

PPPoE server does not restart service if pool was changed
Closed, ResolvedPublicBUG

Description

PPPoE server does not restart service if the pool is changed
some configurations require restart [email protected] but we have the option reload-or-restart

to reproduce:

set service pppoe-server access-concentrator 'ACN'
set service pppoe-server authentication local-users username userone password 'bar'
set service pppoe-server authentication mode 'local'
set service pppoe-server gateway-address '100.64.40.1'
set service pppoe-server interface eth1
commit
set service pppoe-server client-ip-pool start '100.64.40.10'
set service pppoe-server client-ip-pool stop '100.64.40.50'
commit

logs:

Nov 07 18:42:38 r14 accel-pppoe[6170]: eth1:: lcp_layer_init
Nov 07 18:42:38 r14 accel-pppoe[6170]: eth1:: auth_layer_init
Nov 07 18:42:38 r14 accel-pppoe[6170]: eth1:: ccp_layer_init
Nov 07 18:42:38 r14 accel-pppoe[6170]: eth1:: ipcp_layer_init
Nov 07 18:42:38 r14 accel-pppoe[6170]: eth1:: ipv6cp_layer_init
Nov 07 18:42:38 r14 accel-pppoe[6170]: eth1:: ppp establishing
Nov 07 18:42:38 r14 accel-pppoe[6170]: eth1:: lcp_layer_start
Nov 07 18:42:38 r14 accel-pppoe[6170]: eth1:: send [LCP ConfReq id=f4 <auth PAP> <mru 1492> <magic 14f50574>]
Nov 07 18:42:38 r14 accel-pppoe[6170]: eth1:: recv [LCP ConfReq id=7 <mru 1492> <magic f47351dd>]
Nov 07 18:42:38 r14 accel-pppoe[6170]: eth1:: send [LCP ConfAck id=7]
Nov 07 18:42:38 r14 accel-pppoe[6170]: eth1:: recv [LCP ConfAck id=f4 <auth PAP> <mru 1492> <magic 14f50574>]
Nov 07 18:42:38 r14 accel-pppoe[6170]: eth1:: lcp_layer_started
Nov 07 18:42:38 r14 accel-pppoe[6170]: eth1:: auth_layer_start
Nov 07 18:42:38 r14 accel-pppoe[6170]: eth1:: recv [LCP EchoReq id=0 <magic f47351dd>]
Nov 07 18:42:38 r14 accel-pppoe[6170]: eth1:: send [LCP EchoRep id=0 <magic 14f50574>]
Nov 07 18:42:38 r14 accel-pppoe[6170]: eth1:: recv [PAP AuthReq id=7]
Nov 07 18:42:38 r14 accel-pppoe[6170]: ppp3:userone: connect: ppp3 <--> pppoe(52:54:00:38:cc:4f)
Nov 07 18:42:38 r14 accel-pppoe[6170]: ppp3:userone: ppp connected
Nov 07 18:42:38 r14 accel-pppoe[6170]: ppp3:userone: send [PAP AuthAck id=7 "Authentication succeeded"]
Nov 07 18:42:38 r14 accel-pppoe[6170]: ppp3:userone: userone: authentication succeeded
Nov 07 18:42:38 r14 accel-pppoe[6170]: ppp3:userone: auth_layer_started
Nov 07 18:42:38 r14 accel-pppoe[6170]: ppp3:userone: ccp_layer_start
Nov 07 18:42:38 r14 accel-pppoe[6170]: ppp3:userone: ipcp_layer_start
Nov 07 18:42:38 r14 accel-pppoe[6170]: ppp3:userone: ipv6cp_layer_start
Nov 07 18:42:38 r14 accel-pppoe[6170]: ppp3:userone: recv [IPCP ConfReq id=7 <addr 0.0.0.0> <dns1 0.0.0.0> <dns2 0.0.0.0>]

Nov 07 18:42:38 r14 accel-pppoe[6170]: ppp3:userone: ppp: no free IPv4 address
Nov 07 18:42:38 r14 accel-pppoe[6170]: ppp3:userone: send [LCP ProtoRej id=246 <8021>]

as a result pppoe-client can not receive the address

Details

Difficulty level
Normal (likely a few hours)
Version
VyOS 1.4-rolling-202211010829
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)