DNS forwarder config broken with more than 2 zones
Closed, ResolvedPublicBUG
Actions

Assigned To

Authored By

	mb300sd
	May 29 2018, 4:34 AM

Tags

Referenced Files

None

Subscribers

Active contributors

Description

from /usr/libexec/vyos/conf_mode/dns_forwarding.py

forward-zones={% for d in domains %}
{{ d.name }}={{ d.servers | join(";") }}
{%- if loop.first %}, {% endif %}
{% endfor %}

Is only generating a comma between the first 2 zones.

Details

Difficulty level: Easy (less than an hour)
Version: VyOS 1.2.0-rolling+201805290337
Why the issue appeared?: Will be filled on close

Event Timeline

mb300sd created this task.May 29 2018, 4:34 AM

Good catch. The proper solution should be:

{%- if not loop.last %}, {% endif %}

c-po moved this task from Need Triage to Finished on the VyOS 1.2 Crux board.May 29 2018, 5:58 AM

syncer closed this task as Resolved.May 29 2018, 9:29 AM

syncer claimed this task.

syncer edited projects, added VyOS 1.2 Crux (VyOS 1.2.0-rc1), VyOS-1.2.0-GA; removed VyOS 1.2 Crux.Oct 15 2018, 11:55 PM

syncer moved this task from Needs Triage to Finished on the VyOS 1.2 Crux (VyOS 1.2.0-rc1) board.Oct 15 2018, 11:58 PM