Page MenuHomePhabricator

DNS forwarder config broken with more than 2 zones
Closed, ResolvedPublicBUG

Description

from /usr/libexec/vyos/conf_mode/dns_forwarding.py

forward-zones={% for d in domains %}
{{ d.name }}={{ d.servers | join(";") }}
{%- if loop.first %}, {% endif %}
{% endfor %}

Is only generating a comma between the first 2 zones.

Details

Difficulty level
Easy (less than an hour)
Version
VyOS 1.2.0-rolling+201805290337
Why the issue appeared?
Will be filled on close
mb300sd created this task.May 29 2018, 4:34 AM
c-po added a subscriber: c-po.May 29 2018, 5:57 AM

Good catch. The proper solution should be:

{%- if not loop.last %}, {% endif %}
c-po moved this task from Need Triage to Finished on the VyOS 1.2 Crux board.May 29 2018, 5:58 AM
syncer closed this task as Resolved.May 29 2018, 9:29 AM
syncer claimed this task.