Page MenuHomePhabricator

set system flow-accounting netflow source-ip failed
Closed, ResolvedPublicBUG

Description

We are running VyOS 1.1.8 on AWS enviroment from AWS Marketplace AMI

After enabling netflow daemon we decide to set proper source IP address for netflow flows.

Here is an error message:

admin@gw-virginia-1c# set system flow-accounting netflow source-ip
Possible completions:
   <x.x.x.x>    IPv4 source address of NetFlow packets
   <h:h:h:h:h:h:h:h>
                IPv6 source address of NetFlow packets


[edit]
admin@gw-virginia-1c# set system flow-accounting netflow source-ip 192.168.253.13

  "192.168.253.13" is not a valid value of type "ipv6"
  Value validation failed
  Set failed

[edit]
admin@gw-virginia-1c#
[edit]
admin@gw-virginia-1c# set system flow-accounting netflow source-ip
Possible completions:
   <x.x.x.x>    IPv4 source address of NetFlow packets
   <h:h:h:h:h:h:h:h>
                IPv6 source address of NetFlow packets


[edit]
admin@gw-virginia-1c# set system flow-accounting netflow source-ip "192.168.253.13"

  "192.168.253.13" is not a valid value of type "ipv6"
  Value validation failed
  Set failed

[edit]
admin@gw-virginia-1c# set system flow-accounting netflow source-ip '192.168.253.13'

  "192.168.253.13" is not a valid value of type "ipv6"
  Value validation failed
  Set failed

[edit]

I suppose this is validation script bug. Should be checked on 1.2.x also.

Details

Difficulty level
Easy (less than an hour)
Version
1.1.8
Why the issue appeared?
Implementation mistake
begetan created this task.Jun 21 2018, 9:45 AM
syncer triaged this task as Normal priority.Jun 21 2018, 10:40 AM
syncer assigned this task to c-po.
syncer added subscribers: c-po, dmbaturin, syncer.

Thanks for reporting @begetan !
@c-po want to look in relevant scripts, I think he is correct and that ipv6 validation likely present in 1.2 too
@dmbaturin see yourself too.

c-po added a comment.Jun 21 2018, 12:58 PM

This problem exists at least with VyOS 1.2.0-rolling+201806040337 as I've stumbled accross this one, too.

c-po added a comment.Jun 21 2018, 8:10 PM
cpo@LR1# set system flow-accounting netflow source-ip 192.168.253.13
[edit]
cpo@LR1# show system flow-accounting
+netflow {
+    source-ip 192.168.253.13
+}

or

cpo@LR1# set system flow-accounting netflow source-ip 2001:db8::1
[edit]
cpo@LR1# show system flow-accounting
+netflow {
+    source-ip 2001:db8::1
+}
c-po added a comment.Jun 21 2018, 8:13 PM

Fix applied to current and helium branch (if there will be a 1.1.9 release)

c-po moved this task from Need Triage to Finished on the VyOS 1.2.x board.Jun 21 2018, 8:13 PM
c-po closed this task as Resolved.Aug 15 2018, 9:51 AM
c-po changed Difficulty level from Unknown (require assessment) to Easy (less than an hour).
c-po changed Why the issue appeared? from Will be filled on close to Implementation mistake.
c-po reopened this task as In progress.
c-po closed this task as Resolved.Sat, Oct 20, 9:16 PM