Cake and FQ-PIE
Closed, ResolvedPublicFEATURE REQUEST
Actions

Assigned To

Authored By

	syncer
	Jun 30 2018, 12:33 AM

Description

We need to add Cake and FQ-PIE
this will be beneficial for many use cases
Relevant info:
https://www.bufferbloat.net/projects/attachments/150817135028_cake-battlemesh-v8.pdf
https://community.ubnt.com/t5/EdgeRouter/Cake-and-FQ-PIE-compiled-for-the-EdgeRouter-devices/td-p/1679844
https://github.com/dtaht/sch_cake
Patch to add cake support to iproute2:

https://raw.githubusercontent.com/lede-project/source/master/package/network/utils/iproute2/patches/950-add-cake-to-tc.patch
QoS scripts:
https://github.com/tohojo/sqm-scripts/blob/master/src/layer_cake.qos
https://github.com/tohojo/sqm-scripts/blob/master/src/piece_of_cake.qos

https://github.com/hironoriokano/fq-pie
https://github.com/hironoriokano/iproute2_fq-pie

Details

Difficulty level: Hard (possibly days)
Version: -
Why the issue appeared?: Will be filled on close
Is it a breaking change?: Unspecified (possibly destroys the router)
Issue type: Feature (new functionality)

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	FEATURE REQUEST	c-po	T4284 QoS: rewrite to XML and Python
Resolved	FEATURE REQUEST	c-po	T725 Cake and FQ-PIE
Resolved	FEATURE REQUEST	c-po	T792 Update VyOS Kernel 4.14 -> 4.18 and iproute2

Event Timeline

syncer triaged this task as Wishlist priority.Jun 30 2018, 12:33 AM

syncer created this task.

syncer updated the task description. (Show Details)Jul 1 2018, 12:56 PM

I've attempted to backport the CAKE patches accepted into net-next for the VyOS kernel here: https://github.com/Lochnair/vyos-kernel/commits/linux-vyos-4.14.y
I've gotten it to the point that it compiles, but I haven't tested to see if I accidentally broke anything. Partly because I haven't had the chance to look at backporting the tc stuff yet.

Is this stuff upstream? If so, we could also upgrade to 4.18, the save the backporting trouble?

We could also compile it as module (if supported) same we do for wireguard.

CAKE is upstream, but it didn't make it into 4.18, so it's currently only in master. To be fair it's easy enough to backport for 4.14, most of it is small changes.
Also I thought you'd prefer to stay on a LTS kernel, thus the backporting attempt.

And yes they do have an out-of-tree repository, so we could just use that.
It's just my personal preference to avoid out-of-tree modules whenever possible.

Edit: Even if we used the out-of-tree repo, we'd still have to backport the iproute2 patches.

Thx for the info. Yeah it's a per person choice if in-tree is preferred over out-of-tree.

For VyOS we already have a modular Kernel (for now) IMHO it's easier for an out of tree module (besides a new CI job + repository) b/c it will become beneficial on Kernel upgrades to later versions (less patches to port).

I'm fine with every implementation right now as it's your contribution (THX by the way)!

Hrrmf, 'twas more painful to get the iproute2 patches right than I'd hoped. Not sure how much effort I should spend getting the patches to apply, or if we should just bump to 4.18.
Apart from the kernel headers in the iproute2 tree, everything works as-is that way.

Upgrading to 4.18 should not take more then two hours incl. Iproute2 for me. Should we give it a try? Then I prepare an ISO

Might as well if you're up for it :)

For iproute2 we need these patches:
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=714444c0cb262e2c2a8d7398e3649c9b84666df0
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=77c9fbd06e1350e14d3b565d9d5beb0c5af692bf
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/include/uapi/linux/pkt_sched.h?id=8b099da560d654682ed9e0a46e93046b642e9c2b
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=23a67b008aea05992eb5b5c24c76e38c3ca7074a

I've also started thinking about the template:

traffic-policy {
    cake cakepolicy {
        bandwidth 10mbit
        direction egress
        flow-isolation dual-srchost
        memlimit 4096000
        nat-lookup enable
        overhead 32 atm
        priority-queue diffserv4
        rtt 100ms
        split-gso enable
        wash disable
    }
}

Please have a look at the man page to see what we need to include: https://dl.lochnair.net/Bufferbloat/Cake/tc-cake.8.html
Part of the challenge is that CAKE has a lot of keywords for ease-of-use. For example on my connection bridged-llcsnap is the right keyword to use, but it's actually just a shortcut for overhead 32 atm.
Similar issues for bandwidth, where you can either have 10mbit, unlimited or autorate-ingress. I'm not familiar enough with either the old template system, or the new XML one to know how to best represent this.

@Lochnair see branches at:

https://lwn.net/Articles/762566/ states:

The CAKE queuing discipline, which works to overcome bufferbloat and other problems associated with home network links, has been merged.

ISO (with Kernel 4.18 and iproute2 4.18) can be found here at 11:30 p.m. CEST (UTC +2):

http://www.mybll.net/vyos-1.2.0-rolling+201808202221-amd64.iso

cpo@LR1:~$ uname -a
Linux LR1.mucI.mybll.net 4.18.0-amd64-vyos #3 SMP Mon Aug 20 21:32:31 CEST 2018 x86_64 GNU/Linux

cpo@LR1:~$ sudo modprobe wireguard
cpo@LR1:~$ dmesg | tail -n 3
[  180.114930] wireguard: loading out-of-tree module taints kernel.
[  180.115868] wireguard: WireGuard 0.0.20180708-1 loaded. See www.wireguard.com for information.
[  180.115869] wireguard: Copyright (C) 2015-2018 Jason A. Donenfeld <[email protected]>. All Rights Reserved.

cpo@LR1:~$ ip -V
ip utility, iproute2-ss171113

In T725#18039, @c-po wrote:

@Lochnair see branches at:

https://github.com/vyos/vyatta-iproute/tree/iproute2-vyos-4.18.y

https://github.com/vyos/vyos-kernel/tree/linux-vyos-4.18.y

Nice work!

https://lwn.net/Articles/762566/ states:

The CAKE queuing discipline, which works to overcome bufferbloat and other problems associated with home network links, has been merged.

I'm well aware that it's been merged, but we still won't see it in a release before 4.19 is released mid-October.

ISO (with Kernel 4.18 and iproute2 4.18) can be found here at 11:30 p.m. CEST (UTC +2):

http://www.mybll.net/vyos-1.2.0-rolling+201808202221-amd64.iso

cpo@LR1:~$ uname -a
Linux LR1.mucI.mybll.net 4.18.0-amd64-vyos #3 SMP Mon Aug 20 21:32:31 CEST 2018 x86_64 GNU/Linux

cpo@LR1:~$ sudo modprobe wireguard
cpo@LR1:~$ dmesg | tail -n 3
[  180.114930] wireguard: loading out-of-tree module taints kernel.
[  180.115868] wireguard: WireGuard 0.0.20180708-1 loaded. See www.wireguard.com for information.
[  180.115869] wireguard: Copyright (C) 2015-2018 Jason A. Donenfeld <[email protected]>. All Rights Reserved.

cpo@LR1:~$ ip -V
ip utility, iproute2-ss171113

Not that I've tested it "properly", but your ISO seemed to work fine in a VM I fired it up in.

I've opened PRs against vyos-kernel and vyatta-iproute with the CAKE patches. I'll try to build an ISO with these patches included later.

c-po changed the status of subtask T792: Update VyOS Kernel 4.14 -> 4.18 and iproute2 from Open to In progress.Aug 23 2018, 9:43 AM

c-po closed subtask T792: Update VyOS Kernel 4.14 -> 4.18 and iproute2 as Resolved.Aug 26 2018, 7:34 PM

pasik added a subscriber: pasik.Mar 12 2019, 6:13 PM

syncer assigned this task to c-po.Mar 1 2020, 7:34 PM

@Lochnair any chance you can translate this into Linux tc syntax?

@c-po Sure, I can assist with that.

Is there a patch to include configuration for this out there somewhere yet? I'd be interested in testing it out; can possibly help with the patch if it's started too.

Unknown Object (User) added a subscriber: Unknown Object (User).Jun 10 2020, 8:39 PM

Viacheslav set Is it a breaking change? to Unspecified (possibly destroys the router).Feb 5 2021, 9:31 AM

Viacheslav changed Difficulty level from Unknown (require assessment) to Hard (possibly days).

jack9603301 added a subscriber: jack9603301.Feb 5 2021, 9:35 AM

c-po removed c-po as the assignee of this task.May 29 2021, 9:01 PM

CuBiC3D added a subscriber: CuBiC3D.Jun 5 2021, 12:20 AM

dmbaturin set Issue type to Feature (new functionality).Sep 3 2021, 12:07 PM

syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Nov 6 2021, 11:25 AM

I'd like to see cake in vyos as well. I don't think this has been implemented yet (at least not under the traffic-policy section in 1.4-rolling) ?

I can take a look at this in the next few days, is it still feasible to write this in pearl? Or is there a planned rewrite of the vyatta-cfg-qos repo to python?

Hi @hensur , I'm sure that this code should be moved to python implementation, patches for the legacy vyatta-cfg-qos will be rejected.
First of all, need to create CLI XML definition
https://docs.vyos.io/en/equuleus/contributing/development.html?xml-used-for-cli-definitions#xml-used-for-cli-definitions
and then create backend in python to process CLI commands
https://docs.vyos.io/en/equuleus/contributing/development.html?xml-used-for-cli-definitions#configuration-script-structure-and-behaviour

c-po added a parent task: T4284: QoS: rewrite to XML and Python.Mar 6 2022, 6:08 AM

syncer edited projects, added VyOS 1.3 Equuleus (1.3.3); removed VyOS 1.3 Equuleus (1.3.0).Aug 29 2022, 7:06 AM

c-po claimed this task.Oct 18 2022, 9:38 AM

syncer changed the task status from Open to In progress.Oct 18 2022, 2:52 PM

c-po closed this task as Resolved.Jan 2 2023, 6:53 PM

c-po edited projects, added VyOS 1.4 Sagitta; removed VyOS 1.3 Equuleus (1.3.3).

Cake and FQ-PIEClosed, ResolvedPublicFEATURE REQUESTActions

Description

Details

Related ObjectsSearch...

Event Timeline

Cake and FQ-PIE
Closed, ResolvedPublicFEATURE REQUEST
Actions

Related Objects
Search...