Page MenuHomeVyOS Platform
Create Task
Maniphest T814

Issue with VRRP preempt-delay.
Closed, ResolvedPublicBUG
Actions

Description

The constraint on VRRP preempt-delay is --positive.
--positive demands that the number be >0.
The keepalived daemon is capable of accepting a preempt-delay time of 0 (no delay).
The constraint should be changed to --non-negative or --range 0-1000 (1000 seems to be the max according to config documentation).
The default should also be changed from 300 to 0 to be in line with keepalived defaults.

https://linux.die.net/man/5/keepalived.conf
https://manpages.debian.org/testing/keepalived/keepalived.conf.5.en.html

Details

Difficulty level
Easy (less than an hour)
Version
VyOS 1.2.0-rolling+201808302212
Why the issue appeared?
Implementation mistake

Event Timeline

Watcher7 created this task.Aug 30 2018, 9:57 PM
Watcher7 claimed this task.Aug 30 2018, 10:05 PM
Watcher7 triaged this task as Low priority.
Watcher7 updated the task description. (Show Details)
Watcher7 added a comment.Aug 30 2018, 10:09 PM

Pull request: https://github.com/vyos/vyos-1x/pull/47

dmbaturin closed this task as Resolved.Sep 25 2018, 5:39 PM
dmbaturin added a subscriber: dmbaturin.

I've tested the default configuration in 1.1.8, and it looks like with preempt-delay not set it was also 0. Not sure where 300 came from.

dmbaturin edited projects, added VyOS 1.2 Crux (VyOS 1.2.0-rc1); removed VyOS 1.2 Crux.Sep 25 2018, 5:40 PM
dmbaturin changed Why the issue appeared? from Will be filled on close to Implementation mistake.
syncer added a project: VyOS-1.2.0-GA.Oct 15 2018, 10:42 PM
syncer moved this task from Needs Triage to Finished on the VyOS 1.2 Crux (VyOS 1.2.0-rc1) board.Oct 15 2018, 10:42 PM