Page MenuHomePhabricator

op mode command show bridge brX is broken
Closed, ResolvedPublicBUG

Description

op mode command to show bridge details is broken in rc3
see screenshot

Details

Difficulty level
Easy (less than an hour)
Version
1.2-rc3
Why the issue appeared?
Implementation mistake
syncer created this task.Oct 17 2018, 2:43 PM
syncer assigned this task to dmbaturin.
syncer triaged this task as Normal priority.

It works for me, so we need exact reproducing steps.

dmbaturin@vyos# set interfaces bridge br0
[edit]
dmbaturin@vyos# set interfaces ethernet eth4 bridge-group bridge br0
[edit]
dmbaturin@vyos# commit
[ interfaces ethernet eth4 bridge-group ]
Adding interface eth4 to bridge br0

dmbaturin@vyos# run show bridge 
bridge name     bridge id               STP enabled     interfaces
br0             8000.0050569b18ed       no              eth4

Oh, sorry, I misunderstood the issue. It's the "run show bridge brN" command that is not working, while the "run show bridge" command does.

https://github.com/vyos/vyos-1x/commit/db53284fb416d8d625b7a66c0b92df35b92a1f0e

My attempt to use github's editing GUI didn't go well, sorry for the poor commit description.

@runar Please note that variables inside single quotes do not expand in the command templates, just like in shell, so it was literal '$3' string that was passed to brctl instead of the value of the third command word.

runar added a comment.Oct 17 2018, 3:53 PM

Ahh, my mistake! Will remember that :)

dmbaturin closed this task as Resolved.Sun, Oct 21, 3:58 PM
dmbaturin changed Why the issue appeared? from Will be filled on close to Implementation mistake.