Right now the installer only suggests disks that match the [hsv]d.* expression. This prevents users from installing VyOS on other drive types, such as nvme and mmc.
We should decide how to extend the regex.
Description
Description
Details
Details
- Difficulty level
- Unknown (require assessment)
- Version
- -
- Why the issue appeared?
- Will be filled on close
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | syncer | T967 Installer selection of available disks is too restrictive | |||
| Resolved | c-po | T1296 Image install can't install to SD cards (mmcblk...) |
Event Timeline
Comment Actions
Would something like this be suitable? I've tried searching for a canonical source of device naming conventions for Linux. I'm not sure that we'll have a single clean way to identify this in regex.
c[0-9]d[0-9]$|[hsv]d[a-z]$|nvme[0-9]n[0-9]$|mmcblk[0-9]$
Comment Actions
In T955 I changed this code to lsblk -dn -o name -I8 instead of the monstrosity it is now. I've been using that forever to detect disk in install and bootstrap scripts for Debian, and haven't ran into any problems yet. Though there might be someone out there that has more experience with it than me.
Comment Actions
I've opened a pull request to address this ticket in https://github.com/vyos/vyatta-cfg-system/pull/82.