Page MenuHomePhabricator

Unclutter PPTP RADIUS configuration nodes
Closed, ResolvedPublicFEATURE REQUEST

Description

With T987 beeing already complete for L2TP we should use the same for PPTP.

Proposal, change CLI from:

vyos@vyos# show vpn pptp
 remote-access {
     authentication {
         mode radius
         radius-server 172.16.100.10 {
             key barbarbar
         }
         radius-server 172.16.100.20 {
             key foofoofoo
         }
     }

I'd rather prefer:

vyos@vyos# show vpn l2tp
 remote-access {
     authentication {
         mode radius
         radius {
             server 172.16.100.10 {
                 key barbarbar
             }
             server 172.16.100.20 {
                 key foofoofoo
             }
         }
     }

In other words, remove top level tag nodes from radius-server and introduce a regular RADIUS node, thus we can add additional features, too.

Details

Difficulty level
Normal (likely a few hours)
Version
-
Why the issue appeared?
Will be filled on close

Event Timeline

c-po created this task.Nov 11 2018, 4:43 PM
c-po claimed this task.
c-po changed the task status from Open to In progress.
c-po triaged this task as Normal priority.
c-po edited projects, added VyOS 1.2 Crux (VyOS 1.2.0-rc8); removed VyOS 1.2 Crux.
c-po changed Difficulty level from Unknown (require assessment) to Normal (likely a few hours).
c-po closed this task as Resolved.Nov 12 2018, 7:32 PM