It appears the patch doesn't fully account for all possible characters:

https://github.com/vyos/vyos-1x/pull/394

ack - I will change this to make sure it is safe !

It seems to be reading the output of something that thinks it's talking to a VT100 terminal.

Example of output containing control characters.

Have finished

I have create an issue on pexpect's github homepage,and they told me to use "echo $?" to get the exit code,but I can't type "?" on VyOS.How to deal with it?

Finish the problem

Hi!I HAVE FIXED MOST OF PROBLEMS AND ADD BGP SUPPORT,BY THE WAY I HAVE CHANGED THE API STYLE AND REWRITED THE README FILE.

@syncer
OK，I will test it and add a BGP support

Hello @Hochikong ,
can you just run basic tests and report back how it goes,
we then can go to next step maybe.

waiting for tested

Anybody can test the improved library？

Now you can test it again.I have fix the problem

I have find out a solution.Use pexpect.pxssh to execute the commands and return the result.
pexpect can provide python3 support and maybe deal with the timeout problem(You can try it when I have finish fixing)

When I try to use paramiko connect to vyos but it doesn't work when I send some command,it only works on the other commands

@syncer Sorry,recently I was busy with some research on Machine Learning.

This should be moved to paramiko

Should this be rewritten with paramiko?

@afics so maybe py3 support should be on hold...but this task just about py2 style exception syntax therefore this task is finished,right?

Your core dependecy exscript is not compatible with python3. It seems like someone started working on it but didn't finish and abandoned the port. I guess you don't want to port it, so I guess python3 support is on hold for now :/

I think this task can be closed

Do you find out the problem in your test?

waiting for

This task have solved

When I was testing vyroute,I never met such a timeout.Only I enter a error data the timeout exception will raises

Well, I'll reiterate. Interactice SSH works fine to the device in question. The library is giving timeouts. Interactice SSH is not giving me timeouts. From this I deduce that the problem must be in the library, or in exscript.

closing this as solved

Well,I have find a soluntion.

Have fixed

I have push the code and finish T83

I think high-level tools should read the return before they feed back to user,if func return a time out error,high-level tools can ignore it.Now I only find one solution is add a statement to check the return,if func return a timeout error,it will modify the self.__status.

Well, you realize that "execute one more time" is absolutely not an option for a library that is supposed to allow making configuration changes unattended from SDN controllers etc. among other things, right? ;)

Oops. Fixed, try now.

I donno whether you have found the below content in vyroute's readme file(you can visit that file):

I cannot push my code.Because observers group no python-vyos-mgmt repo{F1661}