@c-po Line 115 and 116 of src/conf_mode/dhcpv6_server.py (that generate /etc/default/isc-dhcpdv6-server) still reference the dhcpd6 name and would need to be changed also.
Are you sure we should change all these filenames and the leases filename without migrating it? I guess if you wanted the naming with "dhcpv6" consistent, but IMO it's unnecessary.
The alternative would be to just fix src/op_mode/show_dhcpv6.py and keep the old lease file naming, thus not breaking the cache on upgrade for all users.
I'll create a PR with the version you decide...
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jun 16 2019
Closed PR and reopened in https://github.com/vyos/vyos-1x/pull/72 due to creating a new branch
@c-po The commits only fix the generated config filename, not the one used by dhcpd (set in /etc/default/isc-dhcpdv6-server) so it would probably break the dhcpv6-server. Even if both were updated, that would cause the server to forget all the cached leases on upgrade that are stored in the old leases file as there is no migration script to copy the old filename to new.
Change priority to high as the bug makes DHCPv6 static mappings inoperable.
vyos 1.2.0-rolling+201906161308 has pdns_recursor 4.1.14, should this be marked as fixed?
ISC-dhcp can parse this option either as a quoted string or colon-separated hex list. common/tables.c
Jun 12 2019
After some more investigation, dhcpd6.leases in /config/ and /opt/vyatta/etc/config/ are the same.
In the same config folder there's also dhcpdv6.leases (with the letter "v" before 6) that's a leftover from an older image.
-rw-r--r-- 1 root root 3262 Jun 12 14:55 dhcpd6.leases -rw-r--r-- 1 root root 2615 Jun 12 14:23 dhcpd6.leases~ -rw-r--r-- 1 root root 27726 Jun 12 14:30 dhcpd.leases -rw-r--r-- 1 root root 28072 Jun 12 14:22 dhcpd.leases~ -rwxrwxr-x 1 root vyattacfg 8141 Oct 27 2018 dhcpdv6.leases -rwxrwxr-x 1 root vyattacfg 17618 Oct 27 2018 dhcpdv6.leases~
If I delete these two, I get a nice traceback when running show dhcpv6 server leases:
vyos@vyos:~$ show dhcpv6 server leases Traceback (most recent call last): File "/usr/libexec/vyos/op_mode/show_dhcpv6.py", line 81, in <module> leases = get_leases(lease_file, state='active') File "/usr/libexec/vyos/op_mode/show_dhcpv6.py", line 44, in get_leases leases = IscDhcpLeases(lease_file).get() File "/usr/lib/python3/dist-packages/isc_dhcp_leases/iscdhcpleases.py", line 110, in get with open(self.filename) as lease_file: FileNotFoundError: [Errno 2] No such file or directory: '/config/dhcpdv6.leases'
So it seems that at some point the dhcpd leases filename was changed without updating the name everywhere else (and leaving the old files dangling).
May 31 2019
May 4 2019
I've had this bug occur on 1.2.0-rc11, at one site (with moderately high load) at least once a day, and at the second site (with small load) only once after several months.
After upgrading to the latest 1.2.0 rolling release I've had no issues any more, however the bug may still remain.
It may have something to do with DNSSEC setting as the second system that ran flawlessly for months before started doing it immediately after setting dnssec=validate.
Dec 16 2018
Nov 28 2018
Creating /var/log/squid (sudo mkdir /var/log/squid) allows the commit to complete.