Page MenuHomeVyOS Platform
Feed Advanced Search

Jun 16 2019

jjakob added a comment to T1433: "show dhcpv6 server leases" shows leases from wrong file.

@c-po Line 115 and 116 of src/conf_mode/dhcpv6_server.py (that generate /etc/default/isc-dhcpdv6-server) still reference the dhcpd6 name and would need to be changed also.
Are you sure we should change all these filenames and the leases filename without migrating it? I guess if you wanted the naming with "dhcpv6" consistent, but IMO it's unnecessary.
The alternative would be to just fix src/op_mode/show_dhcpv6.py and keep the old lease file naming, thus not breaking the cache on upgrade for all users.
I'll create a PR with the version you decide...

Jun 16 2019, 7:50 PM · VyOS 1.2 Crux (VyOS 1.2.2)
jjakob added a comment to T1439: DHCPv6 static-mappings not working due to excess quotes around dhcp6.client-id.

Closed PR and reopened in https://github.com/vyos/vyos-1x/pull/72 due to creating a new branch

Jun 16 2019, 7:22 PM · VyOS 1.2 Crux (VyOS 1.2.3)
jjakob claimed T1433: "show dhcpv6 server leases" shows leases from wrong file.
Jun 16 2019, 6:56 PM · VyOS 1.2 Crux (VyOS 1.2.2)
jjakob added a comment to T1433: "show dhcpv6 server leases" shows leases from wrong file.

@c-po The commits only fix the generated config filename, not the one used by dhcpd (set in /etc/default/isc-dhcpdv6-server) so it would probably break the dhcpv6-server. Even if both were updated, that would cause the server to forget all the cached leases on upgrade that are stored in the old leases file as there is no migration script to copy the old filename to new.

Jun 16 2019, 6:55 PM · VyOS 1.2 Crux (VyOS 1.2.2)
jjakob renamed T1434: Add support for global-parameters, shared-network-parameters, subnet-parameters and static-mapping-parameters in dhcpv6-server as already implemented in (v4) dhcp-server from Add support for static-mapping-parameters in dhcpv6-server as it's already implemented in (v4) dhcp-server to Add support for global-parameters, shared-network-parameters, subnet-parameters and static-mapping-parameters in dhcpv6-server as already implemented in (v4) dhcp-server.
Jun 16 2019, 5:57 PM · VyOS 1.3 Equuleus (1.3.6)
jjakob changed the status of T1434: Add support for global-parameters, shared-network-parameters, subnet-parameters and static-mapping-parameters in dhcpv6-server as already implemented in (v4) dhcp-server from Open to In progress.
Jun 16 2019, 5:55 PM · VyOS 1.3 Equuleus (1.3.6)
jjakob triaged T1439: DHCPv6 static-mappings not working due to excess quotes around dhcp6.client-id as High priority.

Change priority to high as the bug makes DHCPv6 static mappings inoperable.

Jun 16 2019, 5:34 PM · VyOS 1.2 Crux (VyOS 1.2.3)
jjakob added a comment to T1189: [Security Advisory] PowerDNS Recursor 4.1.9 Released.

vyos 1.2.0-rolling+201906161308 has pdns_recursor 4.1.14, should this be marked as fixed?

Jun 16 2019, 5:33 PM · VyOS 1.2 Crux ( VyOS 1.2.0-EPA)
jjakob changed the status of T1439: DHCPv6 static-mappings not working due to excess quotes around dhcp6.client-id from Open to In progress.

https://github.com/vyos/vyos-1x/pull/71

Jun 16 2019, 5:29 PM · VyOS 1.2 Crux (VyOS 1.2.3)
jjakob added a comment to T1439: DHCPv6 static-mappings not working due to excess quotes around dhcp6.client-id.

ISC-dhcp can parse this option either as a quoted string or colon-separated hex list. common/tables.c

Jun 16 2019, 2:48 PM · VyOS 1.2 Crux (VyOS 1.2.3)
jjakob claimed T1439: DHCPv6 static-mappings not working due to excess quotes around dhcp6.client-id.
Jun 16 2019, 2:24 PM · VyOS 1.2 Crux (VyOS 1.2.3)
jjakob created T1440: Creating two DHCPv6 shared-network-names with the same subnet is allowed, causes dhcpd to fail to start..
Jun 16 2019, 1:49 PM · VyOS 1.3 Equuleus (1.3.0)
jjakob created T1439: DHCPv6 static-mappings not working due to excess quotes around dhcp6.client-id.
Jun 16 2019, 12:56 PM · VyOS 1.2 Crux (VyOS 1.2.3)

Jun 12 2019

jjakob created T1434: Add support for global-parameters, shared-network-parameters, subnet-parameters and static-mapping-parameters in dhcpv6-server as already implemented in (v4) dhcp-server.
Jun 12 2019, 1:59 PM · VyOS 1.3 Equuleus (1.3.6)
jjakob added a comment to T1433: "show dhcpv6 server leases" shows leases from wrong file.

After some more investigation, dhcpd6.leases in /config/ and /opt/vyatta/etc/config/ are the same.
In the same config folder there's also dhcpdv6.leases (with the letter "v" before 6) that's a leftover from an older image.

-rw-r--r-- 1 root root       3262 Jun 12 14:55 dhcpd6.leases
-rw-r--r-- 1 root root       2615 Jun 12 14:23 dhcpd6.leases~
-rw-r--r-- 1 root root      27726 Jun 12 14:30 dhcpd.leases
-rw-r--r-- 1 root root      28072 Jun 12 14:22 dhcpd.leases~
-rwxrwxr-x 1 root vyattacfg  8141 Oct 27  2018 dhcpdv6.leases
-rwxrwxr-x 1 root vyattacfg 17618 Oct 27  2018 dhcpdv6.leases~

If I delete these two, I get a nice traceback when running show dhcpv6 server leases:

vyos@vyos:~$ show dhcpv6 server leases 
Traceback (most recent call last):
  File "/usr/libexec/vyos/op_mode/show_dhcpv6.py", line 81, in <module>
    leases = get_leases(lease_file, state='active')
  File "/usr/libexec/vyos/op_mode/show_dhcpv6.py", line 44, in get_leases
    leases = IscDhcpLeases(lease_file).get()
  File "/usr/lib/python3/dist-packages/isc_dhcp_leases/iscdhcpleases.py", line 110, in get
    with open(self.filename) as lease_file:
FileNotFoundError: [Errno 2] No such file or directory: '/config/dhcpdv6.leases'

So it seems that at some point the dhcpd leases filename was changed without updating the name everywhere else (and leaving the old files dangling).

Jun 12 2019, 1:19 PM · VyOS 1.2 Crux (VyOS 1.2.2)
jjakob updated the task description for T1433: "show dhcpv6 server leases" shows leases from wrong file.
Jun 12 2019, 1:15 PM · VyOS 1.2 Crux (VyOS 1.2.2)
jjakob created T1433: "show dhcpv6 server leases" shows leases from wrong file.
Jun 12 2019, 12:12 PM · VyOS 1.2 Crux (VyOS 1.2.2)

May 31 2019

jjakob created T1421: OpenVPN client push-route stopped working, needs added quotes to fix.
May 31 2019, 2:48 PM · VyOS 1.2 Crux (VyOS 1.2.4)

May 4 2019

jjakob added a comment to T1331: DNS stops working.

I've had this bug occur on 1.2.0-rc11, at one site (with moderately high load) at least once a day, and at the second site (with small load) only once after several months.
After upgrading to the latest 1.2.0 rolling release I've had no issues any more, however the bug may still remain.
It may have something to do with DNSSEC setting as the second system that ran flawlessly for months before started doing it immediately after setting dnssec=validate.

May 4 2019, 7:17 PM · VyOS 1.3 Equuleus (1.3.0)

Dec 16 2018

jjakob created T1107: Grub: no input from serial console (menu doesn't respond to keystrokes).
Dec 16 2018, 10:26 PM · VyOS-1.2.0-GA, VyOS 1.2 Crux (VyOS 1.2.0-EPA3)

Nov 28 2018

jjakob added a comment to T1054: Webproxy commit failed: Can't touch /var/log/squid/blacklist.log: No such file or directory.

Creating /var/log/squid (sudo mkdir /var/log/squid) allows the commit to complete.

Nov 28 2018, 1:15 AM · VyOS-1.2.0-GA, VyOS 1.2 Crux (VyOS 1.2.0-rc9)
jjakob created T1054: Webproxy commit failed: Can't touch /var/log/squid/blacklist.log: No such file or directory.
Nov 28 2018, 1:10 AM · VyOS-1.2.0-GA, VyOS 1.2 Crux (VyOS 1.2.0-rc9)