Page MenuHomeVyOS Platform
Feed Advanced Search

Dec 7 2020

efficiosoft added a comment to T3113: dhcp-server: Multiple domain-search values are escaped incorrectly.

Thanks for the quick fix!

Dec 7 2020, 12:52 PM

Dec 5 2020

efficiosoft updated the task description for T3113: dhcp-server: Multiple domain-search values are escaped incorrectly.
Dec 5 2020, 10:55 AM
efficiosoft triaged T3113: dhcp-server: Multiple domain-search values are escaped incorrectly as Normal priority.
Dec 5 2020, 10:53 AM

Sep 8 2020

efficiosoft added a comment to T2719: Standardized op mode script structure.

Ok, so this now waits for T2854. I've already drafted some partial implementation and would like to base it on the architecture introduced in that task.

Sep 8 2020, 3:23 PM · VyOS 1.3 Equuleus (1.3.5), VyOS 1.4 Sagitta

Sep 4 2020

efficiosoft added a comment to T2854: Classes for implementing client/server pairs more easily and in an uniform way.

And PR for vyos-1x: https://github.com/vyos/vyos-1x/pull/540

Sep 4 2020, 5:10 PM · VyOS 1.3 Equuleus (1.3.6)
efficiosoft added a comment to T2854: Classes for implementing client/server pairs more easily and in an uniform way.

PR for vyos-build: https://github.com/vyos/vyos-build/pull/123

Sep 4 2020, 12:14 PM · VyOS 1.3 Equuleus (1.3.6)

Sep 3 2020

efficiosoft created T2854: Classes for implementing client/server pairs more easily and in an uniform way.
Sep 3 2020, 12:01 AM · VyOS 1.3 Equuleus (1.3.6)

Jul 29 2020

efficiosoft added a comment to T2719: Standardized op mode script structure.

This is because our other daemons are written using zeromq and the fact that pynng is not a part of the upstream debian source.

Jul 29 2020, 9:26 AM · VyOS 1.3 Equuleus (1.3.5), VyOS 1.4 Sagitta
efficiosoft added a comment to T2719: Standardized op mode script structure.

Here is a draft of what I meant when I said reworking the XML schema.

Jul 29 2020, 12:14 AM · VyOS 1.3 Equuleus (1.3.5), VyOS 1.4 Sagitta

Jul 24 2020

efficiosoft added a comment to T2719: Standardized op mode script structure.

@thomas-mangin Thanks. I've joined the channel yesterday. It'll be fine for asking around every now and then.

Jul 24 2020, 10:09 AM · VyOS 1.3 Equuleus (1.3.5), VyOS 1.4 Sagitta

Jul 23 2020

efficiosoft added a comment to T2719: Standardized op mode script structure.

No, not yet. But generally I don't like it too much because I'm blind and their desktop client isn't very accessible, and writing things like code examples on a smartphone, well, is something I try to avoid ;-).

Jul 23 2020, 3:01 PM · VyOS 1.3 Equuleus (1.3.5), VyOS 1.4 Sagitta
efficiosoft added a comment to T2719: Standardized op mode script structure.

Yes, it would be a solution. However the behaviour the daemon should really be "fixed" when loaded. It may be simpler to have a reload feature on SIGHUP. This would allow changing the file on disk when developing, testing it without breaking things, and only when confident that it is right, then asking for the reload.

Jul 23 2020, 2:45 PM · VyOS 1.3 Equuleus (1.3.5), VyOS 1.4 Sagitta
efficiosoft added a comment to T2719: Standardized op mode script structure.

One thing to keep in mind however when sticking with the XML definitions are the nodes that exist twice, once as tag and once as non-tag node, as @dmbaturin mentioned.

Jul 23 2020, 11:13 AM · VyOS 1.3 Equuleus (1.3.5), VyOS 1.4 Sagitta
efficiosoft added a comment to T2719: Standardized op mode script structure.

@efficiosoft asking users to fire a daemon is not really user-friendly :-) Once a daemon is loaded, whatever change is done to any initialisation data on the disk will not affect it. Should a tool exist loading the same data each time, then changes can be tested without affecting the running daemon.

Jul 23 2020, 10:45 AM · VyOS 1.3 Equuleus (1.3.5), VyOS 1.4 Sagitta

Jul 22 2020

efficiosoft added a comment to T2719: Standardized op mode script structure.

Providing a way to run the op. code without the daemon would allow people to design their own XML add it to the router, test it without reloading "the stable" code in the daemon, and only when happy that it is working cause a restart of the daemon.

Jul 22 2020, 11:23 PM · VyOS 1.3 Equuleus (1.3.5), VyOS 1.4 Sagitta
efficiosoft added a comment to T2719: Standardized op mode script structure.

Thanks @thomas-mangin for sharing your thoughts on this.

Jul 22 2020, 11:19 PM · VyOS 1.3 Equuleus (1.3.5), VyOS 1.4 Sagitta
efficiosoft added a comment to T2719: Standardized op mode script structure.

I like this idea of building a vyos-opd daemon in Python.

Jul 22 2020, 5:54 PM · VyOS 1.3 Equuleus (1.3.5), VyOS 1.4 Sagitta

Jul 21 2020

efficiosoft added a comment to T2720: Rework vyos.template Python module to make future extension easier.

Here you go.

Jul 21 2020, 12:59 PM · VyOS 1.3 Equuleus (1.3.6)
efficiosoft added a comment to T2720: Rework vyos.template Python module to make future extension easier.

PR: https://github.com/vyos/vyos-1x/pull/510

Jul 21 2020, 10:13 AM · VyOS 1.3 Equuleus (1.3.6)
efficiosoft triaged T2720: Rework vyos.template Python module to make future extension easier as Low priority.
Jul 21 2020, 9:07 AM · VyOS 1.3 Equuleus (1.3.6)

Jul 20 2020

efficiosoft closed T2717: Wrong DHCP server pool size in statistics as Resolved.
Jul 20 2020, 7:49 PM · VyOS 1.2 Crux (VyOS 1.2.8)
efficiosoft claimed T2717: Wrong DHCP server pool size in statistics.

As this is my first Phabricator experience, is there anything else I have to do?

Jul 20 2020, 4:06 PM · VyOS 1.2 Crux (VyOS 1.2.8)
efficiosoft renamed T2717: Wrong DHCP server pool size in statistics from Fix DHCP pool size in statistics to Wrong DHCP server pool size in statistics.
Jul 20 2020, 1:49 PM · VyOS 1.2 Crux (VyOS 1.2.8)
efficiosoft triaged T2717: Wrong DHCP server pool size in statistics as Normal priority.
Jul 20 2020, 1:44 PM · VyOS 1.2 Crux (VyOS 1.2.8)

Sep 14 2019

efficiosoft added a comment to T762: Include rulseset in firewall.

I'm very interested in this as well. Especially when you do lots of filtering based on ipsets that contain adresses from multiple zones, inclusion can save you a lot of redundancy.

Sep 14 2019, 11:22 AM · VyOS 1.4 Sagitta