Page MenuHomeVyOS Platform

jestabro (John Estabrook)
User

Projects

User Details

User Since
Apr 12 2019, 4:27 PM (75 w, 2 d)

Recent Activity

Tue, Sep 15

jestabro changed the status of T2885: configd: print commit errors to config session terminal, a subtask of T2582: Script daemon to offload processing during commit, from In progress to Needs testing.
Tue, Sep 15, 4:31 PM · VyOS 1.3 Equuleus
jestabro changed the status of T2885: configd: print commit errors to config session terminal from In progress to Needs testing.
Tue, Sep 15, 4:31 PM · VyOS 1.3 Equuleus
jestabro changed the status of T2885: configd: print commit errors to config session terminal, a subtask of T2582: Script daemon to offload processing during commit, from Open to In progress.
Tue, Sep 15, 2:56 PM · VyOS 1.3 Equuleus
jestabro changed the status of T2885: configd: print commit errors to config session terminal from Open to In progress.
Tue, Sep 15, 2:56 PM · VyOS 1.3 Equuleus
jestabro added a subtask for T2582: Script daemon to offload processing during commit: T2885: configd: print commit errors to config session terminal.
Tue, Sep 15, 2:56 PM · VyOS 1.3 Equuleus
jestabro added a parent task for T2885: configd: print commit errors to config session terminal: T2582: Script daemon to offload processing during commit.
Tue, Sep 15, 2:56 PM · VyOS 1.3 Equuleus
jestabro triaged T2885: configd: print commit errors to config session terminal as Normal priority.
Tue, Sep 15, 2:56 PM · VyOS 1.3 Equuleus
jestabro added a comment to T2865: boot problem beginning with VyOS 1.3-rolling-202009011736.

@querubin thanks for the info; that requirement should not persist, as current work should lessen the overhead. I'll link the task back here when defined.

Tue, Sep 15, 1:10 PM · VyOS 1.3 Equuleus

Mon, Sep 14

jestabro added a comment to T2865: boot problem beginning with VyOS 1.3-rolling-202009011736.

@querubin Thank you for the detailed results --- firstly, these issues may be overdetermined due to several updates earlier this month; one notable issue is that we had moved to a 5.x series kernel, which showed several problems re QAT support, and an identified kernel bug. We have reverted to 4.19 as of yesterday until the next LTS kernel is available. I would suggest trying the most recent rolling, and then we will diagnose any persistent issues.

Mon, Sep 14, 4:06 PM · VyOS 1.3 Equuleus

Wed, Sep 9

jestabro moved T2327: Unable to create syslog server entry with different port from Needs Triage to Finished on the VyOS 1.2 Crux (VyOS 1.2.6) board.
Wed, Sep 9, 8:16 PM · VyOS 1.2 Crux (VyOS 1.2.6)
jestabro closed T2327: Unable to create syslog server entry with different port as Resolved.

This is resolved by T2332; the normalized form is:

Wed, Sep 9, 6:34 PM · VyOS 1.2 Crux (VyOS 1.2.6)
jestabro added a comment to T2327: Unable to create syslog server entry with different port.

Taking a look ...

Wed, Sep 9, 6:09 PM · VyOS 1.2 Crux (VyOS 1.2.6)

Tue, Sep 8

jestabro added a comment to T2865: boot problem beginning with VyOS 1.3-rolling-202009011736.

@querubin please try booting with the vyos-configd service masked: add the kernel boot parameter:

Tue, Sep 8, 4:37 PM · VyOS 1.3 Equuleus
jestabro claimed T2865: boot problem beginning with VyOS 1.3-rolling-202009011736.
Tue, Sep 8, 3:14 PM · VyOS 1.3 Equuleus

Wed, Sep 2

jestabro closed T2849: vyos.xml.defaults should return a list on multi nodes, by default, a subtask of T2636: get_config_dict() shall always return a list on <multi/> nodes, as Resolved.
Wed, Sep 2, 2:12 PM · VyOS 1.3 Equuleus
jestabro closed T2849: vyos.xml.defaults should return a list on multi nodes, by default as Resolved.
Wed, Sep 2, 2:12 PM · VyOS 1.3 Equuleus

Tue, Sep 1

jestabro changed the status of T2849: vyos.xml.defaults should return a list on multi nodes, by default, a subtask of T2636: get_config_dict() shall always return a list on <multi/> nodes, from In progress to Needs testing.
Tue, Sep 1, 4:46 PM · VyOS 1.3 Equuleus
jestabro changed the status of T2849: vyos.xml.defaults should return a list on multi nodes, by default from In progress to Needs testing.
Tue, Sep 1, 4:46 PM · VyOS 1.3 Equuleus
jestabro added a subtask for T2636: get_config_dict() shall always return a list on <multi/> nodes: T2849: vyos.xml.defaults should return a list on multi nodes, by default.
Tue, Sep 1, 3:37 PM · VyOS 1.3 Equuleus
jestabro added a parent task for T2849: vyos.xml.defaults should return a list on multi nodes, by default: T2636: get_config_dict() shall always return a list on <multi/> nodes.
Tue, Sep 1, 3:37 PM · VyOS 1.3 Equuleus
jestabro changed the status of T2849: vyos.xml.defaults should return a list on multi nodes, by default from Open to In progress.
Tue, Sep 1, 3:37 PM · VyOS 1.3 Equuleus

Sun, Aug 30

jestabro added a comment to T2636: get_config_dict() shall always return a list on <multi/> nodes.

Resolved in PR536.

Sun, Aug 30, 7:08 PM · VyOS 1.3 Equuleus

Wed, Aug 26

jestabro closed T2830: Migrate "service https" to use get_config_dict() as Resolved.
Wed, Aug 26, 6:12 PM · VyOS 1.3 Equuleus
jestabro changed the status of T2830: Migrate "service https" to use get_config_dict() from Open to In progress.
Wed, Aug 26, 6:09 PM · VyOS 1.3 Equuleus
jestabro created T2830: Migrate "service https" to use get_config_dict().
Wed, Aug 26, 6:09 PM · VyOS 1.3 Equuleus

Aug 20 2020

jestabro closed T2815: Move certbot config directory under /config/auth as Resolved.
Aug 20 2020, 4:49 AM · VyOS 1.3 Equuleus
jestabro changed the status of T2815: Move certbot config directory under /config/auth from Open to In progress.
Aug 20 2020, 3:30 AM · VyOS 1.3 Equuleus
jestabro triaged T2815: Move certbot config directory under /config/auth as Normal priority.
Aug 20 2020, 3:29 AM · VyOS 1.3 Equuleus

Aug 18 2020

jestabro added a subtask for T2582: Script daemon to offload processing during commit: T2808: Add smoketest to ensure script consistency with config daemon.
Aug 18 2020, 3:45 PM · VyOS 1.3 Equuleus
jestabro added a parent task for T2808: Add smoketest to ensure script consistency with config daemon: T2582: Script daemon to offload processing during commit.
Aug 18 2020, 3:45 PM · VyOS 1.3 Equuleus
jestabro changed the status of T2808: Add smoketest to ensure script consistency with config daemon from Open to Needs testing.
Aug 18 2020, 3:45 PM · VyOS 1.3 Equuleus

Aug 17 2020

jestabro added a comment to T2636: get_config_dict() shall always return a list on <multi/> nodes.

@thomas-mangin in further tests, I've seen wide variability in timing tests, independent of caching, with the original quote being the high-end. That will need to be investigated, but I think performance should not be considered a road-block for now.

Aug 17 2020, 4:21 AM · VyOS 1.3 Equuleus

Aug 14 2020

jestabro updated the task description for T2649: Ensure configration mode scripts conform to coding guidelines.
Aug 14 2020, 5:03 PM · VyOS 1.3 Equuleus
jestabro added a comment to T2795: console server fails to commit.

@tux, this has been fixed in the current rolling.

Aug 14 2020, 3:53 PM · VyOS 1.3 Equuleus

Aug 11 2020

jestabro updated the task description for T2649: Ensure configration mode scripts conform to coding guidelines.
Aug 11 2020, 1:18 AM · VyOS 1.3 Equuleus
jestabro updated the task description for T2649: Ensure configration mode scripts conform to coding guidelines.
Aug 11 2020, 1:15 AM · VyOS 1.3 Equuleus
jestabro closed T2784: Remove unused arg from host_name.py functions verify and get_config, a subtask of T2649: Ensure configration mode scripts conform to coding guidelines, as Resolved.
Aug 11 2020, 1:12 AM · VyOS 1.3 Equuleus
jestabro closed T2784: Remove unused arg from host_name.py functions verify and get_config as Resolved.
Aug 11 2020, 1:12 AM · VyOS 1.3 Equuleus
jestabro added a subtask for T2649: Ensure configration mode scripts conform to coding guidelines: T2784: Remove unused arg from host_name.py functions verify and get_config.
Aug 11 2020, 1:04 AM · VyOS 1.3 Equuleus
jestabro added a parent task for T2784: Remove unused arg from host_name.py functions verify and get_config: T2649: Ensure configration mode scripts conform to coding guidelines.
Aug 11 2020, 1:04 AM · VyOS 1.3 Equuleus
jestabro changed the status of T2784: Remove unused arg from host_name.py functions verify and get_config from Open to In progress.
Aug 11 2020, 1:04 AM · VyOS 1.3 Equuleus

Aug 8 2020

jestabro added a comment to T2100: BGP route adverisement wih checks rib.

FRR 7.4 has been released, and the default behaviour has been changed, commit 62282e8379. @Viacheslav, when we update to this version, I can work with you to update the migration script.

Aug 8 2020, 5:11 PM · VyOS 1.3 Equuleus
jestabro changed the status of T2612: HTTPS API, changing API key fails but goes through from Confirmed to On hold.

As discussed in above comment, this is understandable behaviour, but will be re-investigated after the move to fastapi, re T2397.

Aug 8 2020, 3:57 PM · VyOS 1.3 Equuleus
jestabro closed T1949: Multihop IPv6 BFD is unconfigurable as Resolved.
Aug 8 2020, 3:48 PM · VyOS 1.2 Crux (VyOS 1.2.6), VyOS 1.3 Equuleus
jestabro closed T1974: Allow route-map to set administrative distance as Resolved.
Aug 8 2020, 3:46 PM · VyOS 1.2 Crux (VyOS 1.2.6), VyOS 1.3 Equuleus, vyatta-cfg-quagga
jestabro closed T2501: Cannot recover from failed boot config load as Resolved.

Addressed in T2568.

Aug 8 2020, 3:40 PM · VyOS 1.3 Equuleus
jestabro closed T2497: Cache config string during commit as Resolved.

This was an early experiment which contributed some ideas towards T2582; closed as superseded by that task.

Aug 8 2020, 3:37 PM · VyOS 1.3 Equuleus

Aug 6 2020

jestabro added a comment to T2688: add xml definition to router.

Discussion updated in PR 513.
https://github.com/vyos/vyos-1x/pull/513

Aug 6 2020, 3:25 PM · VyOS 1.3 Equuleus

Jul 29 2020

jestabro changed the status of T2582: Script daemon to offload processing during commit from In progress to Needs testing.

What is here:

Jul 29 2020, 4:27 PM · VyOS 1.3 Equuleus

Jul 26 2020

jestabro added a project to T1185: Firewall rulesets are ignored in RFC-compliant VRRP setups: VyOS 1.2 Crux (VyOS 1.2.7).
Jul 26 2020, 9:21 PM · VyOS 1.2 Crux (VyOS 1.2.7), VyOS 1.3 Equuleus
jestabro removed a project from T1185: Firewall rulesets are ignored in RFC-compliant VRRP setups: VyOS 1.2 Crux (VyOS 1.2.6).

This fix remains an open discussion with @zsdc and @Dmitry

Jul 26 2020, 9:20 PM · VyOS 1.2 Crux (VyOS 1.2.7), VyOS 1.3 Equuleus
jestabro moved T1985: pppoe: Enable ipv6 modules without configured ipv6 pools from Backport Candidates to Finished on the VyOS 1.3 Equuleus board.
Jul 26 2020, 9:18 PM · VyOS 1.2 Crux (VyOS 1.2.6), VyOS 1.3 Equuleus
jestabro closed T1985: pppoe: Enable ipv6 modules without configured ipv6 pools as Resolved.
Jul 26 2020, 9:18 PM · VyOS 1.2 Crux (VyOS 1.2.6), VyOS 1.3 Equuleus
jestabro moved T1985: pppoe: Enable ipv6 modules without configured ipv6 pools from Needs Triage to Finished on the VyOS 1.2 Crux (VyOS 1.2.6) board.
Jul 26 2020, 9:17 PM · VyOS 1.2 Crux (VyOS 1.2.6), VyOS 1.3 Equuleus
jestabro closed T1853: wireguard - disable peer doesn't work , a subtask of T1851: wireguard - changing the pubkey on an existing peer seems to destroy the running config., as Resolved.
Jul 26 2020, 6:59 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus
jestabro closed T1853: wireguard - disable peer doesn't work as Resolved.
Jul 26 2020, 6:59 PM · VyOS 1.3 Equuleus
jestabro removed projects from T1853: wireguard - disable peer doesn't work : VyOS 1.2 Crux (VyOS 1.2.6), Ready for Crux (1.2.x).

This does not currently affect crux (perhaps it did at some point). The crux script logic precludes this bug; confirmed in testing.

Jul 26 2020, 6:57 PM · VyOS 1.3 Equuleus

Jul 22 2020

jestabro closed T2707: Allow alternative initialization data for Config, a subtask of T2582: Script daemon to offload processing during commit, as Resolved.
Jul 22 2020, 7:29 PM · VyOS 1.3 Equuleus
jestabro closed T2707: Allow alternative initialization data for Config as Resolved.
Jul 22 2020, 7:29 PM · VyOS 1.3 Equuleus

Jul 18 2020

jestabro closed T2689: Add helper functions to query changes between session and effective configs as Resolved.
Jul 18 2020, 3:30 PM · VyOS 1.3 Equuleus
jestabro changed Difficulty level from normal to hard on T2689: Add helper functions to query changes between session and effective configs.
Jul 18 2020, 3:29 PM · VyOS 1.3 Equuleus

Jul 16 2020

jestabro added a comment to T2707: Allow alternative initialization data for Config.

https://github.com/vyos/vyos-1x/pull/499

Jul 16 2020, 2:53 PM · VyOS 1.3 Equuleus

Jul 15 2020

jestabro changed the status of T2707: Allow alternative initialization data for Config, a subtask of T2582: Script daemon to offload processing during commit, from In progress to Needs testing.
Jul 15 2020, 6:22 PM · VyOS 1.3 Equuleus
jestabro changed the status of T2707: Allow alternative initialization data for Config from In progress to Needs testing.

Final tests before PR.

Jul 15 2020, 6:22 PM · VyOS 1.3 Equuleus
jestabro added a subtask for T2582: Script daemon to offload processing during commit: T2707: Allow alternative initialization data for Config.
Jul 15 2020, 5:30 PM · VyOS 1.3 Equuleus
jestabro added a parent task for T2707: Allow alternative initialization data for Config: T2582: Script daemon to offload processing during commit.
Jul 15 2020, 5:30 PM · VyOS 1.3 Equuleus
jestabro changed the status of T2707: Allow alternative initialization data for Config from Open to In progress.
Jul 15 2020, 5:30 PM · VyOS 1.3 Equuleus

Jul 14 2020

jestabro updated subscribers of T2689: Add helper functions to query changes between session and effective configs.

Current version linked below, as an example for further discussion. As these ideas have been circulating for a while, it is important to have examples to debunk/revise/reject. My guess is that one likely wants much less than this, and that @dmbaturin is quite right in his recent comment "we should not rely on diffs unless there's absolutely no other way to do it --- not just about computational expense, but also readability".

Jul 14 2020, 3:36 PM · VyOS 1.3 Equuleus

Jul 12 2020

jestabro closed T1575: `show snmp mib ifmib` crashes with IndexError as Resolved.
Jul 12 2020, 2:52 PM · VyOS 1.2 Crux (VyOS 1.2.6), VyOS 1.3 Equuleus

Jul 8 2020

jestabro added a comment to T2689: Add helper functions to query changes between session and effective configs.

@thomas-mangin I'm convinced: for get_child_nodes and get_node, we'll return a dict of respective dicts:

Jul 8 2020, 6:32 PM · VyOS 1.3 Equuleus

Jul 7 2020

jestabro added a comment to T2689: Add helper functions to query changes between session and effective configs.

Okay, I like that video already ...

Jul 7 2020, 9:56 PM · VyOS 1.3 Equuleus
jestabro added a comment to T2689: Add helper functions to query changes between session and effective configs.

@thomas-mangin Firstly, I needed to write this version before reasonably debating the pros/cons of various approaches --- the important idea developed is that the use of get_sub_dict, and ability to return the sub_dict under the diff'ed nodes will allow a fluid use in writing conf_mode scripts --- beyond that, I am not particularly attached to any details of implementation, yet.

Jul 7 2020, 9:54 PM · VyOS 1.3 Equuleus
jestabro added a comment to T2689: Add helper functions to query changes between session and effective configs.

@thomas-mangin and @runar I do like the enum idea, however, this would add boilerplate to the conf_mode scripts, which would quickly become annoying in practice ... rather, common workflow just wants the actionable data (added, deleted) _and_ the ability to then access values under the node in question. Consequently, I'm following @runar 's suggestion of returning a tuple, combined with the return_as_dict arg to allow access to sub-data.

Jul 7 2020, 5:41 PM · VyOS 1.3 Equuleus
jestabro added a comment to T2689: Add helper functions to query changes between session and effective configs.

One forgotten point: get_config_diff obtains the config_dicts at root level, so any movement within/between sub-sections are available, with set_level.

Jul 7 2020, 4:02 PM · VyOS 1.3 Equuleus
jestabro added a comment to T2689: Add helper functions to query changes between session and effective configs.

It is true that get_config_dict is slow, so it should only be called once (twice for diff) per session. Consequently, the work flow will be:

Jul 7 2020, 3:55 PM · VyOS 1.3 Equuleus

Jul 6 2020

jestabro added a comment to T2689: Add helper functions to query changes between session and effective configs.

So, as far as useful helper functions, one certainly wants:
get_child_nodes_changed(... path)
get_value_changed(... path)

Jul 6 2020, 7:08 PM · VyOS 1.3 Equuleus
jestabro added a comment to T2689: Add helper functions to query changes between session and effective configs.

@runar in fact, that's all one wants in current use case: has the list of elements, directly _under_ the specified node, changed? For example, (1) change of values (2) added or removed tag node entries.

Jul 6 2020, 7:01 PM · VyOS 1.3 Equuleus
jestabro added a comment to T2689: Add helper functions to query changes between session and effective configs.

Yes, I'm expanding all paths under the specified path

Jul 6 2020, 4:07 PM · VyOS 1.3 Equuleus
jestabro updated the task description for T2689: Add helper functions to query changes between session and effective configs.
Jul 6 2020, 3:25 PM · VyOS 1.3 Equuleus
jestabro added a comment to T2689: Add helper functions to query changes between session and effective configs.

Yes, I definitely prefer a return type of tuple ...

Jul 6 2020, 3:24 PM · VyOS 1.3 Equuleus
jestabro added a comment to T2689: Add helper functions to query changes between session and effective configs.

Regarding is_value_changed, I was thinking the other way around: get_value_changed returns None if no change, so is_value_changed would be redundant --- put good point: one may/will want both old and new values

Jul 6 2020, 3:11 PM · VyOS 1.3 Equuleus
jestabro added a comment to T2689: Add helper functions to query changes between session and effective configs.

I am entirely open to suggestions here; the underlying functions support any such forms. Note however, that we want to distinguish between new/deleted paths and changed values --- one could treat these all as a difference in path, but it will be more convenient for use if we make the distinction ...

Jul 6 2020, 3:08 PM · VyOS 1.3 Equuleus
jestabro changed the status of T2689: Add helper functions to query changes between session and effective configs from Open to In progress.
Jul 6 2020, 2:49 PM · VyOS 1.3 Equuleus

Jul 3 2020

jestabro updated the task description for T2667: get_config_dict: Use utility function for non-empty path argument.
Jul 3 2020, 1:13 PM · VyOS 1.3 Equuleus
jestabro closed T2670: Remove dependency on show_config from get_config_dict as Resolved.
Jul 3 2020, 1:12 PM · VyOS 1.3 Equuleus
jestabro closed T2670: Remove dependency on show_config from get_config_dict, a subtask of T2667: get_config_dict: Use utility function for non-empty path argument, as Resolved.
Jul 3 2020, 1:12 PM · VyOS 1.3 Equuleus

Jul 2 2020

jestabro added a subtask for T2667: get_config_dict: Use utility function for non-empty path argument: T2670: Remove dependency on show_config from get_config_dict.
Jul 2 2020, 1:21 PM · VyOS 1.3 Equuleus
jestabro added a parent task for T2670: Remove dependency on show_config from get_config_dict: T2667: get_config_dict: Use utility function for non-empty path argument.
Jul 2 2020, 1:21 PM · VyOS 1.3 Equuleus
jestabro created T2670: Remove dependency on show_config from get_config_dict.
Jul 2 2020, 1:21 PM · VyOS 1.3 Equuleus
jestabro closed T2668: get_config_dict: add get_first_key arg to utility function get_sub_dict, a subtask of T2667: get_config_dict: Use utility function for non-empty path argument, as Resolved.
Jul 2 2020, 1:47 AM · VyOS 1.3 Equuleus
jestabro closed T2668: get_config_dict: add get_first_key arg to utility function get_sub_dict as Resolved.
Jul 2 2020, 1:47 AM · VyOS 1.3 Equuleus

Jul 1 2020

jestabro closed T2662: get_config_dict includes node name as key only for tag and leaf nodes as Resolved.

Addressed by T2667.

Jul 1 2020, 11:46 PM · VyOS 1.3 Equuleus
jestabro closed T2667: get_config_dict: Use utility function for non-empty path argument, a subtask of T2662: get_config_dict includes node name as key only for tag and leaf nodes, as Resolved.
Jul 1 2020, 11:45 PM · VyOS 1.3 Equuleus
jestabro closed T2667: get_config_dict: Use utility function for non-empty path argument as Resolved.
Jul 1 2020, 11:45 PM · VyOS 1.3 Equuleus
jestabro added a subtask for T2667: get_config_dict: Use utility function for non-empty path argument: T2668: get_config_dict: add get_first_key arg to utility function get_sub_dict.
Jul 1 2020, 7:22 PM · VyOS 1.3 Equuleus
jestabro added a parent task for T2668: get_config_dict: add get_first_key arg to utility function get_sub_dict: T2667: get_config_dict: Use utility function for non-empty path argument.
Jul 1 2020, 7:22 PM · VyOS 1.3 Equuleus
jestabro created T2668: get_config_dict: add get_first_key arg to utility function get_sub_dict.
Jul 1 2020, 7:22 PM · VyOS 1.3 Equuleus
jestabro added a subtask for T2662: get_config_dict includes node name as key only for tag and leaf nodes: T2667: get_config_dict: Use utility function for non-empty path argument.
Jul 1 2020, 6:55 PM · VyOS 1.3 Equuleus
jestabro added a parent task for T2667: get_config_dict: Use utility function for non-empty path argument: T2662: get_config_dict includes node name as key only for tag and leaf nodes.
Jul 1 2020, 6:55 PM · VyOS 1.3 Equuleus
jestabro moved T2667: get_config_dict: Use utility function for non-empty path argument from Need Triage to In Progress on the VyOS 1.3 Equuleus board.
Jul 1 2020, 6:39 PM · VyOS 1.3 Equuleus