Page MenuHomePhabricator

jestabro (John Estabrook)
User

Projects

User Details

User Since
Apr 12 2019, 4:27 PM (40 w, 2 d)

Recent Activity

Fri, Jan 17

jestabro moved T1376: Incorrect DHCP lease counting from Backlog to Finished on the VyOS 1.2 Crux (VyOS 1.2.5) board.
Fri, Jan 17, 9:14 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus
jestabro edited projects for T1185: Firewall rulesets are ignored in RFC-compliant VRRP setups, added: VyOS 1.2 Crux (VyOS 1.2.6); removed VyOS 1.2 Crux (VyOS 1.2.5).
Fri, Jan 17, 8:21 PM · VyOS 1.2 Crux (VyOS 1.2.6), VyOS 1.3 Equuleus
jestabro moved T1452: accel-pppoe - add vendor option to shaper from Needs Triage to Finished on the VyOS 1.2 Crux (VyOS 1.2.5) board.
Fri, Jan 17, 8:19 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus
jestabro moved T1341: Adding rate-limiter for pppoe server users from Backlog to Finished on the VyOS 1.2 Crux (VyOS 1.2.5) board.
Fri, Jan 17, 7:54 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus

Thu, Jan 16

jestabro moved T1827: Increase default gc_thresh from Backlog to Finished on the VyOS 1.2 Crux (VyOS 1.2.5) board.
Thu, Jan 16, 5:01 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus
jestabro added a comment to T1827: Increase default gc_thresh.

Yes, thanks, c-po; the revised settings (above) are consistent with defaults and behaviour for both crux and equuleus.

Thu, Jan 16, 3:47 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus

Wed, Jan 15

jestabro added a comment to T1341: Adding rate-limiter for pppoe server users.

I will backport this, unless objections ...

Wed, Jan 15, 9:56 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus
jestabro edited projects for T1622: Add failsafe and back trace to boot config loader, added: VyOS 1.2 Crux (VyOS 1.2.6); removed VyOS 1.2 Crux (VyOS 1.2.5).
Wed, Jan 15, 7:47 PM · VyOS 1.2 Crux (VyOS 1.2.6), VyOS 1.3 Equuleus
jestabro moved T1827: Increase default gc_thresh from Needs Triage to Backlog on the VyOS 1.2 Crux (VyOS 1.2.5) board.
Wed, Jan 15, 7:45 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus
jestabro closed T1827: Increase default gc_thresh as Resolved.
Wed, Jan 15, 7:43 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus
jestabro added a comment to T1827: Increase default gc_thresh.

For consistency with the relative sizes set by CLI in the conf_mode script (system-ip.py), the default params should be:

Wed, Jan 15, 5:20 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus
jestabro added a comment to T1827: Increase default gc_thresh.

The size of an ARP cache entry is 384 bytes, so the change will add ~720k -- ~3 MiB, which seems reasonable. As pointed out, performance issues may be affected by gc_cache1 and gc_cache2, not just the gc_cache3 set by CLI. I will add the suggested settings to sysctl defaults.

Wed, Jan 15, 4:33 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus

Mon, Jan 13

jestabro added a comment to T1962: Add syntax version to schema.

https://github.com/vyos/vyos-1x/compare/current...jestabro:syntax-version?expand=1

Mon, Jan 13, 6:17 PM · VyOS 1.3 Equuleus
jestabro changed the status of T1962: Add syntax version to schema, a subtask of T1950: Store VyOS configuration syntax version data in JSON file, from Open to Needs testing.
Mon, Jan 13, 6:16 PM · VyOS 1.3 Equuleus
jestabro changed the status of T1962: Add syntax version to schema from Open to Needs testing.
Mon, Jan 13, 6:16 PM · VyOS 1.3 Equuleus
jestabro added a comment to T1950: Store VyOS configuration syntax version data in JSON file.

Revising this design, following discussion with dmbaturin; implementation in T1962.

Mon, Jan 13, 5:15 PM · VyOS 1.3 Equuleus
jestabro added a subtask for T1950: Store VyOS configuration syntax version data in JSON file: T1962: Add syntax version to schema.
Mon, Jan 13, 5:01 PM · VyOS 1.3 Equuleus
jestabro added a parent task for T1962: Add syntax version to schema: T1950: Store VyOS configuration syntax version data in JSON file.
Mon, Jan 13, 5:01 PM · VyOS 1.3 Equuleus
jestabro triaged T1962: Add syntax version to schema as Normal priority.
Mon, Jan 13, 5:00 PM · VyOS 1.3 Equuleus
jestabro renamed T1950: Store VyOS configuration syntax version data in JSON file from Store VyOS configuration syntax version data in JSON file, with support for third-party components to Store VyOS configuration syntax version data in JSON file.
Mon, Jan 13, 4:57 PM · VyOS 1.3 Equuleus

Tue, Jan 7

jestabro added a comment to T1950: Store VyOS configuration syntax version data in JSON file.
Tue, Jan 7, 4:06 PM · VyOS 1.3 Equuleus
jestabro changed the status of T1950: Store VyOS configuration syntax version data in JSON file from In progress to Needs testing.

Move to 'Needs testing'; repo linked below. Add example of third-party package, and test, before PR.

Tue, Jan 7, 3:50 PM · VyOS 1.3 Equuleus
jestabro changed the status of T1950: Store VyOS configuration syntax version data in JSON file from Open to In progress.
Tue, Jan 7, 3:38 PM · VyOS 1.3 Equuleus

Thu, Jan 2

njh awarded T1327: Set the serial console speed to 115200 by default a Love token.
Thu, Jan 2, 4:56 PM · VyOS 1.3 Equuleus

Mon, Dec 23

jestabro added a comment to T640: Images no longer work when built without "recommended" packages.

This appears to be a moving target in at least one sense:
The package lists I now see differ from what is listed in the files above; one notable difference is a missing 'systemd-sysv':

Mon, Dec 23, 8:56 PM · VyOS 1.3 Equuleus

Dec 20 2019

jestabro added a comment to T640: Images no longer work when built without "recommended" packages.

My guess would be missing live-tools in the recommends=false case; live-tools replaces update-initramfs with its version. I'm building to check ...

Dec 20 2019, 4:32 PM · VyOS 1.3 Equuleus

Dec 17 2019

jestabro added a comment to T1585: Add letsencrypt/certbot support for 'service https'.

To avoid confusion, this will only be in the equuleus branch:
https://github.com/vyos/vyos-1x/compare/equuleus...jestabro:T1585?expand=1

Dec 17 2019, 9:56 PM · VyOS 1.3 Equuleus
jestabro changed the status of T1585: Add letsencrypt/certbot support for 'service https', a subtask of T1443: New "service https" implementation, from In progress to Needs testing.
Dec 17 2019, 9:51 PM · VyOS 1.2 Crux (VyOS 1.2.3), VyOS 1.3 Equuleus
jestabro changed the status of T1585: Add letsencrypt/certbot support for 'service https' from In progress to Needs testing.

Initial version for equuleus here:
https://github.com/jestabro/vyos-1x/tree/T1585

Dec 17 2019, 9:50 PM · VyOS 1.3 Equuleus

Dec 11 2019

jestabro closed T1846: Make session_config not depend on the current edit level as Resolved.
Dec 11 2019, 4:39 PM
jestabro added a comment to T1846: Make session_config not depend on the current edit level.

This requirement needs to be applied to 'running_config' as well, in case of (1) editing at the level of an unset node (parse error); (2) reading effective_value(s) in configuration mode (lacking full paths).

Dec 11 2019, 4:39 PM
jestabro reopened T1846: Make session_config not depend on the current edit level as "Open".
Dec 11 2019, 3:47 PM
jestabro added a comment to T1861: hosts lost after modified static-host-mapping.

Thanks; this is necessary when (1) editing at the level of an unset node; (2) reading effective_value(s) in configuration mode. I will extend the original fix.

Dec 11 2019, 3:30 PM · VyOS 1.3 Equuleus

Dec 10 2019

jestabro updated subscribers of T1185: Firewall rulesets are ignored in RFC-compliant VRRP setups.

@Merijn if you are still willing to test, I can provide build instructions, if you need. I noticed that you had been working with @hagbard recently on your build environment; if you are willing to use docker, I can give you step-by-step instructions to build with these patches.

Dec 10 2019, 3:51 PM · VyOS 1.2 Crux (VyOS 1.2.6), VyOS 1.3 Equuleus

Dec 9 2019

jestabro closed T1846: Make session_config not depend on the current edit level as Resolved.
Dec 9 2019, 7:55 PM
jestabro added a subtask for T1846: Make session_config not depend on the current edit level: T1851: wireguard - changing the pubkey on an existing peer seems to destroy the running config..
Dec 9 2019, 7:55 PM
jestabro added a parent task for T1851: wireguard - changing the pubkey on an existing peer seems to destroy the running config.: T1846: Make session_config not depend on the current edit level.
Dec 9 2019, 7:55 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus
jestabro added a subtask for T1846: Make session_config not depend on the current edit level: T1861: hosts lost after modified static-host-mapping.
Dec 9 2019, 7:42 PM
jestabro added a parent task for T1861: hosts lost after modified static-host-mapping: T1846: Make session_config not depend on the current edit level.
Dec 9 2019, 7:42 PM · VyOS 1.3 Equuleus
jestabro added a subtask for T1846: Make session_config not depend on the current edit level: T1863: daemon config lost after commit changes.
Dec 9 2019, 7:40 PM
jestabro added a parent task for T1863: daemon config lost after commit changes: T1846: Make session_config not depend on the current edit level.
Dec 9 2019, 7:40 PM
jestabro added a subtask for T1846: Make session_config not depend on the current edit level: T1844: Fix interface configuration which was broken in T1762 .
Dec 9 2019, 7:38 PM
jestabro added a parent task for T1844: Fix interface configuration which was broken in T1762 : T1846: Make session_config not depend on the current edit level.
Dec 9 2019, 7:38 PM
jestabro added a comment to T1844: Fix interface configuration which was broken in T1762 .

A version of @hagbard 's fix has been committed as eced4a49c67d2e0e3e131193afe679aee0c5c679; the incorrect behaviour with the edit level has been fixed and referenced in that task (T1846).

Dec 9 2019, 6:26 PM
jestabro changed the status of T1846: Make session_config not depend on the current edit level from Open to In progress.

A parsimonious fix to this issue has been committed; I will move the status to "In progress" until the related issues mentioned here are sorted through.

Dec 9 2019, 6:19 PM
jestabro claimed T1846: Make session_config not depend on the current edit level.
Dec 9 2019, 5:30 PM

Dec 6 2019

jestabro moved T1862: Use regex pattern \s+ to split strings on whitespace in Python 3.7 from Need Triage to In Progress on the VyOS 1.3 Equuleus board.
Dec 6 2019, 9:54 PM · VyOS 1.3 Equuleus
jestabro reopened T1862: Use regex pattern \s+ to split strings on whitespace in Python 3.7 as "In progress".
Dec 6 2019, 9:16 PM · VyOS 1.3 Equuleus
jestabro closed T1862: Use regex pattern \s+ to split strings on whitespace in Python 3.7 as Resolved.
Dec 6 2019, 9:15 PM · VyOS 1.3 Equuleus
jestabro updated the task description for T1862: Use regex pattern \s+ to split strings on whitespace in Python 3.7.
Dec 6 2019, 9:09 PM · VyOS 1.3 Equuleus
jestabro triaged T1862: Use regex pattern \s+ to split strings on whitespace in Python 3.7 as Normal priority.
Dec 6 2019, 8:59 PM · VyOS 1.3 Equuleus

Dec 5 2019

jestabro closed T1847: set_level incorrectly handles path given as empty string, a subtask of T1758: Switch vyos.config to libvyosconfig, as Resolved.
Dec 5 2019, 12:40 PM · VyOS 1.3 Equuleus
jestabro closed T1847: set_level incorrectly handles path given as empty string as Resolved.
Dec 5 2019, 12:40 PM · VyOS 1.3 Equuleus

Dec 4 2019

jestabro added a comment to T1185: Firewall rulesets are ignored in RFC-compliant VRRP setups.

The fix suggested in the pull request did not resolve the issue as a consequence of T1847. With that issue resolved, we can consider this merge.

Dec 4 2019, 10:16 PM · VyOS 1.2 Crux (VyOS 1.2.6), VyOS 1.3 Equuleus
jestabro added a comment to T1847: set_level incorrectly handles path given as empty string.

https://github.com/vyos/vyos-1x/pull/175

Dec 4 2019, 10:13 PM · VyOS 1.3 Equuleus
jestabro added a subtask for T1758: Switch vyos.config to libvyosconfig: T1847: set_level incorrectly handles path given as empty string.
Dec 4 2019, 10:12 PM · VyOS 1.3 Equuleus
jestabro added a parent task for T1847: set_level incorrectly handles path given as empty string: T1758: Switch vyos.config to libvyosconfig.
Dec 4 2019, 10:12 PM · VyOS 1.3 Equuleus
jestabro changed the status of T1847: set_level incorrectly handles path given as empty string from Open to In progress.
Dec 4 2019, 10:06 PM · VyOS 1.3 Equuleus
jestabro closed T1787: Failed config migration from V1.2.3 to 1.2-rolling-201911030217, a subtask of T1801: Unescaped backslashes in config values cause configuration failure, as Resolved.
Dec 4 2019, 4:27 PM · VyOS 1.3 Equuleus
jestabro closed T1787: Failed config migration from V1.2.3 to 1.2-rolling-201911030217 as Resolved.

This is reported as resolved by Line2 in parent T1801; the related issue mentioned therein is also resolved by the revised fix in T1801.

Dec 4 2019, 4:27 PM · VyOS 1.3 Equuleus

Dec 3 2019

jestabro added a comment to T1185: Firewall rulesets are ignored in RFC-compliant VRRP setups.

@Merijn I am consulting with the author of the pull request; I still need to confirm behavior before we can consider merging.

Dec 3 2019, 8:15 PM · VyOS 1.2 Crux (VyOS 1.2.6), VyOS 1.3 Equuleus
jestabro added a comment to T1744: Config load fails in ConfigTree with ValueError: Failed to parse config: lexing: empty token.

The resolution in T1801 will prevent the error in this case.

Dec 3 2019, 7:14 PM · VyOS 1.3 Equuleus
jestabro closed T1801: Unescaped backslashes in config values cause configuration failure as Resolved.
Dec 3 2019, 7:10 PM · VyOS 1.3 Equuleus
jestabro added a comment to T1801: Unescaped backslashes in config values cause configuration failure.

The general solution has been merged into vyos-1x.

Dec 3 2019, 5:33 PM · VyOS 1.3 Equuleus

Nov 27 2019

jestabro added a comment to T1185: Firewall rulesets are ignored in RFC-compliant VRRP setups.

@Merijn I will build and run a sanity check, and then we can merge into rolling for testing; I'll confirm when done. Thanks again for the offer to test.

Nov 27 2019, 3:30 PM · VyOS 1.2 Crux (VyOS 1.2.6), VyOS 1.3 Equuleus

Nov 26 2019

jestabro reopened T1801: Unescaped backslashes in config values cause configuration failure as "In progress".
Nov 26 2019, 4:13 PM · VyOS 1.3 Equuleus
jestabro added a comment to T1801: Unescaped backslashes in config values cause configuration failure.

The merged fix addressed the problem as it occurs in configuration mode, however, the same issue can occur during the running of migration scripts. A solution to cover all cases has been tested, and is pending.

Nov 26 2019, 4:13 PM · VyOS 1.3 Equuleus

Nov 25 2019

jestabro closed T1824: Permission denied: '/opt/vyatta/etc/config/vyos-migrate.log', a subtask of T1814: Add log of migration scripts run during config migration, as Resolved.
Nov 25 2019, 4:18 PM · VyOS 1.3 Equuleus
jestabro closed T1824: Permission denied: '/opt/vyatta/etc/config/vyos-migrate.log' as Resolved.
Nov 25 2019, 4:18 PM · VyOS 1.3 Equuleus
jestabro added a subtask for T1334: Migration script runner rewrite: T1814: Add log of migration scripts run during config migration.
Nov 25 2019, 4:12 PM · VyOS 1.3 Equuleus
jestabro removed a subtask for T1397: Rewrite the config merge script: T1814: Add log of migration scripts run during config migration.
Nov 25 2019, 4:12 PM · VyOS 1.3 Equuleus
jestabro edited parent tasks for T1814: Add log of migration scripts run during config migration, added: T1334: Migration script runner rewrite; removed: T1397: Rewrite the config merge script.
Nov 25 2019, 4:12 PM · VyOS 1.3 Equuleus
jestabro added a subtask for T1814: Add log of migration scripts run during config migration: T1824: Permission denied: '/opt/vyatta/etc/config/vyos-migrate.log'.
Nov 25 2019, 4:09 PM · VyOS 1.3 Equuleus
jestabro added a parent task for T1824: Permission denied: '/opt/vyatta/etc/config/vyos-migrate.log': T1814: Add log of migration scripts run during config migration.
Nov 25 2019, 4:09 PM · VyOS 1.3 Equuleus

Nov 22 2019

jestabro closed T1597: /usr/sbin/rsyslogd after deleting "system syslog" as Resolved.
Nov 22 2019, 2:07 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro closed T1391: In route-map set community additive as Resolved.
Nov 22 2019, 2:06 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro closed T1593: Support ip6gre as Resolved.
Nov 22 2019, 2:06 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro closed T1701: Delete domain-name and domain-search won't work as Resolved.
Nov 22 2019, 2:06 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro closed T1678: hostfile-update missing line feed as Resolved.
Nov 22 2019, 2:05 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro closed T1694: NTPd: Do not listen on all interfaces by default as Resolved.
Nov 22 2019, 2:05 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro closed T1772: <regex> constraints in XML are partially broken as Resolved.
Nov 22 2019, 2:05 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro closed T1749: numeric validator doesn't support multiple ranges as Resolved.
Nov 22 2019, 2:04 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro closed T1786: disable-dhcp-nameservers is missed in current host_name.py implementation as Resolved.
Nov 22 2019, 2:03 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus

Nov 21 2019

jestabro closed T1814: Add log of migration scripts run during config migration as Resolved.
Nov 21 2019, 8:36 PM · VyOS 1.3 Equuleus
jestabro closed T1814: Add log of migration scripts run during config migration, a subtask of T1397: Rewrite the config merge script, as Resolved.
Nov 21 2019, 8:36 PM · VyOS 1.3 Equuleus
jestabro closed T1818: Print name of migration script on failure as Resolved.
Nov 21 2019, 8:35 PM · VyOS 1.3 Equuleus
jestabro changed Version from - to 1.2-rolling, 1.3 on T1818: Print name of migration script on failure.
Nov 21 2019, 8:34 PM · VyOS 1.3 Equuleus
jestabro claimed T1814: Add log of migration scripts run during config migration.
Nov 21 2019, 8:34 PM · VyOS 1.3 Equuleus
jestabro changed the status of T1818: Print name of migration script on failure from Open to In progress.
Nov 21 2019, 8:23 PM · VyOS 1.3 Equuleus

Nov 20 2019

jestabro edited projects for T1185: Firewall rulesets are ignored in RFC-compliant VRRP setups, added: VyOS 1.2 Crux (VyOS 1.2.5); removed VyOS 1.2 Crux (VyOS 1.2.4).

This still needs some review and testing. @Merijn, thank you for the offer; testing will be much appreciated, once PRs are merged.

Nov 20 2019, 7:04 PM · VyOS 1.2 Crux (VyOS 1.2.6), VyOS 1.3 Equuleus

Nov 19 2019

jestabro moved T1786: disable-dhcp-nameservers is missed in current host_name.py implementation from Backlog to Finished on the VyOS 1.2 Crux (VyOS 1.2.4) board.
Nov 19 2019, 7:42 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro moved T1749: numeric validator doesn't support multiple ranges from Backlog to Finished on the VyOS 1.2 Crux (VyOS 1.2.4) board.
Nov 19 2019, 7:28 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro moved T1812: DHCP: hostnames of clients not resolving after update v1.2.3 -> 1.2-rolling from Needs Triage to Finished on the VyOS 1.2 Crux (VyOS 1.2.4) board.
Nov 19 2019, 7:24 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro moved T1772: <regex> constraints in XML are partially broken from Backlog to Finished on the VyOS 1.2 Crux (VyOS 1.2.4) board.
Nov 19 2019, 7:13 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro moved T1694: NTPd: Do not listen on all interfaces by default from Backlog to Finished on the VyOS 1.2 Crux (VyOS 1.2.4) board.
Nov 19 2019, 7:00 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro edited projects for T1747: L2TP breaks after upgrading to VyOS 1.2-rolling-201910180117 [issue report and proposed solution], added: VyOS 1.2 Crux (VyOS 1.2.5); removed VyOS 1.2 Crux (VyOS 1.2.4).
Nov 19 2019, 6:33 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus
jestabro edited projects for T1755: Python KeyError exceptions raised with 'show vpn ipsec sa' command under use of certain IPSEC cipher suites., added: VyOS 1.2 Crux (VyOS 1.2.5); removed VyOS 1.2 Crux (VyOS 1.2.4).
Nov 19 2019, 6:10 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus
jestabro moved T1678: hostfile-update missing line feed from Backlog to Finished on the VyOS 1.2 Crux (VyOS 1.2.4) board.
Nov 19 2019, 4:23 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro moved T1701: Delete domain-name and domain-search won't work from Backlog to Finished on the VyOS 1.2 Crux (VyOS 1.2.4) board.
Nov 19 2019, 4:19 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro added a comment to T1755: Python KeyError exceptions raised with 'show vpn ipsec sa' command under use of certain IPSEC cipher suites..

This is dependent on T1260, which will need to be backported.

Nov 19 2019, 4:08 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus