Page MenuHomePhabricator

jestabro (John Estabrook)
User

Projects

User Details

User Since
Apr 12 2019, 4:27 PM (34 w, 3 d)

Recent Activity

Yesterday

jestabro closed T1846: Make session_config not depend on the current edit level as Resolved.
Mon, Dec 9, 7:55 PM
jestabro added a subtask for T1846: Make session_config not depend on the current edit level: T1851: wireguard - changing the pubkey on an existing peer seems to destroy the running config..
Mon, Dec 9, 7:55 PM
jestabro added a parent task for T1851: wireguard - changing the pubkey on an existing peer seems to destroy the running config.: T1846: Make session_config not depend on the current edit level.
Mon, Dec 9, 7:55 PM · VyOS 1.2 Crux
jestabro added a subtask for T1846: Make session_config not depend on the current edit level: T1861: hosts lost after modified static-host-mapping.
Mon, Dec 9, 7:42 PM
jestabro added a parent task for T1861: hosts lost after modified static-host-mapping: T1846: Make session_config not depend on the current edit level.
Mon, Dec 9, 7:42 PM · VyOS 1.3 Equuleus
jestabro added a subtask for T1846: Make session_config not depend on the current edit level: T1863: daemon config lost after commit changes.
Mon, Dec 9, 7:40 PM
jestabro added a parent task for T1863: daemon config lost after commit changes: T1846: Make session_config not depend on the current edit level.
Mon, Dec 9, 7:40 PM
jestabro added a subtask for T1846: Make session_config not depend on the current edit level: T1844: Fix interface configuration which was broken in T1762 .
Mon, Dec 9, 7:38 PM
jestabro added a parent task for T1844: Fix interface configuration which was broken in T1762 : T1846: Make session_config not depend on the current edit level.
Mon, Dec 9, 7:38 PM
jestabro added a comment to T1844: Fix interface configuration which was broken in T1762 .

A version of @hagbard 's fix has been committed as eced4a49c67d2e0e3e131193afe679aee0c5c679; the incorrect behaviour with the edit level has been fixed and referenced in that task (T1846).

Mon, Dec 9, 6:26 PM
jestabro changed the status of T1846: Make session_config not depend on the current edit level from Open to In progress.

A parsimonious fix to this issue has been committed; I will move the status to "In progress" until the related issues mentioned here are sorted through.

Mon, Dec 9, 6:19 PM
jestabro claimed T1846: Make session_config not depend on the current edit level.
Mon, Dec 9, 5:30 PM

Fri, Dec 6

jestabro moved T1862: Use regex pattern \s+ to split strings on whitespace in Python 3.7 from Need Triage to In Progress on the VyOS 1.3 Equuleus board.
Fri, Dec 6, 9:54 PM · VyOS 1.3 Equuleus
jestabro reopened T1862: Use regex pattern \s+ to split strings on whitespace in Python 3.7 as "In progress".
Fri, Dec 6, 9:16 PM · VyOS 1.3 Equuleus
jestabro closed T1862: Use regex pattern \s+ to split strings on whitespace in Python 3.7 as Resolved.
Fri, Dec 6, 9:15 PM · VyOS 1.3 Equuleus
jestabro updated the task description for T1862: Use regex pattern \s+ to split strings on whitespace in Python 3.7.
Fri, Dec 6, 9:09 PM · VyOS 1.3 Equuleus
jestabro triaged T1862: Use regex pattern \s+ to split strings on whitespace in Python 3.7 as Normal priority.
Fri, Dec 6, 8:59 PM · VyOS 1.3 Equuleus

Thu, Dec 5

jestabro closed T1847: set_level incorrectly handles path given as empty string, a subtask of T1758: Switch vyos.config to libvyosconfig, as Resolved.
Thu, Dec 5, 12:40 PM · VyOS 1.3 Equuleus
jestabro closed T1847: set_level incorrectly handles path given as empty string as Resolved.
Thu, Dec 5, 12:40 PM · VyOS 1.3 Equuleus

Wed, Dec 4

jestabro added a comment to T1185: Firewall rulesets are ignored in RFC-compliant VRRP setups.

The fix suggested in the pull request did not resolve the issue as a consequence of T1847. With that issue resolved, we can consider this merge.

Wed, Dec 4, 10:16 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus
jestabro added a comment to T1847: set_level incorrectly handles path given as empty string.

https://github.com/vyos/vyos-1x/pull/175

Wed, Dec 4, 10:13 PM · VyOS 1.3 Equuleus
jestabro added a subtask for T1758: Switch vyos.config to libvyosconfig: T1847: set_level incorrectly handles path given as empty string.
Wed, Dec 4, 10:12 PM · VyOS 1.3 Equuleus
jestabro added a parent task for T1847: set_level incorrectly handles path given as empty string: T1758: Switch vyos.config to libvyosconfig.
Wed, Dec 4, 10:12 PM · VyOS 1.3 Equuleus
jestabro changed the status of T1847: set_level incorrectly handles path given as empty string from Open to In progress.
Wed, Dec 4, 10:06 PM · VyOS 1.3 Equuleus
jestabro closed T1787: Failed config migration from V1.2.3 to 1.2-rolling-201911030217, a subtask of T1801: Unescaped backslashes in config values cause configuration failure, as Resolved.
Wed, Dec 4, 4:27 PM · VyOS 1.3 Equuleus
jestabro closed T1787: Failed config migration from V1.2.3 to 1.2-rolling-201911030217 as Resolved.

This is reported as resolved by Line2 in parent T1801; the related issue mentioned therein is also resolved by the revised fix in T1801.

Wed, Dec 4, 4:27 PM · VyOS 1.3 Equuleus

Tue, Dec 3

jestabro added a comment to T1185: Firewall rulesets are ignored in RFC-compliant VRRP setups.

@Merijn I am consulting with the author of the pull request; I still need to confirm behavior before we can consider merging.

Tue, Dec 3, 8:15 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus
jestabro added a comment to T1744: Config load fails in ConfigTree with ValueError: Failed to parse config: lexing: empty token.

The resolution in T1801 will prevent the error in this case.

Tue, Dec 3, 7:14 PM · VyOS 1.3 Equuleus
jestabro closed T1801: Unescaped backslashes in config values cause configuration failure as Resolved.
Tue, Dec 3, 7:10 PM · VyOS 1.3 Equuleus
jestabro added a comment to T1801: Unescaped backslashes in config values cause configuration failure.

The general solution has been merged into vyos-1x.

Tue, Dec 3, 5:33 PM · VyOS 1.3 Equuleus

Wed, Nov 27

jestabro added a comment to T1185: Firewall rulesets are ignored in RFC-compliant VRRP setups.

@Merijn I will build and run a sanity check, and then we can merge into rolling for testing; I'll confirm when done. Thanks again for the offer to test.

Wed, Nov 27, 3:30 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus

Tue, Nov 26

jestabro reopened T1801: Unescaped backslashes in config values cause configuration failure as "In progress".
Tue, Nov 26, 4:13 PM · VyOS 1.3 Equuleus
jestabro added a comment to T1801: Unescaped backslashes in config values cause configuration failure.

The merged fix addressed the problem as it occurs in configuration mode, however, the same issue can occur during the running of migration scripts. A solution to cover all cases has been tested, and is pending.

Tue, Nov 26, 4:13 PM · VyOS 1.3 Equuleus

Mon, Nov 25

jestabro closed T1824: Permission denied: '/opt/vyatta/etc/config/vyos-migrate.log', a subtask of T1814: Add log of migration scripts run during config migration, as Resolved.
Mon, Nov 25, 4:18 PM · VyOS 1.3 Equuleus
jestabro closed T1824: Permission denied: '/opt/vyatta/etc/config/vyos-migrate.log' as Resolved.
Mon, Nov 25, 4:18 PM · VyOS 1.3 Equuleus
jestabro added a subtask for T1334: Migration script runner rewrite: T1814: Add log of migration scripts run during config migration.
Mon, Nov 25, 4:12 PM · VyOS 1.3 Equuleus
jestabro removed a subtask for T1397: Rewrite the config merge script: T1814: Add log of migration scripts run during config migration.
Mon, Nov 25, 4:12 PM · VyOS 1.3 Equuleus
jestabro edited parent tasks for T1814: Add log of migration scripts run during config migration, added: T1334: Migration script runner rewrite; removed: T1397: Rewrite the config merge script.
Mon, Nov 25, 4:12 PM · VyOS 1.3 Equuleus
jestabro added a subtask for T1814: Add log of migration scripts run during config migration: T1824: Permission denied: '/opt/vyatta/etc/config/vyos-migrate.log'.
Mon, Nov 25, 4:09 PM · VyOS 1.3 Equuleus
jestabro added a parent task for T1824: Permission denied: '/opt/vyatta/etc/config/vyos-migrate.log': T1814: Add log of migration scripts run during config migration.
Mon, Nov 25, 4:09 PM · VyOS 1.3 Equuleus

Fri, Nov 22

jestabro closed T1597: /usr/sbin/rsyslogd after deleting "system syslog" as Resolved.
Fri, Nov 22, 2:07 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro closed T1391: In route-map set community additive as Resolved.
Fri, Nov 22, 2:06 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro closed T1593: Support ip6gre as Resolved.
Fri, Nov 22, 2:06 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro closed T1701: Delete domain-name and domain-search won't work as Resolved.
Fri, Nov 22, 2:06 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro closed T1678: hostfile-update missing line feed as Resolved.
Fri, Nov 22, 2:05 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro closed T1694: NTPd: Do not listen on all interfaces by default as Resolved.
Fri, Nov 22, 2:05 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro closed T1772: <regex> constraints in XML are partially broken as Resolved.
Fri, Nov 22, 2:05 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro closed T1749: numeric validator doesn't support multiple ranges as Resolved.
Fri, Nov 22, 2:04 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro closed T1786: disable-dhcp-nameservers is missed in current host_name.py implementation as Resolved.
Fri, Nov 22, 2:03 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus

Thu, Nov 21

jestabro closed T1814: Add log of migration scripts run during config migration as Resolved.
Thu, Nov 21, 8:36 PM · VyOS 1.3 Equuleus
jestabro closed T1814: Add log of migration scripts run during config migration, a subtask of T1397: Rewrite the config merge script, as Resolved.
Thu, Nov 21, 8:36 PM · VyOS 1.3 Equuleus
jestabro closed T1818: Print name of migration script on failure as Resolved.
Thu, Nov 21, 8:35 PM · VyOS 1.3 Equuleus
jestabro changed Version from - to 1.2-rolling, 1.3 on T1818: Print name of migration script on failure.
Thu, Nov 21, 8:34 PM · VyOS 1.3 Equuleus
jestabro claimed T1814: Add log of migration scripts run during config migration.
Thu, Nov 21, 8:34 PM · VyOS 1.3 Equuleus
jestabro changed the status of T1818: Print name of migration script on failure from Open to In progress.
Thu, Nov 21, 8:23 PM · VyOS 1.3 Equuleus

Wed, Nov 20

jestabro edited projects for T1185: Firewall rulesets are ignored in RFC-compliant VRRP setups, added: VyOS 1.2 Crux (VyOS 1.2.5); removed VyOS 1.2 Crux (VyOS 1.2.4).

This still needs some review and testing. @Merijn, thank you for the offer; testing will be much appreciated, once PRs are merged.

Wed, Nov 20, 7:04 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus

Tue, Nov 19

jestabro moved T1786: disable-dhcp-nameservers is missed in current host_name.py implementation from Backlog to Finished on the VyOS 1.2 Crux (VyOS 1.2.4) board.
Tue, Nov 19, 7:42 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro moved T1749: numeric validator doesn't support multiple ranges from Backlog to Finished on the VyOS 1.2 Crux (VyOS 1.2.4) board.
Tue, Nov 19, 7:28 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro moved T1812: DHCP: hostnames of clients not resolving after update v1.2.3 -> 1.2-rolling from Needs Triage to Finished on the VyOS 1.2 Crux (VyOS 1.2.4) board.
Tue, Nov 19, 7:24 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro moved T1772: <regex> constraints in XML are partially broken from Backlog to Finished on the VyOS 1.2 Crux (VyOS 1.2.4) board.
Tue, Nov 19, 7:13 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro moved T1694: NTPd: Do not listen on all interfaces by default from Backlog to Finished on the VyOS 1.2 Crux (VyOS 1.2.4) board.
Tue, Nov 19, 7:00 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro edited projects for T1747: L2TP breaks after upgrading to VyOS 1.2-rolling-201910180117 [issue report and proposed solution], added: VyOS 1.2 Crux (VyOS 1.2.5); removed VyOS 1.2 Crux (VyOS 1.2.4).
Tue, Nov 19, 6:33 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus
jestabro edited projects for T1755: Python KeyError exceptions raised with 'show vpn ipsec sa' command under use of certain IPSEC cipher suites., added: VyOS 1.2 Crux (VyOS 1.2.5); removed VyOS 1.2 Crux (VyOS 1.2.4).
Tue, Nov 19, 6:10 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus
jestabro moved T1678: hostfile-update missing line feed from Backlog to Finished on the VyOS 1.2 Crux (VyOS 1.2.4) board.
Tue, Nov 19, 4:23 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro moved T1701: Delete domain-name and domain-search won't work from Backlog to Finished on the VyOS 1.2 Crux (VyOS 1.2.4) board.
Tue, Nov 19, 4:19 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro added a comment to T1755: Python KeyError exceptions raised with 'show vpn ipsec sa' command under use of certain IPSEC cipher suites..

This is dependent on T1260, which will need to be backported.

Tue, Nov 19, 4:08 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus
jestabro added a comment to T1260: VICI-based implementation of "run show vpn ipsec sa".

This never made it into VyOS 1.2.1, so it will need to be backported to Crux, either 1.2.4 or 1.2.5, depending on schedule.

Tue, Nov 19, 4:05 PM · VyOS 1.3 Equuleus
jestabro moved T1593: Support ip6gre from Backlog to Finished on the VyOS 1.2 Crux (VyOS 1.2.4) board.
Tue, Nov 19, 3:31 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro edited projects for T1452: accel-pppoe - add vendor option to shaper , added: VyOS 1.2 Crux (VyOS 1.2.5); removed VyOS 1.2 Crux (VyOS 1.2.4).

This will need several related commits, testing, before being backported.

Tue, Nov 19, 3:21 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus
jestabro moved T1391: In route-map set community additive from Backlog to Finished on the VyOS 1.2 Crux (VyOS 1.2.4) board.
Tue, Nov 19, 2:01 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus
jestabro edited projects for T1622: Add failsafe and back trace to boot config loader, added: VyOS 1.2 Crux (VyOS 1.2.5); removed VyOS 1.2 Crux (VyOS 1.2.4).
Tue, Nov 19, 1:50 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus
jestabro moved T1597: /usr/sbin/rsyslogd after deleting "system syslog" from Backlog to Finished on the VyOS 1.2 Crux (VyOS 1.2.4) board.
Tue, Nov 19, 1:49 PM · VyOS 1.2 Crux (VyOS 1.2.4), VyOS 1.3 Equuleus

Mon, Nov 18

jestabro closed T1801: Unescaped backslashes in config values cause configuration failure as Resolved.
Mon, Nov 18, 9:12 PM · VyOS 1.3 Equuleus
jestabro added a subtask for T1397: Rewrite the config merge script: T1814: Add log of migration scripts run during config migration.
Mon, Nov 18, 4:05 PM · VyOS 1.3 Equuleus
jestabro added a parent task for T1814: Add log of migration scripts run during config migration: T1397: Rewrite the config merge script.
Mon, Nov 18, 4:05 PM · VyOS 1.3 Equuleus
jestabro changed the status of T1814: Add log of migration scripts run during config migration from Open to In progress.
Mon, Nov 18, 4:04 PM · VyOS 1.3 Equuleus

Thu, Nov 14

jestabro closed T1424: Rewrite the config load script as Resolved.
Thu, Nov 14, 8:36 PM · VyOS 1.3 Equuleus
jestabro closed T1710: [equuleus] buster: add patch to fix live-build missing key error as Resolved.
Thu, Nov 14, 8:31 PM · VyOS 1.3 Equuleus
jestabro closed T1736: Decide on best practice for patching live-team packages for VyOS build system as Resolved.
Thu, Nov 14, 8:30 PM · VyOS 1.3 Equuleus
jestabro closed T1804: Add python3-psutil to docker image as Resolved.
Thu, Nov 14, 8:29 PM · VyOS 1.3 Equuleus

Wed, Nov 13

jestabro claimed T1801: Unescaped backslashes in config values cause configuration failure.

In PR https://github.com/vyos/vyos-1x/pull/162, util.py is pulled in to the nosetests path; T1804 will need to be closed before merging.

Wed, Nov 13, 9:33 PM · VyOS 1.3 Equuleus
jestabro changed the status of T1804: Add python3-psutil to docker image from Open to In progress.
Wed, Nov 13, 9:31 PM · VyOS 1.3 Equuleus

Tue, Nov 12

jestabro triaged T1801: Unescaped backslashes in config values cause configuration failure as Normal priority.
Tue, Nov 12, 10:02 PM · VyOS 1.3 Equuleus
jestabro changed the status of T1801: Unescaped backslashes in config values cause configuration failure, a subtask of T1787: Failed config migration from V1.2.3 to 1.2-rolling-201911030217, from Open to In progress.
Tue, Nov 12, 10:01 PM · VyOS 1.3 Equuleus
jestabro changed the status of T1801: Unescaped backslashes in config values cause configuration failure from Open to In progress.
Tue, Nov 12, 10:01 PM · VyOS 1.3 Equuleus
jestabro added a subtask for T1787: Failed config migration from V1.2.3 to 1.2-rolling-201911030217: T1801: Unescaped backslashes in config values cause configuration failure.
Tue, Nov 12, 9:56 PM · VyOS 1.3 Equuleus
jestabro added a parent task for T1801: Unescaped backslashes in config values cause configuration failure: T1787: Failed config migration from V1.2.3 to 1.2-rolling-201911030217.
Tue, Nov 12, 9:56 PM · VyOS 1.3 Equuleus
jestabro created T1801: Unescaped backslashes in config values cause configuration failure.
Tue, Nov 12, 9:51 PM · VyOS 1.3 Equuleus

Nov 8 2019

jestabro added a comment to T1787: Failed config migration from V1.2.3 to 1.2-rolling-201911030217.

cf. T1001 as a related issue:

Nov 8 2019, 3:09 PM · VyOS 1.3 Equuleus

Oct 15 2019

jestabro created T1736: Decide on best practice for patching live-team packages for VyOS build system.
Oct 15 2019, 8:04 PM · VyOS 1.3 Equuleus

Oct 3 2019

jestabro changed the status of T1710: [equuleus] buster: add patch to fix live-build missing key error from Open to Needs testing.
Oct 3 2019, 3:28 PM · VyOS 1.3 Equuleus

Sep 21 2019

jestabro closed T1676: [equuleus] buster: update GRUB boot parameters during upgrade, a subtask of T476: Start builds for Debian 10 (Buster), as Resolved.
Sep 21 2019, 12:09 AM · VyOS 1.3 Equuleus
jestabro closed T1676: [equuleus] buster: update GRUB boot parameters during upgrade as Resolved.
Sep 21 2019, 12:09 AM · VyOS 1.3 Equuleus
jestabro added a subtask for T476: Start builds for Debian 10 (Buster): T1676: [equuleus] buster: update GRUB boot parameters during upgrade.
Sep 21 2019, 12:07 AM · VyOS 1.3 Equuleus
jestabro added a parent task for T1676: [equuleus] buster: update GRUB boot parameters during upgrade: T476: Start builds for Debian 10 (Buster).
Sep 21 2019, 12:07 AM · VyOS 1.3 Equuleus

Sep 20 2019

jestabro changed the status of T1676: [equuleus] buster: update GRUB boot parameters during upgrade from Open to In progress.
Sep 20 2019, 9:44 PM · VyOS 1.3 Equuleus
jestabro closed T1602: equuleus: buster: add live build apt options for choosing vyos packages, a subtask of T476: Start builds for Debian 10 (Buster), as Resolved.
Sep 20 2019, 9:29 PM · VyOS 1.3 Equuleus
jestabro closed T1602: equuleus: buster: add live build apt options for choosing vyos packages as Resolved.
Sep 20 2019, 9:29 PM · VyOS 1.3 Equuleus

Sep 7 2019

jestabro changed the status of T1424: Rewrite the config load script from On hold to In progress.
Sep 7 2019, 3:59 PM · VyOS 1.3 Equuleus

Aug 31 2019

jestabro changed the status of T1622: Add failsafe and back trace to boot config loader from Open to In progress.
Aug 31 2019, 11:01 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus