jestabro (John Estabrook)
User

Projects

Maintainers
Group
VyOS 1.4 Sagitta
Experimental

User Details

User Since: Apr 12 2019, 4:27 PM (168 w, 3 d)

Recent Activity
View All

Wed, Jun 29

jestabro changed the status of T4491: Use empty string for internal name of root node of config_tree, a subtask of T4235: Add config tree diff algorithm, from In progress to Backport candidate.

Wed, Jun 29, 2:48 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro changed the status of T4491: Use empty string for internal name of root node of config_tree from In progress to Backport candidate.

Wed, Jun 29, 2:48 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

Tue, Jun 28

jestabro added a comment to T4491: Use empty string for internal name of root node of config_tree.

PR:
https://github.com/vyos/vyos1x-config/pull/9

Tue, Jun 28, 8:18 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro renamed T4491: Use empty string for internal name of root node of config_tree from Use empty string for internal name of root of config_tree to Use empty string for internal name of root node of config_tree.

Tue, Jun 28, 8:17 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro added a subtask for T4235: Add config tree diff algorithm: T4491: Use empty string for internal name of root node of config_tree.

Tue, Jun 28, 8:17 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro added a parent task for T4491: Use empty string for internal name of root node of config_tree: T4235: Add config tree diff algorithm.

Tue, Jun 28, 8:17 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro changed the status of T4295: Use config_tree instead of legacy loadFile in vyos-load-config.py, a subtask of T4235: Add config tree diff algorithm, from Open to On hold.

Tue, Jun 28, 7:57 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro changed the status of T4295: Use config_tree instead of legacy loadFile in vyos-load-config.py, a subtask of T4316: Update save-config/load-config, from Open to On hold.

Tue, Jun 28, 7:57 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro changed the status of T4295: Use config_tree instead of legacy loadFile in vyos-load-config.py from Open to On hold.

Tue, Jun 28, 7:57 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro updated the task description for T4316: Update save-config/load-config.

Tue, Jun 28, 7:56 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro updated the task description for T4295: Use config_tree instead of legacy loadFile in vyos-load-config.py.

Tue, Jun 28, 7:55 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro changed the status of T4491: Use empty string for internal name of root node of config_tree from Open to In progress.

Tue, Jun 28, 7:05 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

Sat, Jun 18

jestabro claimed T4467: Validator Does Not Accept Signed Numbers.

Sat, Jun 18, 12:59 AM · VyOS 1.4 Sagitta

jestabro added a comment to T4467: Validator Does Not Accept Signed Numbers.

PR: https://github.com/vyos/vyos-utils/pull/4
Adding the additional validator to policy.xml.in allows the smoketest (above) to pass.

Sat, Jun 18, 12:55 AM · VyOS 1.4 Sagitta

Fri, Jun 17

jestabro added a comment to T4467: Validator Does Not Accept Signed Numbers.

An initial approach as linked below; to be discussed before PR.
https://github.com/vyos/vyos-utils/compare/master...jestabro:increment-decrement?expand=1

Fri, Jun 17, 5:31 PM · VyOS 1.4 Sagitta

May 25 2022

jestabro closed T4382: Replacing legacy loadFile exposes missing steps in migration scripts and other errors, a subtask of T4295: Use config_tree instead of legacy loadFile in vyos-load-config.py, as Resolved.

May 25 2022, 8:34 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro closed T4382: Replacing legacy loadFile exposes missing steps in migration scripts and other errors as Resolved.

May 25 2022, 8:34 PM · VyOS 1.4 Sagitta

jestabro added a comment to T4382: Replacing legacy loadFile exposes missing steps in migration scripts and other errors.

PR fixing exposed errors:
https://github.com/vyos/vyos-1x/pull/1331

May 25 2022, 5:01 PM · VyOS 1.4 Sagitta

jestabro renamed T4382: Replacing legacy loadFile exposes missing steps in migration scripts and other errors from Replacing legacy loadFile exposes missing steps in migration scripts to Replacing legacy loadFile exposes missing steps in migration scripts and other errors.

May 25 2022, 4:46 PM · VyOS 1.4 Sagitta

May 23 2022

jestabro claimed T4438: vyos-http-api doesn't start after router reboot if vrf is defined.

May 23 2022, 1:30 PM · VyOS 1.4 Sagitta

May 18 2022

jestabro added a comment to T4316: Update save-config/load-config.

Draft PR here:
https://github.com/vyos/vyos-1x/pull/1328

May 18 2022, 8:51 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

May 17 2022

jestabro added a comment to T4413: Add an API endpoint with basic system stats.

Details of adding a query such as this (20 lines of meaningful code/50 of boilerplate):
https://github.com/vyos/vyos-1x/commit/b62f5df2c796d0567b370e27fcec2005a02a4cd3

May 17 2022, 9:04 PM · VyOS 1.4 Sagitta

jestabro added a comment to T4413: Add an API endpoint with basic system stats.

An initial implementation has been provided to Andrew Moshensky for testing with the local UI.

May 17 2022, 6:52 PM · VyOS 1.4 Sagitta

May 16 2022

jestabro added a comment to T4396: HTTP API no response after several days restarted.

The current discussion has taken place in the vyos-api-discussion channel; results will be summarized here.

May 16 2022, 5:36 PM · VyOS 1.3 Equuleus ( 1.3.1)

jestabro added a comment to T4396: HTTP API no response after several days restarted.

Firstly, is there any info in the logs ?

May 16 2022, 12:40 PM · VyOS 1.3 Equuleus ( 1.3.1)

jestabro added a comment to T4396: HTTP API no response after several days restarted.

As discussed in the slack channel today, let us follow up here, as I'd like to run through some analysis, and set up a reproducer if possible.

May 16 2022, 12:32 PM · VyOS 1.3 Equuleus ( 1.3.1)

Apr 26 2022

jestabro claimed T4396: HTTP API no response after several days restarted.

Apr 26 2022, 11:26 AM · VyOS 1.3 Equuleus ( 1.3.1)

jestabro closed T4235: Add config tree diff algorithm as Resolved.

Apr 26 2022, 11:23 AM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

Apr 22 2022

jestabro changed the status of T4361: `vyos.config.exists()` does not work for nodes with multiple values from Backport candidate to Open.

Re-open for revision/simplification in:
https://github.com/vyos/vyos-1x/pull/1295

Apr 22 2022, 4:13 PM · VyOS 1.3 Equuleus (1.3.2), VyOS 1.4 Sagitta

Apr 21 2022

jestabro added a comment to T3785: Add unicode support to configtree backend.

Backported to equuleus branch of vyos1x-config:
https://github.com/vyos/vyos1x-config/commit/8ad21f6c7e6f37edeca137b2a7dc7c3f7ffc6a20

Apr 21 2022, 4:40 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

Apr 20 2022

jestabro updated the task description for T4382: Replacing legacy loadFile exposes missing steps in migration scripts and other errors.

Apr 20 2022, 9:26 PM · VyOS 1.4 Sagitta

jestabro updated the task description for T4382: Replacing legacy loadFile exposes missing steps in migration scripts and other errors.

Apr 20 2022, 9:24 PM · VyOS 1.4 Sagitta

jestabro added a subtask for T4295: Use config_tree instead of legacy loadFile in vyos-load-config.py: T4382: Replacing legacy loadFile exposes missing steps in migration scripts and other errors.

Apr 20 2022, 8:28 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro added a parent task for T4382: Replacing legacy loadFile exposes missing steps in migration scripts and other errors: T4295: Use config_tree instead of legacy loadFile in vyos-load-config.py.

Apr 20 2022, 8:28 PM · VyOS 1.4 Sagitta

jestabro changed the status of T4382: Replacing legacy loadFile exposes missing steps in migration scripts and other errors from Open to Confirmed.

Apr 20 2022, 8:25 PM · VyOS 1.4 Sagitta

Apr 15 2022

jestabro changed the status of T4361: `vyos.config.exists()` does not work for nodes with multiple values from Open to Backport candidate.

Apr 15 2022, 10:57 AM · VyOS 1.3 Equuleus (1.3.2), VyOS 1.4 Sagitta

Apr 14 2022

jestabro claimed T4361: `vyos.config.exists()` does not work for nodes with multiple values.

Apr 14 2022, 7:00 PM · VyOS 1.3 Equuleus (1.3.2), VyOS 1.4 Sagitta

Apr 8 2022

jestabro closed T4347: Return complete and consistent error codes from HTTP API as Resolved.

Apr 8 2022, 8:16 AM · VyOS 1.4 Sagitta

Apr 7 2022

jestabro changed the status of T4347: Return complete and consistent error codes from HTTP API from Needs testing to In progress.

Apr 7 2022, 11:58 PM · VyOS 1.4 Sagitta

jestabro added a comment to T4347: Return complete and consistent error codes from HTTP API.

PR:
https://github.com/vyos/vyos-1x/pull/1277

Apr 7 2022, 11:57 PM · VyOS 1.4 Sagitta

jestabro added a comment to T4347: Return complete and consistent error codes from HTTP API.

Changes and fixes to smoketest at link; in testing before PR:
https://github.com/vyos/vyos-1x/compare/current...jestabro:api-smoketest

Apr 7 2022, 9:21 PM · VyOS 1.4 Sagitta

jestabro changed the status of T4347: Return complete and consistent error codes from HTTP API from In progress to Needs testing.

Apr 7 2022, 9:13 PM · VyOS 1.4 Sagitta

jestabro changed the status of T4347: Return complete and consistent error codes from HTTP API from Open to In progress.

Apr 7 2022, 9:05 PM · VyOS 1.4 Sagitta

Apr 2 2022

jestabro closed T4335: open-vmdk fails to build under gcc-10.+ as Resolved.

Apr 2 2022, 2:11 PM · VyOS 1.4 Sagitta

jestabro reopened T4335: open-vmdk fails to build under gcc-10.+ as "Open".

Keep open until PR is merged:

Apr 2 2022, 2:07 PM · VyOS 1.4 Sagitta

jestabro updated the task description for T4335: open-vmdk fails to build under gcc-10.+.

Apr 2 2022, 1:20 PM · VyOS 1.4 Sagitta

jestabro closed T4335: open-vmdk fails to build under gcc-10.+ as Resolved.

Apr 2 2022, 1:11 PM · VyOS 1.4 Sagitta

Mar 25 2022

jestabro added a subtask for T3355: Remove all remaining legacy Vyatta code: T4320: Remove legacy version files in vyatta-cfg-system/cfg-version.

Mar 25 2022, 2:54 PM · VyOS 1.4 Sagitta

jestabro added a parent task for T4320: Remove legacy version files in vyatta-cfg-system/cfg-version: T3355: Remove all remaining legacy Vyatta code.

Mar 25 2022, 2:54 PM · VyOS 1.4 Sagitta

jestabro triaged T4320: Remove legacy version files in vyatta-cfg-system/cfg-version as Wishlist priority.

Mar 25 2022, 2:52 PM · VyOS 1.4 Sagitta

Mar 24 2022

jestabro changed the status of T4291: Consolidate component version read/write functions, a subtask of T4316: Update save-config/load-config, from Backport candidate to Open.

Mar 24 2022, 8:09 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro changed the status of T4291: Consolidate component version read/write functions from Backport candidate to Open.

Mar 24 2022, 8:09 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro added a subtask for T4316: Update save-config/load-config: T4291: Consolidate component version read/write functions.

Mar 24 2022, 8:08 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro added a parent task for T4291: Consolidate component version read/write functions: T4316: Update save-config/load-config.

Mar 24 2022, 8:08 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro changed the status of T4295: Use config_tree instead of legacy loadFile in vyos-load-config.py, a subtask of T4235: Add config tree diff algorithm, from Backport candidate to Open.

Mar 24 2022, 8:06 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro changed the status of T4295: Use config_tree instead of legacy loadFile in vyos-load-config.py, a subtask of T4316: Update save-config/load-config, from Backport candidate to Open.

Mar 24 2022, 8:06 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro changed the status of T4295: Use config_tree instead of legacy loadFile in vyos-load-config.py from Backport candidate to Open.

Mar 24 2022, 8:06 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro added a subtask for T4316: Update save-config/load-config: T4295: Use config_tree instead of legacy loadFile in vyos-load-config.py.

Mar 24 2022, 8:06 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro added a parent task for T4295: Use config_tree instead of legacy loadFile in vyos-load-config.py: T4316: Update save-config/load-config.

Mar 24 2022, 8:05 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro added a subtask for T4316: Update save-config/load-config: T4292: Rewrite vyatta-save-config.pl to Python.

Mar 24 2022, 8:04 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro added a parent task for T4292: Rewrite vyatta-save-config.pl to Python: T4316: Update save-config/load-config.

Mar 24 2022, 8:04 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro removed a subtask for T3355: Remove all remaining legacy Vyatta code: T4292: Rewrite vyatta-save-config.pl to Python.

Mar 24 2022, 8:03 PM · VyOS 1.4 Sagitta

jestabro removed a parent task for T4292: Rewrite vyatta-save-config.pl to Python: T3355: Remove all remaining legacy Vyatta code.

Mar 24 2022, 8:03 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro updated the task description for T4318: Add delete_tag to configtree.py.

Mar 24 2022, 1:16 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro updated the task description for T4318: Add delete_tag to configtree.py.

Mar 24 2022, 1:03 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro triaged T4318: Add delete_tag to configtree.py as Normal priority.

Mar 24 2022, 1:02 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro updated the task description for T4316: Update save-config/load-config.

Mar 24 2022, 12:27 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

jestabro created T4316: Update save-config/load-config.

Mar 24 2022, 12:25 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

Mar 23 2022

jestabro moved T4314: Latest 1.4 Rolling release config migration error from Need Triage to Finished on the VyOS 1.4 Sagitta board.

Mar 23 2022, 4:19 PM · VyOS 1.4 Sagitta

jestabro added a project to T4314: Latest 1.4 Rolling release config migration error: VyOS 1.4 Sagitta.

Mar 23 2022, 4:19 PM · VyOS 1.4 Sagitta

jestabro closed T4314: Latest 1.4 Rolling release config migration error as Resolved.

Mar 23 2022, 4:11 PM · VyOS 1.4 Sagitta

jestabro added a comment to T4314: Latest 1.4 Rolling release config migration error.

Yes, thank you.

Mar 23 2022, 3:25 PM · VyOS 1.4 Sagitta

jestabro added a comment to T4314: Latest 1.4 Rolling release config migration error.

@pieteras.meyer , while I investigate a related issue, could you share the version before and after you attempted the failed upgrade, and the version string at the bottom of the config file in the before version ? Thanks.

Mar 23 2022, 2:55 PM · VyOS 1.4 Sagitta

jestabro added a comment to T4314: Latest 1.4 Rolling release config migration error.

Given that your current version is 1.4 20210504, this will be the next nightly, though it may be critical enough to build a rolling release now, in which case a few hours.

Mar 23 2022, 2:27 PM · VyOS 1.4 Sagitta

jestabro added a comment to T4314: Latest 1.4 Rolling release config migration error.

Yes, this is an identified bug, thanks to your report:

Mar 23 2022, 1:12 PM · VyOS 1.4 Sagitta

Mar 22 2022

jestabro added a comment to T1610: Support operator mode commands via REST API.

My understanding of the requirement would be, say, T3758 in the case of op-mode. I consider this to require the refinement of op-mode firstly, as one wants per-command authorization.

Mar 22 2022, 3:01 PM · VyOS 1.3 Equuleus (1.3.0)

jestabro added a comment to T1610: Support operator mode commands via REST API.

op-mode endpoints for 'show', 'generate', 'image' have been a part of the REST API for a while, as I'm sure you are aware (just to be clear):

Mar 22 2022, 2:36 PM · VyOS 1.3 Equuleus (1.3.0)