A version of @hagbard 's fix has been committed as eced4a49c67d2e0e3e131193afe679aee0c5c679; the incorrect behaviour with the edit level has been fixed and referenced in that task (T1846).

Mon, Dec 9, 6:26 PM

jestabro changed the status of T1846: Make session_config not depend on the current edit level from Open to In progress.

A parsimonious fix to this issue has been committed; I will move the status to "In progress" until the related issues mentioned here are sorted through.

Mon, Dec 9, 6:19 PM

jestabro claimed T1846: Make session_config not depend on the current edit level.

Mon, Dec 9, 5:30 PM

Fri, Dec 6

jestabro moved T1862: Use regex pattern \s+ to split strings on whitespace in Python 3.7 from Need Triage to In Progress on the VyOS 1.3 Equuleus board.

Fri, Dec 6, 9:54 PM · VyOS 1.3 Equuleus

jestabro reopened T1862: Use regex pattern \s+ to split strings on whitespace in Python 3.7 as "In progress".

Fri, Dec 6, 9:16 PM · VyOS 1.3 Equuleus

jestabro closed T1862: Use regex pattern \s+ to split strings on whitespace in Python 3.7 as Resolved.

Fri, Dec 6, 9:15 PM · VyOS 1.3 Equuleus

jestabro updated the task description for T1862: Use regex pattern \s+ to split strings on whitespace in Python 3.7.

Fri, Dec 6, 9:09 PM · VyOS 1.3 Equuleus

jestabro triaged T1862: Use regex pattern \s+ to split strings on whitespace in Python 3.7 as Normal priority.

Fri, Dec 6, 8:59 PM · VyOS 1.3 Equuleus

Thu, Dec 5

jestabro closed T1847: set_level incorrectly handles path given as empty string, a subtask of T1758: Switch vyos.config to libvyosconfig, as Resolved.

Thu, Dec 5, 12:40 PM · VyOS 1.3 Equuleus

jestabro closed T1847: set_level incorrectly handles path given as empty string as Resolved.

Thu, Dec 5, 12:40 PM · VyOS 1.3 Equuleus

Wed, Dec 4

jestabro added a comment to T1185: Firewall rulesets are ignored in RFC-compliant VRRP setups.

The fix suggested in the pull request did not resolve the issue as a consequence of T1847. With that issue resolved, we can consider this merge.

Wed, Dec 4, 10:16 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus

jestabro added a comment to T1847: set_level incorrectly handles path given as empty string.

https://github.com/vyos/vyos-1x/pull/175

Wed, Dec 4, 10:13 PM · VyOS 1.3 Equuleus

jestabro added a subtask for T1758: Switch vyos.config to libvyosconfig: T1847: set_level incorrectly handles path given as empty string.

Wed, Dec 4, 10:12 PM · VyOS 1.3 Equuleus

jestabro added a parent task for T1847: set_level incorrectly handles path given as empty string: T1758: Switch vyos.config to libvyosconfig.

Wed, Dec 4, 10:12 PM · VyOS 1.3 Equuleus

jestabro changed the status of T1847: set_level incorrectly handles path given as empty string from Open to In progress.

Wed, Dec 4, 10:06 PM · VyOS 1.3 Equuleus

jestabro closed T1787: Failed config migration from V1.2.3 to 1.2-rolling-201911030217, a subtask of T1801: Unescaped backslashes in config values cause configuration failure, as Resolved.

Wed, Dec 4, 4:27 PM · VyOS 1.3 Equuleus

jestabro closed T1787: Failed config migration from V1.2.3 to 1.2-rolling-201911030217 as Resolved.

This is reported as resolved by Line2 in parent T1801; the related issue mentioned therein is also resolved by the revised fix in T1801.

Wed, Dec 4, 4:27 PM · VyOS 1.3 Equuleus

Tue, Dec 3

jestabro added a comment to T1185: Firewall rulesets are ignored in RFC-compliant VRRP setups.

@Merijn I am consulting with the author of the pull request; I still need to confirm behavior before we can consider merging.

Tue, Dec 3, 8:15 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus

jestabro added a comment to T1744: Config load fails in ConfigTree with ValueError: Failed to parse config: lexing: empty token.

The resolution in T1801 will prevent the error in this case.

Tue, Dec 3, 7:14 PM · VyOS 1.3 Equuleus

jestabro closed T1801: Unescaped backslashes in config values cause configuration failure as Resolved.

Tue, Dec 3, 7:10 PM · VyOS 1.3 Equuleus

jestabro added a comment to T1801: Unescaped backslashes in config values cause configuration failure.

The general solution has been merged into vyos-1x.

Tue, Dec 3, 5:33 PM · VyOS 1.3 Equuleus

Wed, Nov 27

jestabro added a comment to T1185: Firewall rulesets are ignored in RFC-compliant VRRP setups.

@Merijn I will build and run a sanity check, and then we can merge into rolling for testing; I'll confirm when done. Thanks again for the offer to test.

Wed, Nov 27, 3:30 PM · VyOS 1.2 Crux (VyOS 1.2.5), VyOS 1.3 Equuleus

Tue, Nov 26

jestabro reopened T1801: Unescaped backslashes in config values cause configuration failure as "In progress".

Tue, Nov 26, 4:13 PM · VyOS 1.3 Equuleus

jestabro added a comment to T1801: Unescaped backslashes in config values cause configuration failure.

The merged fix addressed the problem as it occurs in configuration mode, however, the same issue can occur during the running of migration scripts. A solution to cover all cases has been tested, and is pending.

Tue, Nov 26, 4:13 PM · VyOS 1.3 Equuleus