Page MenuHomePhabricator

runar (Runar Borge)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 7 2018, 9:21 PM (26 w, 4 d)

Recent Activity

Fri, Dec 7

runar added a comment to T1075: Unable to build the ISO for VyOS 1.2.0.

I did a build yesterday that went trough without issues..
I was using custom kernel, wireguard module and strongswan module. So from my point of view everything is fine now.

Fri, Dec 7, 4:24 PM · VyOS 1.2.x

Sun, Dec 2

runar updated subscribers of T1070: SWANCTL: DMVPN: ALL peers are deleted in swan when opennhrp tries to delete ONE peer.

@syncer, this is a quite serious security issue and a deal breaker for dmvpn. As we have earlier stated that dmvpn is working now (http://blog.vyos.net/vyos-development-news-in-august-and-september) i think this needs to be fixed before 1.2LTS ... OR. We need to make a new statement that states that dmvpn will be broken in 1.2LTS..

Sun, Dec 2, 9:50 AM · VyOS 1.3.x
runar added a comment to T1070: SWANCTL: DMVPN: ALL peers are deleted in swan when opennhrp tries to delete ONE peer.

I've been trying to get a dev environment for vyos-strongswan up and running for a couple of days now but are unable to compile it.. right now i'm stuck with the compile system not finding my libsoup-2.4 package :/

Sun, Dec 2, 7:49 AM · VyOS 1.3.x

Fri, Nov 30

runar created T1070: SWANCTL: DMVPN: ALL peers are deleted in swan when opennhrp tries to delete ONE peer in the S1 VyOS Public space.
Fri, Nov 30, 10:13 PM · VyOS 1.3.x
runar created T1063: Wireguard: Unable to add wireguard interface to a routing protocol (eg. ospf) in the S1 VyOS Public space.
Fri, Nov 30, 1:16 PM · VyOS 1.2.x ( VyOS 1.2.0-rc11)
runar created T1061: Wireguard: Missing option to administrativly shutdown interface in the S1 VyOS Public space.
Fri, Nov 30, 1:02 PM · VyOS-1.2.0-LTS, VyOS 1.2.x (VyOS 1.2.0-rc10)
runar added a commit to T1060: Possibility to bypass the webproxy based on source IP address: Unknown Object (Diffusion Commit).
Fri, Nov 30, 11:18 AM · VyOS 1.3.x, vyatta-webproxy

Wed, Nov 28

runar added a comment to T393: Migrate vyatta-lldpd to vyos-1x.

While it is work ongoing on this, the code for LLDPD is quite old. i would request an upgrade to the newest version . https://github.com/vincentbernat/lldpd/tree/1.0.1

Wed, Nov 28, 8:01 PM · VyOS 1.3.x

Sun, Nov 25

runar added a comment to T1045: static route dhcp-interface failes on bootup.

The fault is verified on the latest rc8 and the latest rolling ( vyos-1.2.0-rolling+201811251437-amd64.iso)

Sun, Nov 25, 9:25 PM · VyOS 1.2.x (VyOS 1.2.0-rc10)
runar updated the task description for T1045: static route dhcp-interface failes on bootup.
Sun, Nov 25, 8:41 PM · VyOS 1.2.x (VyOS 1.2.0-rc10)
runar created T1045: static route dhcp-interface failes on bootup in the S1 VyOS Public space.
Sun, Nov 25, 8:40 PM · VyOS 1.2.x (VyOS 1.2.0-rc10)

Sat, Nov 24

runar added a comment to T1019: Enable Google BBR support at kernel compile time.

Hmm, please enligthen me. Google BBR is a new way to handle congesition instead of the traditional way tcp deals with it. This functionallity needs to be enabled in the end host systems starting the tcp session to have any impact on troughput and congestion control.. as vyos is a router and are not responsible to start tcp sessions on behalf of any end system, what is the benefit of adding this functionallity?

Sat, Nov 24, 11:04 AM · VyOS 1.2.x (VyOS 1.2.0-rc10)
runar added a comment to T1012: vyos-build configure script should check /etc/issue to avoid confusion.

Another way is to check in /etc/os-release, but that is also a changeable file.... Wondering where lsb_release reads it from ( no pc atm, so cannot check)

Sat, Nov 24, 10:10 AM · VyOS 1.3.x, vyos-build

Fri, Nov 23

runar created T1036: NHRP starts before IPSEC is set up..
Fri, Nov 23, 6:50 PM · VyOS 1.2.x (VyOS 1.2.0-rc9)

Nov 10 2018

runar added a comment to T786: new style xml and conf-mode scripts: posibillity to add tagNode value as parameter to conf-script.

Its a little hack, but not the ultimate one i think :p temporary files for storing state is used quite a few times inn the original bash/perl scripts

Nov 10 2018, 9:04 AM · VyOS 1.3.x
runar added a comment to T786: new style xml and conf-mode scripts: posibillity to add tagNode value as parameter to conf-script.

as noted on slack:
A way to implement the run once for tag :
If we in the tag after first execution add a temp file 'touch /tmp/complete-blah' , then we check for existance on that file on every run and skip of it exists..
in eg. wireguard/node.def:

end: if [ ! -f /tmp/runonce-wireguard.lock ]; then
         sudo sh -c "${vyos_conf_scripts_dir}/wireguard.py"
         touch /tmp/runonce-wireguard.lock
     fi

Whis way the wireguard.py shuld only execute on the first "execution" and be skipped on all recurring runs.

Nov 10 2018, 8:41 AM · VyOS 1.3.x

Nov 9 2018

runar updated subscribers of T786: new style xml and conf-mode scripts: posibillity to add tagNode value as parameter to conf-script.

I've been looking into how this is implemented in all instances of interfaces/* and everyone uses the same run on every tag value instance approach.
Here are a couple of examples of easy implementations looked from node.def
openvpn:
sudo /opt/vyatta/sbin/vyatta-update-ovpn.pl "$VAR(@)"

Nov 9 2018, 11:28 PM · VyOS 1.3.x

Nov 7 2018

runar added a comment to T975: `Show ip multicast mfc/interface` prints adresses the wrong way around.

I see T959 is targeted for 1.3 release and is hereby requesting a backport of these commands from T959 into 1.2 before LTS is released (if there isn't any dependencies between the show commands and the rewrite of conf mode scripts)

Nov 7 2018, 11:11 AM · VyOS 1.2.x (VyOS 1.2.0-rc7), VyOS-1.2.0-LTS
runar created T975: `Show ip multicast mfc/interface` prints adresses the wrong way around.
Nov 7 2018, 10:37 AM · VyOS 1.2.x (VyOS 1.2.0-rc7), VyOS-1.2.0-LTS

Oct 30 2018

runar added a comment to T949: config issue when creating multiple wg interfaces at the same time..

This is exactly the same issue i reported in T786, for every interface thats created the script runs its full processing.. when 10 interfaces are created it tries to execute it 10 times and so on. I have purposed a fix for this behaveor in T786 and there is a PR (https://github.com/vyos/vyos-1x/pull/33) on this. Another thing that could be done to fix this is to fix the underlaying vbash code that makes this happen, but i think that is a larger task.

Oct 30 2018, 5:15 PM · VyOS-1.2.0-LTS, VyOS 1.2.x (VyOS 1.2.0-rc6)

Oct 17 2018

runar added a comment to T908: op mode command show bridge brX is broken.

Ahh, my mistake! Will remember that :)

Oct 17 2018, 3:53 PM · VyOS-1.2.0-LTS, VyOS 1.2.x (VyOS 1.2.0-rc4)

Oct 10 2018

runar added a comment to T870: Commit-confirm restarts the server even after commit.

@hagbard, the powerctrl.py script allready have everything needed, --check to check for scheduled reboot. :)

Oct 10 2018, 4:38 AM · VyOS-1.2.0-LTS, VyOS 1.2.x (VyOS 1.2.0-rc2)

Oct 9 2018

runar added a comment to T870: Commit-confirm restarts the server even after commit.

Hmm.. i think some things is missing here... the "reboot" and "poweroff" commands is using the new /usr/libexec/vyos/op_mode/powerctrl.py script to schedule reboots, but "show reboot" and "show poweroff"

Oct 9 2018, 7:51 PM · VyOS-1.2.0-LTS, VyOS 1.2.x (VyOS 1.2.0-rc2)

Oct 8 2018

runar added a comment to T875: Kernel config cleanup.

General:
Support for multiple non-ASCII, non-Unicode encodings

  • Remove it
Oct 8 2018, 8:41 PM · VyOS 1.2.x ( VyOS 1.2.0-rc11)

Sep 20 2018

runar added a comment to T848: OpenNHRP / DMVPN not working in HUB mode.

I've now sucessfully labbed your config, and are able to get dmvpn up and running with your ipsec config :

Sep 20 2018, 8:21 AM · Invalid

Sep 5 2018

runar added a comment to T786: new style xml and conf-mode scripts: posibillity to add tagNode value as parameter to conf-script.

Yes, in some situations this is resolvable eg in the service broadcast-relay example. Here the owner parameter could be moved to the "top-node" for that block. the problem with interfaces is that every config block is a tagNode, so we can't do that trick without moving it to the interfaces node that catches all interfaces., and not just interfaces of the type you want.

Sep 5 2018, 8:21 PM · VyOS 1.3.x

Sep 1 2018

runar created T822: monitor traffic interface.... not working in latest rolling VyOS 1.2.0-rolling+201809011952.
Sep 1 2018, 10:37 PM · VyOS-1.2.0-LTS, VyOS 1.2.x (VyOS 1.2.0-rc1)
runar created T821: show | commands . in conf mode fails when commands are in commit queue.
Sep 1 2018, 8:35 PM · VyOS-1.2.0-LTS, VyOS 1.2.x (VyOS 1.2.0-rc1)

Aug 26 2018

runar added a comment to T787: DMVPN on 1.2.0.

nize @c-po!
a new image is created to hotfix frr not starting before vyatta-router: http://dev.packages.vyos.net/tmp/vyos-1.2.0-frr-20180825.iso

Aug 26 2018, 4:50 AM · VyOS-1.2.0-LTS, VyOS 1.2.x (VyOS 1.2.0-rc1)

Aug 24 2018

runar added a comment to T787: DMVPN on 1.2.0.

@c-po, Ahh! :)
You could compile the vyos/vyos-strongswan github repo, but a image is the best to test with.
i had issues with just apply'ing strongswan patches. (strongswan crashed and hung my device when restarting services)
The latest image created is http://dev.packages.vyos.net/tmp/vyos-dmvpn-0820.iso created by @dmbaturin on 21.aug ..
after that is installed change this:

Aug 24 2018, 12:50 PM · VyOS-1.2.0-LTS, VyOS 1.2.x (VyOS 1.2.0-rc1)

Aug 23 2018

runar added a comment to T787: DMVPN on 1.2.0.

@c-po did you manage to test disabling cisco-unity in a mixed vyos/cisco environment?

Aug 23 2018, 7:56 PM · VyOS-1.2.0-LTS, VyOS 1.2.x (VyOS 1.2.0-rc1)
runar added a comment to T427: Wireguard support.

I think the best is to use the default from the protocoll.. (autogenerate port if none is specified) 51820 could be a completion help option on the listen-port command

Aug 23 2018, 2:16 PM · VyOS-1.2.0-LTS, VyOS 1.2.x (VyOS 1.2.0-rc1)
runar added a comment to T427: Wireguard support.

@c-po, As far as i can see it does not distinguish between server and client mode.
From the manual:

Aug 23 2018, 8:04 AM · VyOS-1.2.0-LTS, VyOS 1.2.x (VyOS 1.2.0-rc1)

Aug 22 2018

runar added a comment to T427: Wireguard support.

@hagbard i actually haven't tried it in real life, only looked at the command syntax'es.

Aug 22 2018, 7:42 PM · VyOS-1.2.0-LTS, VyOS 1.2.x (VyOS 1.2.0-rc1)
runar added a comment to T791: wirguard: implement 'set interfaces wireguard wg01 peer name...'.

@hagbard
Thats much better! :D
"peer" in "peer-pubkey" is also a bit redundant, just call it "pubkey"

Aug 22 2018, 7:35 PM · VyOS-1.2.0-LTS, VyOS 1.2.x (VyOS 1.2.0-rc1)
runar added a comment to T787: DMVPN on 1.2.0.

as far as i can see this should be possible. it looks like the cisco_unity plugin is used to automatically install routes and other things that is not needed when we are running inside a gre tunnel as is done in dmvpn. but i have not looked into the unity plugins code so i'm not completely sure.

Aug 22 2018, 1:27 PM · VyOS-1.2.0-LTS, VyOS 1.2.x (VyOS 1.2.0-rc1)
runar added a comment to T427: Wireguard support.

I think that using the key as a peer identifier makes the configuration unreadable its quite hard to identify each peer when you have more than one of them. I would like to se the peer identifier to be a name/description instead and that key is added as a leafNode instead...

Aug 22 2018, 10:58 AM · VyOS-1.2.0-LTS, VyOS 1.2.x (VyOS 1.2.0-rc1)
runar updated subscribers of T787: DMVPN on 1.2.0.

after @dmbaturin rolled a new image with patched opennhrp script and swanctl code dmvpn works as expected when manually disabling the cisco_unity plugin in /etc/strongswan.d/charon/unity.conf .

Aug 22 2018, 7:38 AM · VyOS-1.2.0-LTS, VyOS 1.2.x (VyOS 1.2.0-rc1)

Aug 19 2018

runar added a comment to T787: DMVPN on 1.2.0.

I got dmvpn up and running. here is the list of things to do:

Aug 19 2018, 7:20 AM · VyOS-1.2.0-LTS, VyOS 1.2.x (VyOS 1.2.0-rc1)

Aug 18 2018

runar added a comment to T786: new style xml and conf-mode scripts: posibillity to add tagNode value as parameter to conf-script.

To do the same example as it is running in the current-rolling devel i have reverted my patch:

Aug 18 2018, 7:11 PM · VyOS 1.3.x
runar added a comment to T786: new style xml and conf-mode scripts: posibillity to add tagNode value as parameter to conf-script.

The current implementation of the config interpretor does not work that way.
It is correct that your config script needs to take account of all added/removed config within your tagNode, but the script will actually run once for every tagNode instance you define.
let me take an easy example:

Aug 18 2018, 6:56 PM · VyOS 1.3.x
runar added a comment to T787: DMVPN on 1.2.0.

after intense searching i came across this:

Aug 18 2018, 10:52 AM · VyOS-1.2.0-LTS, VyOS 1.2.x (VyOS 1.2.0-rc1)
runar created T787: DMVPN on 1.2.0.
Aug 18 2018, 9:16 AM · VyOS-1.2.0-LTS, VyOS 1.2.x (VyOS 1.2.0-rc1)

Aug 17 2018

runar created T786: new style xml and conf-mode scripts: posibillity to add tagNode value as parameter to conf-script.
Aug 17 2018, 11:25 PM · VyOS 1.3.x

Aug 15 2018

runar added a comment to T766: Implement support for the Tinc VPN daemon.

i will try to do some work on implementing this if its possible to get it upstream if i succeed?

Aug 15 2018, 6:38 AM · VyOS 1.3.x

Aug 6 2018

runar created T766: Implement support for the Tinc VPN daemon.
Aug 6 2018, 10:09 AM · VyOS 1.3.x

Jun 23 2018

runar added a comment to T689: Converting simple op-mode commands from vyatta-op to new syntax.

in my latest PR i've also added a rewrite of "show host *" in show-host.xml. this rewrite does not need any wrapper scripts.

Jun 23 2018, 10:17 PM · VyOS-1.2.0-LTS, VyOS 1.2.x (VyOS 1.2.0-rc1)
runar added a comment to T689: Converting simple op-mode commands from vyatta-op to new syntax.

@dmbaturin ahh, my fault.

Jun 23 2018, 10:03 PM · VyOS-1.2.0-LTS, VyOS 1.2.x (VyOS 1.2.0-rc1)

Jun 17 2018

runar added a comment to T689: Converting simple op-mode commands from vyatta-op to new syntax.

When trying to migrate " show login " and "show history" the new syntax scripts fails to retrieve information from the current user.
The reason is that everything that is executed by the new syntax scripts are wrapped inside sudo.
(from build-command-op-templates line 140: node_def += "run: sudo sh -c \"{0}\"\n".format(command.text) . )

Jun 17 2018, 10:11 PM · VyOS-1.2.0-LTS, VyOS 1.2.x (VyOS 1.2.0-rc1)

Jun 7 2018

runar added a comment to T689: Converting simple op-mode commands from vyatta-op to new syntax.

i've added all files i have finished now.
i also have nearly completed files for show system and show log, but they need some tweeking and completion/op_mode scripts to be finished.

Jun 7 2018, 10:39 PM · VyOS-1.2.0-LTS, VyOS 1.2.x (VyOS 1.2.0-rc1)
runar added a comment to T689: Converting simple op-mode commands from vyatta-op to new syntax.

Finished so far:

  • reboot
  • poweroff
  • show arp
  • show bridge
  • show date
  • show disk
  • show configuration
  • show hardware
  • show raid
  • show users
Jun 7 2018, 10:30 PM · VyOS-1.2.0-LTS, VyOS 1.2.x (VyOS 1.2.0-rc1)
runar updated subscribers of T689: Converting simple op-mode commands from vyatta-op to new syntax.
Jun 7 2018, 9:33 PM · VyOS-1.2.0-LTS, VyOS 1.2.x (VyOS 1.2.0-rc1)
runar created T689: Converting simple op-mode commands from vyatta-op to new syntax.
Jun 7 2018, 9:31 PM · VyOS-1.2.0-LTS, VyOS 1.2.x (VyOS 1.2.0-rc1)