Page MenuHomeVyOS Platform
New Question
Ponder Q128 History

How would contributors signal to the maintainers that a feature was ready for review / merge?

Event Timeline

alainlamar asked this question.Jan 27 2018, 1:03 PM
alainlamar created this object in space S1 VyOS Public.
alainlamar created this object with visibility "Public (No Login Required)".
Herald added a subscriber: Sentrium. · View Herald TranscriptJan 27 2018, 1:03 PM
alainlamar updated the question details. (Show Details)Jan 27 2018, 1:04 PM
c-po added an answer.Jan 28 2018, 8:25 PM
syncer added a subscriber: syncer.Jan 28 2018, 8:37 PM

Historically that was few people,
now that is more people works on that we can actually do meeting and agree approach

alainlamar added a comment.Jan 28 2018, 9:07 PM

Thanks mate,

I think it would be nice for all contributors to know how they should act while developing and what actions to take in order to trigger maintainer's attention. Whatever may be agreed upon as a possible procedure, it should allow for maintainers to spend a minimum of time to evaluate "raised hands" and take appropriate action.

What would you suggest?

syncer added a comment.Jan 28 2018, 9:13 PM

Now like everybody doing it in own maneer.
I think we need to define approach for bugs and tasks
for bugs is like well described issue and procedure how to reproduce bug or issue
for tasks at least some background on what we trying to achieve with it

i think we should keep feature requests less strict to let people submit their ideas

alainlamar added a comment.Jan 28 2018, 9:49 PM

I agree with your approach on handing in bug reports and feature requests. What I try to figure out is how folks trying to solve these bugs and implement feature requests would best approach maintainers. Since there is very few maintainers and they spend their spare time on VyOS project maintainance, I think there should be guidelines for folks (like me) on how to hand in code for review - and maybe how not to. This, I hope, would allow maintainers to accept more pull requests with less use of their valuable spare time.

syncer added subscribers: c-po, UnicronNL, dmbaturin.Jan 28 2018, 9:55 PM

Yes, that is all parts of same story

  • guidelines for bug submission
  • guidelines for pull request submission
  • guidelines for feature submission (less strict)

@c-po @alainlamar what is your availability for call this week ?
@UnicronNL @dmbaturin same question to you guys.

alainlamar added a comment.Jan 28 2018, 10:02 PM

I'll be available this Monday and Thursday after 21:30 until 23:30 CET.

c-po added a comment.Jan 29 2018, 7:37 AM

IRC meetings can be held every evening starting 19:00 UTC+1

hagbard added a subscriber: hagbard.Sep 3 2018, 4:23 PM

Why not doing it via NNTP group or mailing list? I live pretty close to the 'edge' of the world (UTC -8) but would be interested to stay up to date on what your guys decide. @c-po was so far my mentor here and I asked him to get some ideas how you do things here.
Just my two cents.