Fri, Oct 11
Wed, Oct 9
Well, shame on you in that case ;0)
@phillipmcmahon I only implemented it as of yesterday ....
Well, shame on me for not trying. Appreciate you checking that on my behalf.
set interfaces ethernet ethß dhcp-options vendor-class-id "bar fooo vyos" is what you get 😄
Tue, Oct 8
I'm somewhat agnostic to the implementation method. Whether as raw options or explicitly supported options handled natively in the CLI. Both work for me.
@phillipmcmahon personally I'm not a fan of general raw option passing as we have in other places like OpenVPN oder DHCP server.
I see in v1.2.3 that the option to supply client-id and hostname exists which is great. My ISP requires the sending of DHCP Option 60 (VCI) in order to correctly get a lease. In EdgeOS it ends up looking like the following
Mon, Sep 30
This is working again in VyOS 1.2.3 GA. I have tested both the simple configuration mentioned above and my actual configuration with a bunch of BGP peers. Thank you very much!
Thu, Sep 26
Wed, Sep 25
Fri, Sep 20
PR132 fixes this problem
Thu, Sep 19
Sep 11 2019
Sep 9 2019
Sep 6 2019
It should have been fixed by https://github.com/vyos/vyos-1x/commit/ff05e2a90edf8af5d7b8ad5c69cae2dd40af2c8d It works for me in post-Sep 01 images and I don't see the error in the latest one, but I'm not sure why it would appear in the Sep 01 image if the commit is from Aug 30.
@nirmal The full fix is a bit more complicated. There are two cases: when it's called from conf mode at commit time, it needs to use the value from the proposed config (that's returnValue). However, in op mode, it also re-generates the config, so your fix would make the send dhcp6.client-id option disappear from the config when a user runs renew dhcpv6 interface .... A full fix needs to handle both cases and use returnEffectiveValue in op mode.
It was indeed a bug, caused by the same issue as all other subtasks of T1598: lack of proper synchronization.
If it re-appears, please reopen of course.