Any interface bonding changes cause interface flapping
Even if we change the description, it cause `ip link set dev bondX down` as we get [[ https://github.com/vyos/vyos-1x/blob/92aa324fef80bdb0bcb3e93feba2f4e2aa787d38/src/conf_mode/interfaces-bonding.py#L119-L120 | shutdown_required ]] even if we don't change the `mode/lacp-rate`
It seemed the bug added in this commit https://github.com/vyos/vyos-1x/commit/95e7676aa8ae5b3476b14a334b3815c2ae59f8d6
To reproduce the initial configuration:
```
set interfaces bonding bond21 member interface 'eth1'
set interfaces bonding bond21 mode '802.3ad'
set vrf name dmz table 1010
set interfaces bonding bond21 vif 10 address '10.0.10.1/31'
set interfaces bonding bond21 vif 10 vrf 'dmz'
```
Change anything, it this example a description on subinterface on bonding interface:
```
set interfaces bonding bond21 vif 10 description "DMZ-10"
```
commit/debug:
```
vyos@r1# set interfaces bonding bond21 vif 10 description "DMZ-10"
[edit]
vyos@r1# commit
[ interfaces bonding bond21 ]
DEBUG/IFCONFIG returned (err):
Error: Could not process rule: No such file or directory
delete element inet vrf_zones ct_iface_map { bond21 }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
DEBUG/IFCONFIG cmd 'ip link set dev bond21 down'
DEBUG/IFCONFIG write '100' > '/sys/class/net/bond21/bonding/miimon'
DEBUG/IFCONFIG write 'layer2' > '/sys/class/net/bond21/bonding/xmit_hash_policy'
DEBUG/IFCONFIG write '0' > '/sys/class/net/bond21/bonding/min_links'
DEBUG/IFCONFIG cmd 'ip -json link show dev bond21'
DEBUG/IFCONFIG returned (out):
[{"ifindex":23,"ifname":"bond21","flags":["BROADCAST","MULTICAST","MASTER"],"mtu":1500,"qdisc":"noqueue","operstate":"DOWN","linkmode":"DEFAULT","group":"default","txqlen":1000,"link_type":"ether","address":"50:08:00:03:00:01","broadcast":"ff:ff:ff:ff:ff:ff"}]
DEBUG/IFCONFIG write '-eth1' > '/sys/class/net/bond21/bonding/slaves'
DEBUG/IFCONFIG cmd 'ip link set dev eth1 up'
DEBUG/IFCONFIG write '802.3ad' > '/sys/class/net/bond21/bonding/mode'
DEBUG/IFCONFIG write 'slow' > '/sys/class/net/bond21/bonding/lacp_rate'
DEBUG/IFCONFIG cmd 'ip addr flush dev "eth1"'
DEBUG/IFCONFIG cmd 'ip -json link show dev eth1'
DEBUG/IFCONFIG returned (out):
[{"ifindex":3,"ifname":"eth1","flags":["BROADCAST","MULTICAST","UP"],"mtu":1500,"qdisc":"pfifo_fast","operstate":"UP","linkmode":"DEFAULT","group":"default","txqlen":1000,"link_type":"ether","address":"50:08:00:03:00:01","broadcast":"ff:ff:ff:ff:ff:ff"}]
DEBUG/IFCONFIG cmd 'ip link set dev eth1 down'
DEBUG/IFCONFIG write '+eth1' > '/sys/class/net/bond21/bonding/slaves'
DEBUG/IFCONFIG cmd 'ip link set dev eth1 up'
{'hash_policy': 'layer2',
'ifname': 'bond21',
'ip': {'arp_cache_timeout': '30'},
'lacp_rate': 'slow',
'member': {'interface': {'eth1': {}}},
'mii_mon_interval': '100',
'min_links': '0',
'mode': '802.3ad',
'mtu': '1500',
'shutdown_required': {},
'vif': {'10': {'address': ['10.0.10.1/31'],
'description': 'DMZ-10',
'ifname': 'bond21.10',
'ip': {'arp_cache_timeout': '30'},
'mtu': '1500',
'vrf': 'dmz'}}}
DEBUG/IFCONFIG cmd 'ip -json -detail link list dev bond21'
DEBUG/IFCONFIG returned (out):
[{"ifindex":23,"ifname":"bond21","flags":["BROADCAST","MULTICAST","MASTER"],"mtu":1500,"qdisc":"noqueue","operstate":"DOWN","linkmode":"DEFAULT","group":"default","txqlen":1000,"link_type":"ether","address":"50:08:00:03:00:01","broadcast":"ff:ff:ff:ff:ff:ff","promiscuity":0,"min_mtu":68,"max_mtu":65535,"linkinfo":{"info_kind":"bond","info_data":{"mode":"802.3ad","miimon":100,"updelay":0,"downdelay":0,"peer_notify_delay":0,"use_carrier":1,"arp_interval":0,"arp_validate":null,"arp_all_targets":"any","primary_reselect":"always","fail_over_mac":"none","xmit_hash_policy":"layer2","resend_igmp":1,"num_peer_notif":1,"all_slaves_active":0,"min_links":0,"lp_interval":1,"packets_per_slave":1,"ad_lacp_active":"on","ad_lacp_rate":"slow","ad_select":"stable","ad_actor_sys_prio":65535,"ad_user_port_key":0,"ad_actor_system":"00:00:00:00:00:00","tlb_dynamic_lb":1}},"inet6_addr_gen_mode":"none","num_tx_queues":16,"num_rx_queues":16,"gso_max_size":65536,"gso_max_segs":65535}]
DEBUG/IFCONFIG read '1' < '/proc/sys/net/ipv4/conf/bond21/link_filter'
DEBUG/IFCONFIG cmd 'ip -json -detail link list dev bond21'
DEBUG/IFCONFIG returned (out):
[{"ifindex":23,"ifname":"bond21","flags":["BROADCAST","MULTICAST","MASTER"],"mtu":1500,"qdisc":"noqueue","operstate":"DOWN","linkmode":"DEFAULT","group":"default","txqlen":1000,"link_type":"ether","address":"50:08:00:03:00:01","broadcast":"ff:ff:ff:ff:ff:ff","promiscuity":0,"min_mtu":68,"max_mtu":65535,"linkinfo":{"info_kind":"bond","info_data":{"mode":"802.3ad","miimon":100,"updelay":0,"downdelay":0,"peer_notify_delay":0,"use_carrier":1,"arp_interval":0,"arp_validate":null,"arp_all_targets":"any","primary_reselect":"always","fail_over_mac":"none","xmit_hash_policy":"layer2","resend_igmp":1,"num_peer_notif":1,"all_slaves_active":0,"min_links":0,"lp_interval":1,"packets_per_slave":1,"ad_lacp_active":"on","ad_lacp_rate":"slow","ad_select":"stable","ad_actor_sys_prio":65535,"ad_user_port_key":0,"ad_actor_system":"00:00:00:00:00:00","tlb_dynamic_lb":1}},"inet6_addr_gen_mode":"none","num_tx_queues":16,"num_rx_queues":16,"gso_max_size":65536,"gso_max_segs":65535}]
DEBUG/IFCONFIG cmd 'ip link set dev bond21 nomaster'
DEBUG/IFCONFIG cmd 'nft -c delete element inet vrf_zones ct_iface_map { "bond21" }'
DEBUG/IFCONFIG cmd 'nft -a list chain raw VYOS_TCP_MSS'
DEBUG/IFCONFIG returned (out):
table ip raw {
chain VYOS_TCP_MSS { # handle 1
type filter hook forward priority raw; policy accept;
}
}
DEBUG/IFCONFIG read '30000' < '/proc/sys/net/ipv4/neigh/bond21/base_reachable_time_ms'
DEBUG/IFCONFIG read '1' < '/proc/sys/net/ipv4/conf/bond21/arp_filter'
DEBUG/IFCONFIG read '0' < '/proc/sys/net/ipv4/conf/bond21/arp_accept'
DEBUG/IFCONFIG read '0' < '/proc/sys/net/ipv4/conf/bond21/arp_announce'
DEBUG/IFCONFIG read '0' < '/proc/sys/net/ipv4/conf/bond21/arp_ignore'
DEBUG/IFCONFIG read '0' < '/proc/sys/net/ipv4/conf/bond21/proxy_arp'
DEBUG/IFCONFIG read '0' < '/proc/sys/net/ipv4/conf/bond21/proxy_arp_pvlan'
DEBUG/IFCONFIG read '1' < '/proc/sys/net/ipv4/conf/bond21/forwarding'
DEBUG/IFCONFIG read '0' < '/proc/sys/net/ipv4/conf/bond21/bc_forwarding'
DEBUG/IFCONFIG read '0' < '/proc/sys/net/ipv4/conf/bond21/rp_filter'
DEBUG/IFCONFIG cmd 'ip -json -detail link list dev bond21'
DEBUG/IFCONFIG returned (out):
[{"ifindex":23,"ifname":"bond21","flags":["BROADCAST","MULTICAST","MASTER"],"mtu":1500,"qdisc":"noqueue","operstate":"DOWN","linkmode":"DEFAULT","group":"default","txqlen":1000,"link_type":"ether","address":"50:08:00:03:00:01","broadcast":"ff:ff:ff:ff:ff:ff","promiscuity":0,"min_mtu":68,"max_mtu":65535,"linkinfo":{"info_kind":"bond","info_data":{"mode":"802.3ad","miimon":100,"updelay":0,"downdelay":0,"peer_notify_delay":0,"use_carrier":1,"arp_interval":0,"arp_validate":null,"arp_all_targets":"any","primary_reselect":"always","fail_over_mac":"none","xmit_hash_policy":"layer2","resend_igmp":1,"num_peer_notif":1,"all_slaves_active":0,"min_links":0,"lp_interval":1,"packets_per_slave":1,"ad_lacp_active":"on","ad_lacp_rate":"slow","ad_select":"stable","ad_actor_sys_prio":65535,"ad_user_port_key":0,"ad_actor_system":"00:00:00:00:00:00","tlb_dynamic_lb":1}},"inet6_addr_gen_mode":"none","num_tx_queues":16,"num_rx_queues":16,"gso_max_size":65536,"gso_max_segs":65535}]
DEBUG/IFCONFIG cmd 'nft -a list chain ip6 raw VYOS_TCP_MSS'
DEBUG/IFCONFIG returned (out):
table ip6 raw {
chain VYOS_TCP_MSS { # handle 1
type filter hook forward priority raw; policy accept;
}
}
DEBUG/IFCONFIG read '1' < '/proc/sys/net/ipv6/conf/bond21/forwarding'
DEBUG/IFCONFIG read '1' < '/proc/sys/net/ipv6/conf/bond21/accept_ra'
DEBUG/IFCONFIG read '0' < '/proc/sys/net/ipv6/conf/bond21/autoconf'
DEBUG/IFCONFIG read '1' < '/proc/sys/net/ipv6/conf/bond21/dad_transmits'
DEBUG/IFCONFIG cmd 'ip -json -detail link list dev bond21'
DEBUG/IFCONFIG returned (out):
[{"ifindex":23,"ifname":"bond21","flags":["BROADCAST","MULTICAST","MASTER"],"mtu":1500,"qdisc":"noqueue","operstate":"DOWN","linkmode":"DEFAULT","group":"default","txqlen":1000,"link_type":"ether","address":"50:08:00:03:00:01","broadcast":"ff:ff:ff:ff:ff:ff","promiscuity":0,"min_mtu":68,"max_mtu":65535,"linkinfo":{"info_kind":"bond","info_data":{"mode":"802.3ad","miimon":100,"updelay":0,"downdelay":0,"peer_notify_delay":0,"use_carrier":1,"arp_interval":0,"arp_validate":null,"arp_all_targets":"any","primary_reselect":"always","fail_over_mac":"none","xmit_hash_policy":"layer2","resend_igmp":1,"num_peer_notif":1,"all_slaves_active":0,"min_links":0,"lp_interval":1,"packets_per_slave":1,"ad_lacp_active":"on","ad_lacp_rate":"slow","ad_select":"stable","ad_actor_sys_prio":65535,"ad_user_port_key":0,"ad_actor_system":"00:00:00:00:00:00","tlb_dynamic_lb":1}},"inet6_addr_gen_mode":"none","num_tx_queues":16,"num_rx_queues":16,"gso_max_size":65536,"gso_max_segs":65535}]
DEBUG/IFCONFIG cmd 'ip addr add fe80::5208:ff:fe03:1/64 dev bond21'
DEBUG/IFCONFIG cmd 'xdp_loader -d bond21 -U --auto-mode'
DEBUG/IFCONFIG returned (out):
INFO: xdp_link_detach() no curr XDP prog on ifindex:23
DEBUG/IFCONFIG cmd 'tc qdisc del dev bond21 parent ffff: 2>/dev/null'
DEBUG/IFCONFIG cmd 'tc qdisc del dev bond21 parent 1: 2>/dev/null'
DEBUG/IFCONFIG cmd 'ip link set dev bond21 up'
{'address': ['10.0.10.1/31'],
'description': 'DMZ-10',
'ifname': 'bond21.10',
'ip': {'arp_cache_timeout': '30'},
'mtu': '1500',
'vrf': 'dmz'}
DEBUG/IFCONFIG cmd 'ip -json -detail link list dev bond21.10'
DEBUG/IFCONFIG returned (out):
[{"ifindex":24,"link":"bond21","ifname":"bond21.10","flags":["NO-CARRIER","BROADCAST","MULTICAST","UP"],"mtu":1500,"qdisc":"noqueue","master":"dmz","operstate":"LOWERLAYERDOWN","linkmode":"DEFAULT","group":"default","txqlen":1000,"link_type":"ether","address":"50:08:00:03:00:01","broadcast":"ff:ff:ff:ff:ff:ff","promiscuity":0,"min_mtu":0,"max_mtu":65535,"linkinfo":{"info_kind":"vlan","info_data":{"protocol":"802.1Q","id":10,"flags":["REORDER_HDR"]},"info_slave_kind":"vrf","info_slave_data":{"table":1010}},"inet6_addr_gen_mode":"none","num_tx_queues":1,"num_rx_queues":1,"gso_max_size":65536,"gso_max_segs":65535}]
DEBUG/IFCONFIG cmd 'ip link set dev bond21.10 alias "DMZ-10"'
DEBUG/IFCONFIG read '1' < '/proc/sys/net/ipv4/conf/bond21.10/link_filter'
DEBUG/IFCONFIG cmd 'ip -json -detail link list dev bond21.10'
DEBUG/IFCONFIG returned (out):
[{"ifindex":24,"link":"bond21","ifname":"bond21.10","flags":["NO-CARRIER","BROADCAST","MULTICAST","UP"],"mtu":1500,"qdisc":"noqueue","master":"dmz","operstate":"LOWERLAYERDOWN","linkmode":"DEFAULT","group":"default","txqlen":1000,"link_type":"ether","address":"50:08:00:03:00:01","broadcast":"ff:ff:ff:ff:ff:ff","promiscuity":0,"min_mtu":0,"max_mtu":65535,"linkinfo":{"info_kind":"vlan","info_data":{"protocol":"802.1Q","id":10,"flags":["REORDER_HDR"]},"info_slave_kind":"vrf","info_slave_data":{"table":1010}},"inet6_addr_gen_mode":"none","num_tx_queues":1,"num_rx_queues":1,"gso_max_size":65536,"gso_max_segs":65535,"ifalias":"DMZ-10"}]
DEBUG/IFCONFIG cmd 'nft -a list chain raw VYOS_TCP_MSS'
DEBUG/IFCONFIG returned (out):
table ip raw {
chain VYOS_TCP_MSS { # handle 1
type filter hook forward priority raw; policy accept;
}
}
DEBUG/IFCONFIG read '30000' < '/proc/sys/net/ipv4/neigh/bond21.10/base_reachable_time_ms'
DEBUG/IFCONFIG read '1' < '/proc/sys/net/ipv4/conf/bond21.10/arp_filter'
DEBUG/IFCONFIG read '0' < '/proc/sys/net/ipv4/conf/bond21.10/arp_accept'
DEBUG/IFCONFIG read '0' < '/proc/sys/net/ipv4/conf/bond21.10/arp_announce'
DEBUG/IFCONFIG read '0' < '/proc/sys/net/ipv4/conf/bond21.10/arp_ignore'
DEBUG/IFCONFIG read '0' < '/proc/sys/net/ipv4/conf/bond21.10/proxy_arp'
DEBUG/IFCONFIG read '0' < '/proc/sys/net/ipv4/conf/bond21.10/proxy_arp_pvlan'
DEBUG/IFCONFIG read '1' < '/proc/sys/net/ipv4/conf/bond21.10/forwarding'
DEBUG/IFCONFIG read '0' < '/proc/sys/net/ipv4/conf/bond21.10/bc_forwarding'
DEBUG/IFCONFIG read '0' < '/proc/sys/net/ipv4/conf/bond21.10/rp_filter'
DEBUG/IFCONFIG cmd 'ip -json -detail link list dev bond21.10'
DEBUG/IFCONFIG returned (out):
[{"ifindex":24,"link":"bond21","ifname":"bond21.10","flags":["NO-CARRIER","BROADCAST","MULTICAST","UP"],"mtu":1500,"qdisc":"noqueue","master":"dmz","operstate":"LOWERLAYERDOWN","linkmode":"DEFAULT","group":"default","txqlen":1000,"link_type":"ether","address":"50:08:00:03:00:01","broadcast":"ff:ff:ff:ff:ff:ff","promiscuity":0,"min_mtu":0,"max_mtu":65535,"linkinfo":{"info_kind":"vlan","info_data":{"protocol":"802.1Q","id":10,"flags":["REORDER_HDR"]},"info_slave_kind":"vrf","info_slave_data":{"table":1010}},"inet6_addr_gen_mode":"none","num_tx_queues":1,"num_rx_queues":1,"gso_max_size":65536,"gso_max_segs":65535,"ifalias":"DMZ-10"}]
DEBUG/IFCONFIG cmd 'nft -a list chain ip6 raw VYOS_TCP_MSS'
DEBUG/IFCONFIG returned (out):
table ip6 raw {
chain VYOS_TCP_MSS { # handle 1
type filter hook forward priority raw; policy accept;
}
}
DEBUG/IFCONFIG read '1' < '/proc/sys/net/ipv6/conf/bond21.10/forwarding'
DEBUG/IFCONFIG read '1' < '/proc/sys/net/ipv6/conf/bond21.10/accept_ra'
DEBUG/IFCONFIG read '0' < '/proc/sys/net/ipv6/conf/bond21.10/autoconf'
DEBUG/IFCONFIG read '1' < '/proc/sys/net/ipv6/conf/bond21.10/dad_transmits'
DEBUG/IFCONFIG cmd 'ip -json -detail link list dev bond21.10'
DEBUG/IFCONFIG returned (out):
[{"ifindex":24,"link":"bond21","ifname":"bond21.10","flags":["NO-CARRIER","BROADCAST","MULTICAST","UP"],"mtu":1500,"qdisc":"noqueue","master":"dmz","operstate":"LOWERLAYERDOWN","linkmode":"DEFAULT","group":"default","txqlen":1000,"link_type":"ether","address":"50:08:00:03:00:01","broadcast":"ff:ff:ff:ff:ff:ff","promiscuity":0,"min_mtu":0,"max_mtu":65535,"linkinfo":{"info_kind":"vlan","info_data":{"protocol":"802.1Q","id":10,"flags":["REORDER_HDR"]},"info_slave_kind":"vrf","info_slave_data":{"table":1010}},"inet6_addr_gen_mode":"none","num_tx_queues":1,"num_rx_queues":1,"gso_max_size":65536,"gso_max_segs":65535,"ifalias":"DMZ-10"}]
DEBUG/IFCONFIG cmd 'ip addr add fe80::5208:ff:fe03:1/64 dev bond21.10'
DEBUG/IFCONFIG cmd 'xdp_loader -d bond21.10 -U --auto-mode'
DEBUG/IFCONFIG returned (out):
INFO: xdp_link_detach() no curr XDP prog on ifindex:24
DEBUG/IFCONFIG cmd 'tc qdisc del dev bond21.10 parent ffff: 2>/dev/null'
DEBUG/IFCONFIG cmd 'tc qdisc del dev bond21.10 parent 1: 2>/dev/null'
DEBUG/IFCONFIG cmd 'ip link set dev bond21.10 up'
[edit]
vyos@r1#
```