Page MenuHomePhabricator

OpenVPN 'push' options with quotes
Closed, ResolvedPublicBUG

Description

The newer versions of OpenVPN require any push argument to be surrounded in quotes if it's more than one parameter that's part of the push.

As a result adding custom push options via set interfaces openvpn vtunX openvpn-option is completely broken since quotes are not allowed inside.

I would suggest one of two things, fixing the quote issue - or instead offering a set interfaces openvpn vtunX push-options <option>that will put the value inside of quotes when written out to the configuration.

so set interfaces openvpn vtunX push-option "keepalive 1 10" would result in a line in the openvpn config being push "keepalive 1 10"

Details

Difficulty level
Unknown (require assessment)
Version
vyos-1.3-rolling-201909030923
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible

Event Timeline

c-po claimed this task.Sep 4 2019, 7:22 AM
c-po added a comment.EditedSep 4 2019, 6:31 PM

You could use quoting like mentioned in T1129.

set interfaces openvpn vtun10 openvpn-option 'push &quot;keepalive 1 10&quot;'

This will add push "keepalive 1 10" to the corresponding openvpn config file

Issue is ONLY resolved in the 1.2 rolling series not the equueleus branch!

c-po closed this task as Resolved.Sep 4 2019, 6:35 PM
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.Sun, Oct 13, 3:05 PM