When changing description on an interface (e.g. set interfaces ethernet eth9 vif 2510 description "something"), commit results in a reset of all BGP sessions. Don't see the reason why this is neccessary?
- Difficulty level
- Normal (likely a few hours)
- VyOS 1.2-rolling-201911100217
- Why the issue appeared?
- Will be filled on close
- Is it a breaking change?
- Unspecified (possibly destroys the router)
- Issue type
- Bug (incorrect behavior)
There should be no reason the session is reset. This is an implementation "missdesign" by me when rewriting the ethernet interface. All interfaces are placed in admin down state on commit and will be placed in admin up state once the commit has run. and interface is not disabled.
This needs to be fixed. It also causes flapping switchports.
The offender is the call to vyos.ifconfig.set_flow_control() which triggers /sbin/ethtool --pause eth0 autoneg on tx on rx on. we should only change this if it is really necessary and not on every commit.
As asked on slack and to be clear. This issue was never present in any of the 1.2 LTS releases (crux branch) - not in 1.2.0, 1.2.1, 1.2.2, 1.2.3 and 1.2.4.
Thus bug was only introduced in the current development branch and is fixed.