Page MenuHomeVyOS Platform

SSTP RADIUS CLI accepts invalid values
Closed, ResolvedPublicBUG

Description

vyos@vyos# set service sstp-server authentication radius-server 1.1.1.1 fail-time f
vyos@vyos# set service sstp-server authentication radius-server 1.1.1.1 fail-time
Possible completions:
   <text>       If server does not responds mark it as unavailable for this time (seconds)
vyos@vyos# set service sstp-server authentication radius-server 1.1.1.1 req-limit f
vyos@vyos# set service sstp-server authentication radius-server 1.1.1.1 req-limit
Possible completions:
   <text>       Maximum number of simultaneous requests to server (default: unlimited)
vyos@vyos# set service sstp-server authentication radius-settings max-try f
vyos@vyos# set service sstp-server authentication radius-settings max-try
Possible completions:
   <text>       Maximum number of tries to send Access-Request/Accounting-Request queries
vyos@vyos# set service sstp-server authentication radius-settings timeout f
vyos@vyos# set service sstp-server authentication radius-settings timeout
Possible completions:
   <text>       Timeout to wait response from server (seconds)

The command indicates that a number is used thus it should only allow numbery by regex

Details

Difficulty level
Easy (less than an hour)
Version
1.3-rolling-202001311637
Why the issue appeared?
Design mistake
Is it a breaking change?
Stricter validation
Issue type
Bug (incorrect behavior)

Event Timeline

c-po created this task.
c-po changed Why the issue appeared? from Will be filled on close to Design mistake.
c-po changed the task status from Open to In progress.Mar 20 2020, 3:34 PM
c-po claimed this task.
c-po added a subscriber: Dmitry.
erkin set Issue type to Bug (incorrect behavior).Aug 31 2021, 5:47 PM