Page MenuHomeVyOS Platform

vpn l2tp remoteaccess require option broken
Closed, ResolvedPublicBUG


On the latest build, the following feature is broken

set vpn l2tp remote-access authentication require {value}

Setting this option should adjust the authentication options in the generated file at /run/accel-pppd/l2tp.conf
however, it looks like the template and is broken.

There are references on line 103 and 111 in to if conf.exists(['authentication', 'protocols']):
but as per template definition I think it should be
if conf.exists(['authentication', 'require']):

Also, the way the code is written it looks like it would always include auth_mschap_v2 with no way to disable it.


Difficulty level
Easy (less than an hour)
1.3 rolling
Why the issue appeared?
Implementation mistake
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Event Timeline

c-po triaged this task as High priority.
c-po changed Why the issue appeared? from Will be filled on close to Implementation mistake.
c-po changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.

Hi @drac, good catch and nice reverse engineering of our code.

Thank you for reporting this nasty one!

erkin set Issue type to Bug (incorrect behavior).Aug 29 2021, 12:28 PM
erkin removed a subscriber: Active contributors.