Page MenuHomeVyOS Platform

Unable to "format disk <new> like <old>"
Closed, ResolvedPublicBUG

Description

Commit https://github.com/vyos/vyos-1x/commit/deed5740137032f5512f21d167af9f362922c71d introduced the vyos.util.cmd() utility helper.
If an empty disk is formatted like an existing array disk, an error is thrown as the disk has no partition table. This makes cmd() fail as it raises an error if returncode != 0

Details

Difficulty level
Easy (less than an hour)
Version
1.3.0-epa1
Why the issue appeared?
Implementation mistake
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Event Timeline

c-po claimed this task.
c-po triaged this task as Normal priority.
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.
c-po moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.
c-po changed Why the issue appeared? from Will be filled on close to Implementation mistake.