Page MenuHomeVyOS Platform
Create Task
Maniphest T4170

Rename "policy ipv6-route" -> "policy route6"
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

In order to have a consistent looking CLI we should rename this CLI node.

There is

  • access-list and access-list6 (policy)
  • prefix-list and prefix-list6 (policy)
  • route and route6 (static routes)

Details

Difficulty level
Easy (less than an hour)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Config syntax change (migratable)
Issue type
Cosmetic issue (typos etc.)

Event Timeline

c-po claimed this task.Jan 11 2022, 9:15 AM
c-po created this task.
c-po closed this task as Resolved.Jan 11 2022, 9:29 AM
c-po triaged this task as Normal priority.
c-po changed Difficulty level from Unknown (require assessment) to Easy (less than an hour).
TMA added a subscriber: TMA.Jul 16 2022, 10:59 PM

Although this task is closed, I'd like to mention that after this change we are now defining rulesets with "policy route6" and binding them to interfaces with "interfaces ... policy ipv6-route". This seems to be more inconsistent than it has been before. Besides, although such changes are handled in a migration script for static configurations, they break automation scripts and require version specific fixes.

pasik added a subscriber: pasik.Jul 17 2022, 5:29 PM
c-po added a comment.EditedJul 18 2022, 7:41 AM

This seems to be more inconsistent than it has been before.

I totally agree - we need to fix this up, too. I somehow lost track of it.

c-po reopened this task as In progress.Jul 18 2022, 7:41 AM
c-po added a comment.Sep 12 2022, 7:16 AM

Already renamed:

vyos@vyos# set interfaces ethernet eth0 policy
Possible completions:
   route                IPv4 policy route ruleset for interface
   route6               IPv6 policy route ruleset for interface
c-po closed this task as Resolved.Sep 12 2022, 7:16 AM