Page MenuHomeVyOS Platform
Create Task
Maniphest T5401

Using load config restarts containers every time
Closed, InvalidPublicBUG
Actions

Description

Follow up to https://vyos.dev/T5365 and https://vyos.dev/T4870

When ever the container migration script is run it stops each container, saves it's image, deletes from directories, then imports the image, and starts it again. This ends up in an impact to the running applications because they have to stop/start every time.
The migration script's intention seems to be to just migrate any non-overlay image to be overlay. If this is the case, then the migration script should only perform those actions when the container is an image that has a non-overlay FS.

yzguy@test-R1# sudo podman ps
CONTAINER ID  IMAGE                              COMMAND               CREATED         STATUS             PORTS       NAMES
3f0e2eea05aa  docker.io/cloudflare/gortr:latest  -cache https://dn...  57 minutes ago  Up 57 minutes ago              gortr
[edit]
yzguy@test-R1# load /var/tmp/config.txt
Loading configuration from '/var/tmp/config.txt'
No configuration changes to commit.
[edit]
yzguy@test-R1# sudo podman ps
CONTAINER ID  IMAGE                              COMMAND               CREATED         STATUS             PORTS       NAMES
6a729c2e5ed8  docker.io/cloudflare/gortr:latest  -cache https://dn...  16 seconds ago  Up 16 seconds ago              gortr
[edit]
yzguy@test-R1# load /var/tmp/config.txt
Loading configuration from '/var/tmp/config.txt'
No configuration changes to commit.
[edit]
yzguy@test-R1# sudo podman ps
CONTAINER ID  IMAGE                              COMMAND               CREATED         STATUS             PORTS       NAMES
f887a92801ee  docker.io/cloudflare/gortr:latest  -cache https://dn...  14 seconds ago  Up 14 seconds ago              gortr
[edit]

Details

Difficulty level
Easy (less than an hour)
Version
1.4-rolling-202307161346
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Related Objects

Event Timeline

yzguy created this task.Jul 26 2023, 3:11 AM
yzguy added a comment.Jul 26 2023, 4:32 AM

https://github.com/vyos/vyos-1x/pull/2111

pasik added a subscriber: pasik.Jul 26 2023, 7:44 AM
Viacheslav closed this task as Invalid.Jul 28 2023, 10:31 AM
Viacheslav added a subscriber: Viacheslav.

You skip this warning and delte version number line

// Warning: Do not remove the following line
// vyos-config-version: "bgp@4:broadcast-relay@1:cluster@1:config-management@1:conntrack@3:conntrack-sync@2:container@1:dhcp-relay@2:dhcp-server@6:dhcpv6-server@1:dns-dynamic@1:dns-forwarding@4:firewall@10:flow-accounting@1:https@4:ids@1:interfaces@29:ipoe-server@1:ipsec@12:isis@3:l2tp@4:lldp@1:mdns@1:monitoring@1:nat@5:nat66@1:ntp@2:openconnect@2:ospf@2:policy@5:pppoe-server@6:pptp@2:qos@2:quagga@11:rip@1:rpki@1:salt@1:snmp@3:ssh@2:sstp@4:system@26:vrf@3:vrrp@4:vyos-accel-ppp@2:wanloadbalance@3:webproxy@2"
// Release version: 1.4-rolling-202307090317

It is not bug. If you remove it, it is expected behavior that migration is done every time.