Page MenuHomeVyOS Platform
Create Task
Maniphest T5692

NTP leap smear
Closed, ResolvedPublicENHANCEMENT
Actions

Description

VyOS is currently incompatible with the use of upstreams that provide leap smear, such as time.aws.com and time.google.com. This is because /run/chrony/chrony.conf contains:

# Determine when will the next leap second occur and what is the current offset
leapsectz right/UTC

It could also be good to support having the router handle leap smearing, using normal upstreams.

I propose introducing the config node leapsec under service ntp with the following possible values:

Details

Difficulty level
Normal (likely a few hours)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Improvement (missing useful functionality)

Event Timeline

aderouineau created this task.Oct 27 2023, 10:40 AM
pasik added a subscriber: pasik.Oct 27 2023, 10:52 AM
Apachez added a subscriber: Apachez.Oct 27 2023, 3:07 PM
Viacheslav triaged this task as Normal priority.Jan 20 2024, 1:39 PM
Viacheslav added a project: VyOS 1.5 Circinus.
Viacheslav added a subscriber: Viacheslav.

Any suggestion for CLI?

aderouineau added a comment.Jan 20 2024, 1:44 PM

I made a suggestion in the description. What do you think?

Viacheslav added a comment.Jan 20 2024, 1:48 PM
This comment was removed by Viacheslav.
c-po changed the task status from Open to In progress.Jan 21 2024, 7:06 AM
c-po claimed this task.
c-po added a comment.EditedJan 21 2024, 7:47 AM

https://github.com/vyos/vyos-1x/pull/2863

set service ntp leap-second [ignore|smear|system|timezone]

I decided to use the smear values from the example. If there is a need for individual configuration we can add it.

c-po added a project: VyOS 1.4 Sagitta.Jan 21 2024, 7:47 AM
c-po closed this task as Resolved.Jan 21 2024, 7:42 PM
c-po moved this task from Need Triage to Finished on the VyOS 1.5 Circinus board.
c-po moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.