Page MenuHomeVyOS Platform

dhcp server - If failover is defined, range is required
Closed, ResolvedPublicBUG

Description

If enable-failover is defined for a subnet, then range is also mandatory.
If range is not defined, the error is not caught properly, and commit fails.

Step to reproduce error:

yos@136# compare commands 
set service dhcp-server failover name 'FOO'
set service dhcp-server failover remote '198.51.100.2'
set service dhcp-server failover source-address '198.51.100.1'
set service dhcp-server failover status 'primary'
set service dhcp-server listen-address '198.51.100.1'
set service dhcp-server shared-network-name TEST-NET subnet 198.51.100.0/24 default-router '198.51.100.1'
set service dhcp-server shared-network-name TEST-NET subnet 198.51.100.0/24 'enable-failover'
set service dhcp-server shared-network-name TEST-NET subnet 198.51.100.0/24 static-mapping customer1 ip-address '198.51.100.55'
set service dhcp-server shared-network-name TEST-NET subnet 198.51.100.0/24 static-mapping customer1 mac-address '00:11:22:33:44:55'
[edit]
vyos@136# commit
[ service dhcp-server ]
Configuration file errors encountered - check your options!

[[service dhcp-server]] failed
Commit failed
[edit]
vyos@136#

Details

Difficulty level
Unknown (require assessment)
Version
vyos-1.3.6
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)