Change Details

SUMMARY You cannot change serial console settings from a serial console, as the script will restart the serial gettys as part of the commit process, throwing you out from your session. STEPS TO REPRODUCE # Login to VyOS through a serial console and enter configure mode # Run the following commands: ``` set system name-server 8.8.8.8 # or whatever set command you like, really set system console device ttyS0 speed 9600 commit ``` OBSERVED RESULT You get thrown out to the login prompt. When you log back in, you sadly discover that none of your commands have made it to the running configuration. Also note that even if you change the settings from a VT, any admins connected to a serial console would be thrown out and their changes discarded. EXPECTED RESULT The router should stop playing shenanigans on the admin, and just apply the requested configuration like a good boy :-) SOFTWARE/OS VERSIONS VyOS 1.4-rolling-202102040221 ADDITIONAL INFORMATION The problem is that the script src/conf_mode/system_console.py unconditionally. It should rather check whether an user is connected to the TTY before restarting it, I attach a patch to do that: {F1144281} The ideal solution, I guess, would be some daemon to apply the settings when the user disconnects, but that's a bit overengineered, Fixing the commit failure is mostly enough for me.

SUMMARY You cannot change serial console settings from a serial console, as the script will restart the serial gettys as part of the commit process, throwing you out from your session. STEPS TO REPRODUCE # Login to VyOS through a serial console and enter configure mode # Run the following commands: ``` set system name-server 8.8.8.8 # or whatever set command you like, really set system console device ttyS0 speed 9600 commit ``` OBSERVED RESULT You get thrown out to the login prompt. When you log back in, you sadly discover that none of your commands have made it to the running configuration. Also note that even if you change the settings from a VT, any admins connected to a serial console would be thrown out and their changes discarded. EXPECTED RESULT The router should stop playing shenanigans on the admin, and just apply the requested configuration like a good boy :-) SOFTWARE/OS VERSIONS VyOS 1.4-rolling-202102040221 ADDITIONAL INFORMATION The problem is that the script `src/conf_mode/system_console.py` unconditionally. It should rather check whether an user is connected to the TTY before restarting it, I attach a patch to do that: {F1144281} The ideal solution, I guess, would be some daemon to apply the settings when the user disconnects, but that's a bit overengineered, Fixing the commit failure is mostly enough for me.

SUMMARY You cannot change serial console settings from a serial console, as the script will restart the serial gettys as part of the commit process, throwing you out from your session. STEPS TO REPRODUCE # Login to VyOS through a serial console and enter configure mode # Run the following commands: ``` set system name-server 8.8.8.8 # or whatever set command you like, really set system console device ttyS0 speed 9600 commit ``` OBSERVED RESULT You get thrown out to the login prompt. When you log back in, you sadly discover that none of your commands have made it to the running configuration. Also note that even if you change the settings from a VT, any admins connected to a serial console would be thrown out and their changes discarded. EXPECTED RESULT The router should stop playing shenanigans on the admin, and just apply the requested configuration like a good boy :-) SOFTWARE/OS VERSIONS VyOS 1.4-rolling-202102040221 ADDITIONAL INFORMATION The problem is that the script `src/conf_mode/system_console.py` unconditionally. It should rather check whether an user is connected to the TTY before restarting it, I attach a patch to do that: {F1144281} The ideal solution, I guess, would be some daemon to apply the settings when the user disconnects, but that's a bit overengineered, Fixing the commit failure is mostly enough for me.