Change Details

This task address the simplest case of T5660: trivial redundancies arising from the need to define dependencies in the general case --- the graph defined by https://github.com/vyos/vyos-1x/blob/current/data/config-mode-dependencies/vyos-1x.json ---and the use of dependencies in specific cases that may set a dependency multiple times. A simple example is in https://github.com/vyos/vyos-1x/blob/current/src/conf_mode/firewall.py#L137-L145 dependencies are set in the case of 'group-resync', and always set for 'conntrack'. If one has a config triggering both, the resulting dependency list is: `set_dependents: caller firewall, dependents ['conntrack', 'nat', 'policy-route']` <-- `from set_dependents('group_resync', conf)` `set_dependents: caller firewall, dependents ['conntrack', 'nat', 'policy-route', 'conntrack']` <-- redundancy added from `set_dependents('conntrack', conf)` It is preferable that the author of a config-mode script not try to manage dependency logic with script logic, but rather that the resulting list is dynamically pruned before being called, resulting in: `call_dependents: caller firewall, dependents ['nat', 'policy-route', 'conntrack']` The remaining sources of redundancies will be detailed in the parent task T5660.

This task address the simplest case of T5660: trivial redundancies arising from the need to define dependencies in the general case --- the graph defined by https://github.com/vyos/vyos-1x/blob/current/data/config-mode-dependencies/vyos-1x.json ---and the use of dependencies for a specific config, which may trigger multiple overlapping conditions. A simple example is in https://github.com/vyos/vyos-1x/blob/current/src/conf_mode/firewall.py#L137-L145 dependencies are set in the case of 'group-resync', and always set for 'conntrack'. If one has a config triggering both, the resulting dependency list is: `set_dependents: caller firewall, dependents ['conntrack', 'nat', 'policy-route']` <-- `from set_dependents('group_resync', conf)` `set_dependents: caller firewall, dependents ['conntrack', 'nat', 'policy-route', 'conntrack']` <-- redundancy added from `set_dependents('conntrack', conf)` It is preferable that the author of a config-mode script not try to manage dependency logic with script logic, but rather that the resulting list is dynamically pruned before being called, resulting in: `call_dependents: caller firewall, dependents ['nat', 'policy-route', 'conntrack']` The remaining sources of redundancies will be detailed in the parent task T5660.

This task address the simplest case of T5660: trivial redundancies arising from the need to define dependencies in the general case --- the graph defined by https://github.com/vyos/vyos-1x/blob/current/data/config-mode-dependencies/vyos-1x.json ---and the use of dependencies infor a specific cases thatonfig, which may set a dependency multiple timestrigger multiple overlapping conditions. A simple example is in https://github.com/vyos/vyos-1x/blob/current/src/conf_mode/firewall.py#L137-L145 dependencies are set in the case of 'group-resync', and always set for 'conntrack'. If one has a config triggering both, the resulting dependency list is: `set_dependents: caller firewall, dependents ['conntrack', 'nat', 'policy-route']` <-- `from set_dependents('group_resync', conf)` `set_dependents: caller firewall, dependents ['conntrack', 'nat', 'policy-route', 'conntrack']` <-- redundancy added from `set_dependents('conntrack', conf)` It is preferable that the author of a config-mode script not try to manage dependency logic with script logic, but rather that the resulting list is dynamically pruned before being called, resulting in: `call_dependents: caller firewall, dependents ['nat', 'policy-route', 'conntrack']` The remaining sources of redundancies will be detailed in the parent task T5660.