Page MenuHomeVyOS Platform
Create Task
Maniphest T1123

Inconsistency in community-list naming validation
Closed, ResolvedPublicBUG
Actions

Description

There appears to be some inconsistency in the name validation for community-lists.

It is possible to create a community-list with a textual name. They can then be used to filter on prefixes using show ipv6 bgp community-list but it is not possible to use it in a route-map rule.

Example community-list configuration that is accepted:

community-list rpki-invalid {
    rule 10 {
        action permit
        regex 60927:666
    }
}

But adding it to a route-map rule is not possible, this causes the following error:

vyos@r1# set policy route-map test-route-map rule 1 set comm-list comm-list rpki-invalid

  "rpki-invalid" is not a valid value of type "u32"
  Value validation failed
  Set failed

[edit]

Details

Difficulty level
Unknown (require assessment)
Version
1.2.0-rc11
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Related Objects

Event Timeline

m.cremers created this task.Dec 20 2018, 11:58 AM
pasik added a subscriber: pasik.Dec 20 2018, 12:24 PM
syncer assigned this task to dmbaturin.Dec 21 2018, 10:23 AM
syncer triaged this task as Normal priority.
syncer edited projects, added VyOS 1.3 Equuleus; removed VyOS 1.2 Crux.
olofl added a subscriber: olofl.Oct 4 2019, 8:04 AM

Any reason extcommunity-list and community-list doesnt support the same naming scheme?

vyos@vyos-gns3# set policy community-list T_EST description hello
[edit]
vyos@vyos-gns3# set policy extcommunity-list T_EST description world

  Should be alphanumeric name
  Value validation failed
  Set failed
Viacheslav added a subscriber: Viacheslav.Jul 27 2020, 4:13 PM

This is an FRR limitation.
FRR allows you only to delete the comm-list.

r1-roll# conf t
r1-roll(config)# bgp community-list expanded rpki-invalid permit 60927:666
r1-roll(config)# route-map test-route-map permit 10

r1-roll(config-route-map)# set comm-list rpki-invalid 
% Command incomplete: set comm-list rpki-invalid

r1-roll(config-route-map)# set comm-list rpki-invalid 
  delete  Delete matching communities
dmbaturin added a project: test.Jul 29 2021, 12:00 PM
dmbaturin set Is it a breaking change? to Unspecified (possibly destroys the router).
Viacheslav closed this task as Resolved.EditedJul 30 2021, 12:47 PM

The original issue with the name ( type "u32") was solved.
I'll create a separate task for comm-list bug that can't be used without the "delete" option. (T3712)

[email protected]# set policy community-list rpki-invalid rule 10 action permit
[edit]
[email protected]# set policy community-list rpki-invalid rule 10 regex 60927:666
[edit]
[email protected]# 
[edit]
[email protected]# set policy route-map test-rmap rule 10 action permit
[edit]
[email protected]# set policy route-map test-rmap rule 10 set comm-list comm-list rpki-invalid
[edit]
[email protected]# set policy route-map test-rmap rule 10 set comm-list delete
[edit]
[email protected]# 
[edit]
[email protected]# commit
[edit]
[email protected]#
erkin set Issue type to Bug (incorrect behavior).Aug 31 2021, 7:00 PM
dmbaturin edited projects, added VyOS 1.3 Equuleus (1.3.0-epa1); removed VyOS 1.3 Equuleus.Sep 11 2021, 1:52 AM