User Details
- User Since
- Feb 7 2016, 4:09 PM (206 w, 2 d)
- Roles
- Administrator
Thu, Jan 16
We took other steps that allows us to take the image back to a manageable size, and this task lost its immediate relevance.
Thu, Jan 9
Thu, Jan 2
Dec 10 2019
Good point! PR merged.
Dec 5 2019
The runtime errors are fixed by the above commit.
I agree. If it works in a way that is consistent with what the command promises, let's use it.
Nov 19 2019
Nov 17 2019
Frankly, I can see why FRR doesn't want it to be modifiable at runtime. If you are decreasing the number, it would force a big routing table rebuild, and tracking whether the user increased or decreased it to decide if command should be allowed or not is more trouble than it's worth.
The original client-id has been cherry-picked into crux, but the vendor-class commands are not backportable since they rely on the new interface scripts.
Also in crux now.
Cherr-picked into crux.
Nov 16 2019
Nov 14 2019
I agree. Users should be able to change the port independently from the address.
Nov 13 2019
Nov 5 2019
Oct 27 2019
Oct 24 2019
Oct 22 2019
Oct 21 2019
Oct 19 2019
Oct 15 2019
Myself I'm in favor of maintaining a fork and asking people to install it. We can add a version check to the ./configure script to make sure it stops and tells the user what to do if the version is not patched.
Oct 1 2019
Sep 30 2019
Sep 24 2019
Sep 17 2019
Sep 13 2019
Sep 11 2019
Sep 9 2019
Sep 6 2019
Works in the latest image for me.
It should have been fixed by https://github.com/vyos/vyos-1x/commit/ff05e2a90edf8af5d7b8ad5c69cae2dd40af2c8d It works for me in post-Sep 01 images and I don't see the error in the latest one, but I'm not sure why it would appear in the Sep 01 image if the commit is from Aug 30.
@nirmal The full fix is a bit more complicated. There are two cases: when it's called from conf mode at commit time, it needs to use the value from the proposed config (that's returnValue). However, in op mode, it also re-generates the config, so your fix would make the send dhcp6.client-id option disappear from the config when a user runs renew dhcpv6 interface .... A full fix needs to handle both cases and use returnEffectiveValue in op mode.
>>> s="""
... foo {
... bar {
... baz quux foo
... }
... }
... """
>>> import vyos.configtree
>>> c = vyos.configtree.ConfigTree(s)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/python3/dist-packages/vyos/configtree.py", line 167, in __init__
raise ValueError("Failed to parse config: {0}".format(msg))
ValueError: Failed to parse config: Syntax error on line 4, character 14: Invalid syntax.It was indeed a bug, caused by the same issue as all other subtasks of T1598: lack of proper synchronization.
If it re-appears, please reopen of course.
Disappearing entries should no longer be a problem, but if it re-appears due to a missing case, please reopen.