User Details
- User Since
- Feb 7 2016, 4:09 PM (188 w, 2 d)
- Roles
- Administrator
Yesterday
Fri, Sep 13
Wed, Sep 11
Mon, Sep 9
Fri, Sep 6
Works in the latest image for me.
It should have been fixed by https://github.com/vyos/vyos-1x/commit/ff05e2a90edf8af5d7b8ad5c69cae2dd40af2c8d It works for me in post-Sep 01 images and I don't see the error in the latest one, but I'm not sure why it would appear in the Sep 01 image if the commit is from Aug 30.
@nirmal The full fix is a bit more complicated. There are two cases: when it's called from conf mode at commit time, it needs to use the value from the proposed config (that's returnValue). However, in op mode, it also re-generates the config, so your fix would make the send dhcp6.client-id option disappear from the config when a user runs renew dhcpv6 interface .... A full fix needs to handle both cases and use returnEffectiveValue in op mode.
>>> s="""
... foo {
... bar {
... baz quux foo
... }
... }
... """
>>> import vyos.configtree
>>> c = vyos.configtree.ConfigTree(s)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/python3/dist-packages/vyos/configtree.py", line 167, in __init__
raise ValueError("Failed to parse config: {0}".format(msg))
ValueError: Failed to parse config: Syntax error on line 4, character 14: Invalid syntax.It was indeed a bug, caused by the same issue as all other subtasks of T1598: lack of proper synchronization.
If it re-appears, please reopen of course.
Disappearing entries should no longer be a problem, but if it re-appears due to a missing case, please reopen.
Thu, Sep 5
Sun, Sep 1
As a stopgap measure that allows old config to load, I've made the script cap it at 100:
Sat, Aug 31
Cherry-picked into crux.
@rgrant I've cherry-picked it into Crux, will be in the 1.2.3 release soon.
Cherry-picked into crux.
Cherry-picked into crux.
Cherry-picked into crux.
CHerry-picked into crux.
Cherry-picked into crux.
Cherry-picked into crux.
Imported 2.0.17 into crux.
Fri, Aug 30
Actually, there are already run monitor traffic interface $intf commands and they work fine in 1.2.3.
Thu, Aug 29
Tue, Aug 27
If it reappears, feel free to reopen.
Tue, Aug 20
Aug 18 2019
@alkersan Looks good, thanks!
Aug 16 2019
I think we should use it as a chance to improve it. The nesting does not do anyone any favors, tcpdump applies to all interface type, so a single level "monitor interface $intf" command is going to be easier to use.
Aug 9 2019
Fixed. Should in the next nightly build.
Jul 29 2019
I've fixed the setup and re-populated the equuleus repo.
Jul 25 2019
I could reproduce it. The DHCP client script overwrites those entries.
Jul 18 2019
We cannot backport anything that introduces a syntax or behaviour change, much less if it may possibly need a migration script. ;)
@zsdc I've included keepalived 2.0.17 in the rolling release repo and it will be in tomorrow's nightly build. Please test.
I would be wary of including it in Crux, since it's a behaviour change.
Jul 16 2019
This is really a broken abstraction. There is no separate namespaces for IPv4 and IPv6 groups in IPset.
We'll have to autoprefix the groups or similar, if we want it to work that way.