Page MenuHomePhabricator

DHCP relay relay-agents-packets is dysfunctional
Closed, ResolvedPublicBUG

Description

Hello!
In current versions of VyOS relay-agents-packets in DHCP relay is dysfunctional due to misconfiguration.
If option is set, configuration script only add -m [value]to dhcrelay command:

if conf.exists('relay-agents-packets'):
    pkt = '-m ' + conf.return_value('relay-agents-packets')
    relay['options'].append(pkt)

(source)

But, this is not enough. According to Debian manual page, we also need to add -a key.

This is confirming also by dhcrelay source. Default value of add_agent_options is zero and can be changed only by -a key. And if add_agent_options is not 1, then whole add_relay_agent_options function, where performing processing of relayed packets with Relay Agent Information option, is skipped.

So, we need to add also -a option to command if relay-agents-packets is configured.

Details

Difficulty level
Easy (less than an hour)
Version
1.2.0-LTS, 1.2.0-rolling+201902080337
Why the issue appeared?
Will be filled on close
zsdc created this task.Feb 8 2019, 11:43 AM
syncer assigned this task to c-po.Feb 8 2019, 11:49 AM
syncer triaged this task as Normal priority.
syncer edited projects, added VyOS 1.3 Equuleus; removed VyOS 1.2 Crux.
pasik added a subscriber: pasik.Feb 8 2019, 12:57 PM
c-po changed the task status from Open to Needs testing.Feb 8 2019, 5:54 PM
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.
c-po moved this task from Need Triage to VyOS 1.2.1 on the VyOS 1.2 Crux board.
c-po edited projects, added VyOS 1.2 Crux (VyOS 1.2.1); removed VyOS 1.2 Crux.
c-po moved this task from Needs Triage to Finished on the VyOS 1.2 Crux (VyOS 1.2.1) board.

No further complaints - seems to be resolved.

c-po closed this task as Resolved.Feb 25 2019, 5:26 PM