Page MenuHomePhabricator

LLDP shows "VyOS unknown" instead of "VyOS"
Closed, ResolvedPublicBUG

Description

vyos@vyos# run show lldp neighbors
Capability Codes: R - Router, B - Bridge, W - Wlan r - Repeater, S - Station
                  D - Docsis, T - Telephone, O - Other
Device ID    Local  Proto  Cap   Platform             Port ID
---------    -----  -----  ---   --------             -------
CR2          eth5   LLDP   R     VyOS unknown         eth5
CSW1         eth0   LLDP   BR    Cisco IOS Software,  Gi1/0/7

For a Cisco device it shows only IOS, why do we need to show additional information on VyOS? Shouldnt be the following be sufficient?

vyos@vyos# run show lldp neighbors
Capability Codes: R - Router, B - Bridge, W - Wlan r - Repeater, S - Station
                  D - Docsis, T - Telephone, O - Other
Device ID    Local  Proto  Cap   Platform             Port ID
---------    -----  -----  ---   --------             -------
CR2          eth5   LLDP   R     VyOS                 eth5
CSW1         eth0   LLDP   BR    Cisco IOS Software,  Gi1/0/7

Details

Difficulty level
Easy (less than an hour)
Version
1.2.3
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible

Event Timeline

c-po created this task.Sun, Dec 1, 8:21 PM
runar added a subscriber: runar.Sun, Dec 1, 9:28 PM

as far as i know the content of the platform field is the first characters from sysdescr (20 characters?). on one of my devices this is

System Description:
Cisco IOS Software, C2960 Software (C2960-LANBASEK9-M), Version 15.0(2)SE8, RELEASE SOFTWARE (fc1)
Technical Support: http://www.cisco.com/techsupport
Copyright (c) 1986-2015 by Cisco Systems, Inc.
Compiled Thu 14-May-15 02:39 by prod_rel_team

This is cut down to Cisco IOS Software, (20 first characters).

On a VyOS device the content of sysdescr is

System Description:
VyOS unknown

The unknown is coming from /opt/vyatta/sbin/vyatta-config-lldp.pl it should show the version number, and the error looks like a syntax change in /opt/vyatta/etc/version where the lldp script is looking for Description: .* but the vyos syntax of this file is Version: 1.2.3. I Think the easiest fix for this is to change the regex for parsing /opt/vyatta/etc/version.

Dmitry added a subscriber: Dmitry.Mon, Dec 2, 6:10 AM

In rolling this was fixed T1204, we need add this to crux.

c-po closed this task as Resolved.Mon, Dec 2, 7:03 AM
c-po claimed this task.
c-po edited projects, added VyOS 1.2 Crux (VyOS 1.2.4); removed VyOS 1.2 Crux.
c-po moved this task from Needs Triage to Finished on the VyOS 1.2 Crux (VyOS 1.2.4) board.
pasik added a subscriber: pasik.Mon, Dec 2, 9:24 AM