Page MenuHomePhabricator

PPPoE server: maintenance mode
Backport candidate, Requires assessmentPublicFEATURE REQUEST

Description

When we have large infrastructure (like ISP), and we want to make a tech works on ONE of BRAS, we need possibility change server to maintenance mode. We can do this if send pppoe daemon command shutdown soft. PPPoE daemon will continue serv already connected clients, but deny new connections. When last client disconnected - PPPoE daemon goes down.

Details

Difficulty level
Unknown (require assessment)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible

Event Timeline

Dmitry created this task.Wed, Jan 8, 8:14 PM
Dmitry added a comment.Wed, Jan 8, 9:41 PM

https://github.com/vyos/vyos-1x/pull/200
adding CLI commands

vyos@BRAS:~$ set pppoe-server maintenance-mode 
Possible completions:
  cancel        Cancel maintenance mode
  enable        Deny new connections and stop to serve pppoe after disconnect last session
Dmitry claimed this task.Thu, Jan 9, 8:27 AM
Dmitry changed the task status from Open to Needs testing.Thu, Jan 9, 8:41 AM
pasik added a subscriber: pasik.Sat, Jan 11, 11:00 AM
Dmitry changed the task status from Needs testing to Backport candidate.Wed, Jan 15, 10:39 AM
Dmitry added a project: VyOS 1.3 Equuleus.

Works in 1.3-rolling-202001150217, propose cherry-pick in to crux.

c-po added a subscriber: c-po.EditedMon, Jan 20, 12:39 PM

I like the idea, but unfortunately I do not understand why there needs to be a cancel node? If maintenance mode is not activated shouldnt this be enough?

Why not sent shutdown cancel if maintenance mode node is delete if it was active before? conf.return_effective_*() to check if it was active. This would simplify CLI - which is always the best.

Just my two cents