Page MenuHomeVyOS Platform
Create Task
Maniphest T1957

PPPoE server: maintenance mode
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

When we have large infrastructure (like ISP), and we want to make a tech works on ONE of BRAS, we need possibility change server to maintenance mode. We can do this if send pppoe daemon command shutdown soft. PPPoE daemon will continue serv already connected clients, but deny new connections. When last client disconnected - PPPoE daemon goes down.

Details

Version
-
Is it a breaking change?
Unspecified (possibly destroys the router)

Related Objects

Event Timeline

Unknown Object (User) created this task.Jan 8 2020, 8:14 PM
Unknown Object (User) added a comment.Jan 8 2020, 9:41 PM

https://github.com/vyos/vyos-1x/pull/200
adding CLI commands

vyos@BRAS:~$ set pppoe-server maintenance-mode 
Possible completions:
  cancel        Cancel maintenance mode
  enable        Deny new connections and stop to serve pppoe after disconnect last session
Unknown Object (User) claimed this task.Jan 9 2020, 8:27 AM
Restricted Repository Identity mentioned this in rVYOSONEX7a7eb881e51c: Merge pull request #200 from DmitriyEshenko/pppoe-maintenance.Jan 9 2020, 8:36 AM
Unknown Object (User) changed the task status from Open to Needs testing.Jan 9 2020, 8:41 AM
pasik subscribed.Jan 11 2020, 11:00 AM
Unknown Object (User) closed this task as Unknown Status.Jan 15 2020, 10:39 AM
Unknown Object (User) added a project: VyOS 1.3 Equuleus.

Works in 1.3-rolling-202001150217, propose cherry-pick in to crux.

c-po subscribed.EditedJan 20 2020, 12:39 PM

I like the idea, but unfortunately I do not understand why there needs to be a cancel node? If maintenance mode is not activated shouldnt this be enough?

Why not sent shutdown cancel if maintenance mode node is delete if it was active before? conf.return_effective_*() to check if it was active. This would simplify CLI - which is always the best.

Just my two cents

syncer triaged this task as Normal priority.Mar 28 2020, 12:09 PM
syncer edited projects, added VyOS 1.2 Crux (VyOS 1.2.6); removed VyOS 1.2 Crux.
syncer moved this task from Need Triage to Backport Candidates on the VyOS 1.3 Equuleus board.
Unknown Object (User) added a comment.Mar 28 2020, 12:13 PM

@c-po this is operation commands, as I understand you propose to write py script with return_effective_ , correct?

syncer edited projects, added VyOS 1.2 Crux (VyOS 1.2.7); removed VyOS 1.2 Crux (VyOS 1.2.6).Sep 9 2020, 5:34 PM
jack9603301 subscribed.Sep 9 2020, 5:39 PM
dmbaturin moved this task from Needs Triage to Finished on the VyOS 1.2 Crux (VyOS 1.2.7) board.Jan 24 2021, 5:17 PM
dmbaturin mentioned this in rVYOSONEXb3be006223dc: pppoe-server: T1957: Implementation CLI commands for maintenance mode.Jan 24 2021, 6:03 PM
dmbaturin changed the task status from Unknown Status to Resolved.Feb 11 2021, 5:59 AM
c-po moved this task from Backport Candidates to Finished on the VyOS 1.3 Equuleus board.Mar 18 2021, 4:28 PM
dmbaturin removed a project: VyOS 1.3 Equuleus.Sep 10 2021, 2:40 PM