Page MenuHomeVyOS Platform

commit(-confirm) with illegal config does not stop the commit
Open, Requires assessmentPublicBUG

Description

If you commit illegal config with commit(-confirm) the config seems to be still commited.
Expected behviour would be that if commit validation fails the commit process is broken.

georg@gw-as# set zone-policy zone illegal interface eth3
[edit]
georg@gw-as# commit
[ zone-policy zone illegal interface eth3 ]
interface eth3 does not exist on system

[edit]

georg@gw-as# set zone-policy zone illegal interface eth4
[edit]
georg@gw-as# commit-confirm
commit confirm will be automatically reboot in 10 minutes unless confirmed
Proceed? [confirm][y]
[ zone-policy zone illegal interface eth4 ]
interface eth4 does not exist on system

georg@gw-as# run show configuration | match eth4

interface eth4

georg@gw-as# set zone-policy zone illegal interface eth5
[edit]
georg@gw-as# commit-confirm
Another confirm is pending
[ zone-policy zone illegal interface eth5 ]
interface eth5 does not exist on system

georg@gw-as# run show configuration | match eth5

interface eth5

[edit]

georg@gw-as# run show zone-policy zone illegal

Name: illegal

Interfaces: eth2 eth3 eth4 eth5

From Zone:

name                                    firewall                                
----                                    --------

Details

Difficulty level
Unknown (require assessment)
Version
1.3-rolling-202004050909
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)

Event Timeline

teadur created this task.Apr 5 2020, 4:21 PM