Page MenuHomeVyOS Platform

Cache config string during commit
Open, Requires assessmentPublic

Description

During commit, vyos-1x calls to the backend for every call to Config, hence in every conf_mode script. As no changes to the config should occur once the commit stage begins, these calls may be spared by caching the config string. A very low-brow caching is linked below, and may be considered as a temporary measure until a proper caching mechanism is completed. The subtlety which make the low-brow approach awkward is the need to communicate state between the backend and the vyos-1x config framework without the communication channel in place. Its effect can be seen by comparing the time taken to add 100 dummy interfaces:

without caching:

real 0m37.466s
user 0m17.708s
sys 0m7.440s

with caching:

real 0m19.347s
user 0m12.524s
sys 0m2.708s

Details

Difficulty level
Unknown (require assessment)
Version
vyos-1.3
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)