Page MenuHomeVyOS Platform
Create Task
Maniphest T2892

Remove command: "set firewall options interface <interface> disable"
Closed, WontfixPublic
Actions

Description

The command

set firewall options interface ethX disable

was created to disable MSS clamping for an interface, but it might look a bit confusing because it says nothing about MSS clamping. And also redundant, because you could get the same by entering

delete firewall options interface ethX adjust-mss

So it seems it can be removed.

Details

Difficulty level
Unknown (require assessment)
Version
1.2.x ; 1.3
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Config syntax change (migratable)
Issue type
Improvement (missing useful functionality)

Related Objects

Event Timeline

Unknown Object (User) triaged this task as Low priority.Sep 17 2020, 10:41 AM
Unknown Object (User) created this task.
pasik added a subscriber: pasik.Sep 17 2020, 6:02 PM
dmbaturin added projects: VyOS 1.3 Equuleus, VyOS 1.4 Sagitta.May 29 2021, 7:53 AM
dmbaturin changed Is it a breaking change? from Unspecified (possibly destroys the router) to Config syntax change (migratable).
Viacheslav added a subscriber: Viacheslav.Jun 22 2021, 1:03 PM

I don't see the reason to delete the "disable" option, as it uses for adjust-mss and adjust-mss6.
And you need temporarily disable it.

erkin set Issue type to Improvement (missing useful functionality).Aug 29 2021, 1:04 PM
erkin removed a subscriber: Active contributors.
c-po added a subscriber: c-po.Nov 1 2021, 5:30 PM

We keep this in 1.3 as the CLI is fixed - it was removed in the 1.4 development cycle with T3090

c-po closed this task as Wontfix.Nov 1 2021, 5:30 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.Nov 6 2021, 11:42 AM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 29 2022, 12:16 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.