Page MenuHomeVyOS Platform

Ethtool CLI Integration
Open, Requires assessmentPublicFEATURE REQUEST

Description

I was wondering if it'd be possible to implement ethtool settings in the CLI (and maybe even show commands); this would help massively given the number of manufacturers who provide inappropriate default settings (ex: Intel NICs tend to eat LLDP messages (as can be seen in T2287).
Here's what I believe would work well:
Configure Mode:

set interfaces ethernet eth0 ethtool priv-flag <flag> <enable|disable>
set interfaces ethernet eth0 ethtool feature <feature> <enable|disable>

Details

Difficulty level
Unknown (require assessment)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible

Event Timeline

What operational mode information do you require that are yet not displayed by:

  • show interfaces ethernet eth0 physical
  • show interfaces ethernet eth0 physical offload
  • show interfaces ethernet eth0 transceiver

For configuration mode we only support setting of various offloading mechanisms - which part is especially missing?

Adding a general ethtool node to the CLI makes no sense to me as this only acts as proxy, if you really need this, you can use /config/scripts/vyos-postconfig-bootup.script for manual startup settings.
Also ethtool nodes requires the implementation of subnodes which enable/disable your feature, thus if you can describe what's missing, we might find a better place in the already existing CLI.

c-po removed c-po as the assignee of this task.Sun, Feb 21, 6:54 PM