I was wondering if it'd be possible to implement ethtool settings in the CLI (and maybe even show commands); this would help massively given the number of manufacturers who provide inappropriate default settings (ex: Intel NICs tend to eat LLDP messages (as can be seen in T2287).
Here's what I believe would work well:
Configure Mode:
set interfaces ethernet eth0 ethtool priv-flag <flag> <enable|disable> set interfaces ethernet eth0 ethtool feature <feature> <enable|disable>
What operational mode information do you require that are yet not displayed by:
For configuration mode we only support setting of various offloading mechanisms - which part is especially missing?
Adding a general ethtool node to the CLI makes no sense to me as this only acts as proxy, if you really need this, you can use /config/scripts/vyos-postconfig-bootup.script for manual startup settings.
Also ethtool nodes requires the implementation of subnodes which enable/disable your feature, thus if you can describe what's missing, we might find a better place in the already existing CLI.
Create a new feature request if you need some specific feature/features
For example, for offloads we use:
vyos@r4# set interfaces ethernet eth0 offload Possible completions: gro Enable Generic Receive Offload gso Enable Generic Segmentation Offload hw-tc-offload Enable Hardware Flow Offload lro Enable Large Receive Offload rfs Enable Receive Flow Steering rps Enable Receive Packet Steering sg Enable Scatter-Gather tso Enable TCP Segmentation Offloading
We can add new features in the same way.