Page MenuHomeVyOS Platform

RPKI: dashes in hostnames are replaced with underscores when rendering the FRR config
Closed, ResolvedPublicBUG

Description

When configuring rpki with a hostname, any dashes in the FQDN are replaced with underscores when the config is applied.

set protocols rpki cache rtr-ham1.mhl-lab.net port '3323'
set protocols rpki cache rtr-ham1.mhl-lab.net preference '2'

becomes

rpki
  rpki polling_period 300 
  rpki cache rtr_ham1.mhl_lab.net 3323 preference 2
  exit

Details

Difficulty level
Unknown (require assessment)
Version
1.3-beta-202102090443
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Event Timeline

@mpueschel will be fixed in the next rolling 1.4 release, after 2021-03-10
Can you check it out?

The fix submitted is not working as intended.. both - and _ are allowed characters in dns, so this this break dns names with _ in them. Before anyone complains, rfc952 that sets the name definition disallows use of underscore in hostnames and top level domains, not subdomains where the use is fully valid

Viacheslav claimed this task.

Fixed VyOS 1.3-beta-202103110443

set protocols rpki cache rtr-ham1.mhl-lab.net port '3323'
set protocols rpki cache rtr-ham1.mhl-lab.net preference '2'

Frr

rpki
  rpki polling_period 300
  rpki cache rtr-ham1.mhl-lab.net 3323 preference 2
  exit

@Viacheslav can confirm, issue is fixed in VyOS 1.3-beta-202103110443

SrividyaA set Issue type to Bug (incorrect behavior).Aug 31 2021, 2:14 PM