Page MenuHomeVyOS Platform

Please implement bgp graceful-shutdown
Closed, ResolvedPublic

Description

hi,

on planning some maintenance in our plattfom I stumbled over bgp graceful-shutdown. Seems that frr can do it but it is not implemented in Vyos:

https://docs.frrouting.org/en/latest/bgp.html#clicmd-bgpgraceful-shutdown
https://bgpfilterguide.nlnog.net/guides/graceful_shutdown/#frr-vtysh

Details

Difficulty level
Unknown (require assessment)
Version
1.2.7, 1,3 , 1.4
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)

Event Timeline

rherold created this object in space S1 VyOS Public.

It is implemented in VyOS 1.4

cpo@LR1.wue3# show protocols bgp
 local-as 100
 parameters {
     graceful-shutdown
 }

This is a new feature in VyOS 1.4.

As per policy we try to not add new features to old Vyatta code. In this example it is even a bit more complex as the old Vyatta BGP code is all but not very easy to maintain. If someone needs to enter maintenance mode you can always workaround this by: vtysh -c "conf t" -c "router bgp <asn>" -c "bgp graceful-shutdown".

Turns out this was actually a very small change in the old framework - implemented also on 1.3 and backported to 1.2.8

c-po claimed this task.
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.
c-po moved this task from Needs Triage to Finished on the VyOS 1.2 Crux (VyOS 1.2.8) board.