interfaces migration script fails on AWS hosts
Closed, WontfixPublicBUG
Actions

Assigned To

Authored By

	lucasec
	Sep 13 2021, 12:16 AM

Description

The recently added migration script https://github.com/vyos/vyos-1x/blob/current/src/migration-scripts/interfaces/20-to-21 fails to run on AWS hosts due to this error captured in the attached log:

i-0b4d268e646362d89.jpg (400×720 px, 88 KB)

The root cause appears to be that ethtool does not report link autonegotiation properties at all for the virtualized NICs on the AWS hosts. E.g., the following is the ethtool output on a previous working equuleus build:

vyos@ip-172-16-1-65:~$ ethtool eth0
Settings for eth0:
	Current message level: 0x000004e3 (1251)
			       drv probe ifup rx_err tx_err tx_done
	Link detected: yes

We could update the AWS config template in vyos-bulid to have a newer version to avoid the migration, but it may be better to patch the migration script to support interfaces that have ethtool output like the above.

Details

Difficulty level: Unknown (require assessment)
Version: vyos-1.3-rolling-202109122106-amd64
Why the issue appeared?: Will be filled on close
Is it a breaking change?: Unspecified (possibly destroys the router)
Issue type: Bug (incorrect behavior)

Event Timeline

lucasec created this task.Sep 13 2021, 12:16 AM

cc: @c-po maybe this was a side effect of unifying the two parsers

Note: config versions were added to the default configs here https://github.com/vyos/vyos-build/commit/23639568a945f19471af88547dab45b87bbd642d, but the current vyos-build-ami replaces the default file with its own that hasn't been modified to add the versioning comment yet. That can probably be fixed whenever that repo is updated for equuleus (I have my own patched local branch that I could publish if desired).

The root issue of the migration script supporting interfaces that don't report autonegotiation settings still stands, as even if default boot works users could still want to migrate an existing config and get bitten by the script.

syncer assigned this task to dmbaturin.Sep 26 2021, 9:53 PM

syncer reassigned this task from dmbaturin to zsdc.Oct 17 2021, 1:38 PM

syncer triaged this task as High priority.

syncer edited projects, added VyOS 1.3 Equuleus (1.3.0-epa3), VyOS 1.4 Sagitta; removed VyOS 1.3 Equuleus.

syncer added a project: VyOS 1.2 Crux (VyOS 1.2.9).

syncer added a subscriber: dmbaturin.

syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus (1.3.0-epa3).Nov 1 2021, 10:11 PM

pasik added a subscriber: pasik.Nov 2 2021, 8:59 AM

syncer edited projects, added VyOS 1.3 Equuleus (1.3.3); removed VyOS 1.3 Equuleus (1.3.0).Aug 29 2022, 7:04 AM

syncer closed this task as Wontfix.Jul 11 2023, 1:23 PM

syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.3) board.Jul 12 2023, 10:24 PM